Move wtf/hash_{functions,traits}.h to "blink" namespace [chromium/src : main]

1 view
Skip to first unread message

Kent Tamura (Gerrit)

unread,
Jul 8, 2025, 1:49:41 AM7/8/25
to Kent Tamura, Daniel Cheng, chromium...@chromium.org, Nate Chapin, Kevin Babbitt, Dirk Schulze, Olga Gerchikov, Kentaro Hara, Jiewei Qian, Luna Lu, (Julie)Jeongeun Kim, Raphael Kubo da Costa, Alexis Menard, ningxin hu, Stephen Chenney, Fredrik Söderquist, AyeAye, Chromium LUCI CQ, mac-r...@chromium.org, ipc-securi...@chromium.org, blink-re...@chromium.org, aleventhal...@chromium.org, loading-re...@chromium.org, yuzo+...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, lucasrada...@google.com, dominicc+...@chromium.org, loading...@chromium.org, iclella...@chromium.org, blink-revi...@chromium.org, fmalit...@chromium.org, antoniosartori+wa...@chromium.org, fserb...@chromium.org, blink-...@chromium.org, josiah...@chromium.org, blink-rev...@chromium.org, core-timi...@chromium.org, blink-revie...@chromium.org, abigailbk...@google.com, kainin...@chromium.org, feature-v...@chromium.org, scheduler-...@chromium.org, web-schedulin...@chromium.org, francisjp...@google.com, feature-me...@chromium.org, drott+bl...@chromium.org, speed-metrics...@chromium.org, blink-reviews-p...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, nektar...@chromium.org, dtseng...@chromium.org, blink-re...@chromium.org, dmurph+watch...@chromium.org, blink-rev...@chromium.org, mattreyno...@chromium.org, webap...@microsoft.com, blink-revi...@chromium.org, jmedle...@chromium.org, devtools-re...@chromium.org, zol...@webkit.org, chikamu...@chromium.org, pdr+svgw...@chromium.org, kouhe...@chromium.org, kouhe...@chromium.org, cwalle...@chromium.org, gavinp...@chromium.org, oilpan-rev...@chromium.org, kyungjunle...@google.com, apavlo...@chromium.org, dom+...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org
Attention needed from Daniel Cheng

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Kent Tamura . resolved

dcheng@, would you review this please?

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I73bee8c3f9de6755eb33688e585ccedaa966ecb0
Gerrit-Change-Number: 6703468
Gerrit-PatchSet: 7
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Luna Lu <loon...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: ningxin hu <ningx...@intel.com>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Tue, 08 Jul 2025 05:49:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Jul 8, 2025, 1:53:15 AM7/8/25
to Kent Tamura, Daniel Cheng, chromium...@chromium.org, Nate Chapin, Kevin Babbitt, Dirk Schulze, Olga Gerchikov, Kentaro Hara, Jiewei Qian, Luna Lu, (Julie)Jeongeun Kim, Raphael Kubo da Costa, Alexis Menard, ningxin hu, Stephen Chenney, Fredrik Söderquist, AyeAye, Chromium LUCI CQ, mac-r...@chromium.org, ipc-securi...@chromium.org, blink-re...@chromium.org, aleventhal...@chromium.org, loading-re...@chromium.org, yuzo+...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, lucasrada...@google.com, dominicc+...@chromium.org, loading...@chromium.org, iclella...@chromium.org, blink-revi...@chromium.org, fmalit...@chromium.org, antoniosartori+wa...@chromium.org, fserb...@chromium.org, blink-...@chromium.org, josiah...@chromium.org, blink-rev...@chromium.org, core-timi...@chromium.org, blink-revie...@chromium.org, abigailbk...@google.com, kainin...@chromium.org, feature-v...@chromium.org, scheduler-...@chromium.org, web-schedulin...@chromium.org, francisjp...@google.com, feature-me...@chromium.org, drott+bl...@chromium.org, speed-metrics...@chromium.org, blink-reviews-p...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, nektar...@chromium.org, dtseng...@chromium.org, blink-re...@chromium.org, dmurph+watch...@chromium.org, blink-rev...@chromium.org, mattreyno...@chromium.org, webap...@microsoft.com, blink-revi...@chromium.org, jmedle...@chromium.org, devtools-re...@chromium.org, zol...@webkit.org, chikamu...@chromium.org, pdr+svgw...@chromium.org, kouhe...@chromium.org, kouhe...@chromium.org, cwalle...@chromium.org, gavinp...@chromium.org, oilpan-rev...@chromium.org, kyungjunle...@google.com, apavlo...@chromium.org, dom+...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org
Attention needed from Kent Tamura

Daniel Cheng voted and added 1 comment

Votes added by Daniel Cheng

Code-Review+1

1 comment

Patchset-level comments
Daniel Cheng . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Gerrit-Attention: Kent Tamura <tk...@chromium.org>
Gerrit-Comment-Date: Tue, 08 Jul 2025 05:53:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Kent Tamura (Gerrit)

unread,
Jul 8, 2025, 1:57:23 AM7/8/25
to Kent Tamura, Daniel Cheng, chromium...@chromium.org, Nate Chapin, Kevin Babbitt, Dirk Schulze, Olga Gerchikov, Kentaro Hara, Jiewei Qian, Luna Lu, (Julie)Jeongeun Kim, Raphael Kubo da Costa, Alexis Menard, ningxin hu, Stephen Chenney, Fredrik Söderquist, AyeAye, Chromium LUCI CQ, mac-r...@chromium.org, ipc-securi...@chromium.org, blink-re...@chromium.org, aleventhal...@chromium.org, loading-re...@chromium.org, yuzo+...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, lucasrada...@google.com, dominicc+...@chromium.org, loading...@chromium.org, iclella...@chromium.org, blink-revi...@chromium.org, fmalit...@chromium.org, antoniosartori+wa...@chromium.org, fserb...@chromium.org, blink-...@chromium.org, josiah...@chromium.org, blink-rev...@chromium.org, core-timi...@chromium.org, blink-revie...@chromium.org, abigailbk...@google.com, kainin...@chromium.org, feature-v...@chromium.org, scheduler-...@chromium.org, web-schedulin...@chromium.org, francisjp...@google.com, feature-me...@chromium.org, drott+bl...@chromium.org, speed-metrics...@chromium.org, blink-reviews-p...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, nektar...@chromium.org, dtseng...@chromium.org, blink-re...@chromium.org, dmurph+watch...@chromium.org, blink-rev...@chromium.org, mattreyno...@chromium.org, webap...@microsoft.com, blink-revi...@chromium.org, jmedle...@chromium.org, devtools-re...@chromium.org, zol...@webkit.org, chikamu...@chromium.org, pdr+svgw...@chromium.org, kouhe...@chromium.org, kouhe...@chromium.org, cwalle...@chromium.org, gavinp...@chromium.org, oilpan-rev...@chromium.org, kyungjunle...@google.com, apavlo...@chromium.org, dom+...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org

Kent Tamura voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Gerrit-Comment-Date: Tue, 08 Jul 2025 05:56:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jul 8, 2025, 2:01:41 AM7/8/25
to Kent Tamura, Daniel Cheng, chromium...@chromium.org, Nate Chapin, Kevin Babbitt, Dirk Schulze, Olga Gerchikov, Kentaro Hara, Jiewei Qian, Luna Lu, (Julie)Jeongeun Kim, Akihiro Ota, Raphael Kubo da Costa, Alexis Menard, ningxin hu, Stephen Chenney, Fredrik Söderquist, AyeAye, mac-r...@chromium.org, ipc-securi...@chromium.org, blink-re...@chromium.org, aleventhal...@chromium.org, loading-re...@chromium.org, yuzo+...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, lucasrada...@google.com, dominicc+...@chromium.org, loading...@chromium.org, iclella...@chromium.org, blink-revi...@chromium.org, fmalit...@chromium.org, antoniosartori+wa...@chromium.org, fserb...@chromium.org, blink-...@chromium.org, josiah...@chromium.org, blink-rev...@chromium.org, core-timi...@chromium.org, blink-revie...@chromium.org, abigailbk...@google.com, kainin...@chromium.org, feature-v...@chromium.org, scheduler-...@chromium.org, web-schedulin...@chromium.org, francisjp...@google.com, feature-me...@chromium.org, drott+bl...@chromium.org, speed-metrics...@chromium.org, blink-reviews-p...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, nektar...@chromium.org, dtseng...@chromium.org, blink-re...@chromium.org, dmurph+watch...@chromium.org, blink-rev...@chromium.org, mattreyno...@chromium.org, webap...@microsoft.com, blink-revi...@chromium.org, jmedle...@chromium.org, devtools-re...@chromium.org, zol...@webkit.org, chikamu...@chromium.org, pdr+svgw...@chromium.org, kouhe...@chromium.org, kouhe...@chromium.org, cwalle...@chromium.org, gavinp...@chromium.org, oilpan-rev...@chromium.org, kyungjunle...@google.com, apavlo...@chromium.org, dom+...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Move wtf/hash_{functions,traits}.h to "blink" namespace

All of HashTraits specializations are moved to "blink" namespace as
well.

This CL adds some WTF::Foo aliases to minimize the CL size. They are
going to be removed by later CLs.

This CL has no behavior changes.
Bug: 422768753
Change-Id: I73bee8c3f9de6755eb33688e585ccedaa966ecb0
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Auto-Submit: Kent Tamura <tk...@chromium.org>
Commit-Queue: Kent Tamura <tk...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1483556}
Files:
  • M mojo/public/cpp/bindings/lib/wtf_hash_util.h
  • M third_party/blink/renderer/bindings/core/v8/boxed_v8_module.h
  • M third_party/blink/renderer/bindings/core/v8/v8_custom_element_constructor_hash.h
  • M third_party/blink/renderer/core/animation/property_handle.h
  • M third_party/blink/renderer/core/css/container_selector.h
  • M third_party/blink/renderer/core/css/css_property_name.h
  • M third_party/blink/renderer/core/css/css_property_value_set.cc
  • M third_party/blink/renderer/core/css/element_rule_collector.cc
  • M third_party/blink/renderer/core/dom/nth_index_cache.h
  • M third_party/blink/renderer/core/dom/qualified_name.h
  • M third_party/blink/renderer/core/frame/ad_script_identifier.h
  • M third_party/blink/renderer/core/highlight/highlight_registry_map_entry.h
  • M third_party/blink/renderer/core/html/custom/custom_element_descriptor_hash.h
  • M third_party/blink/renderer/core/inspector/invalidation_set_to_selector_map.h
  • M third_party/blink/renderer/core/layout/anchor_scope.h
  • M third_party/blink/renderer/core/layout/masonry/masonry_item_group.h
  • M third_party/blink/renderer/core/permissions_policy/policy_helper.h
  • M third_party/blink/renderer/core/style/scoped_css_name.h
  • M third_party/blink/renderer/core/svg/animation/smil_time.h
  • M third_party/blink/renderer/modules/canvas/canvas2d/cached_color.h
  • M third_party/blink/renderer/modules/manifest/image_resource_type_converters.cc
  • M third_party/blink/renderer/modules/ml/webnn/operand_id_hash_traits.h
  • M third_party/blink/renderer/modules/webgpu/gpu.h
  • M third_party/blink/renderer/platform/bindings/trace_wrapper_v8_reference.h
  • M third_party/blink/renderer/platform/fonts/font_cache_key.h
  • M third_party/blink/renderer/platform/fonts/font_description.h
  • M third_party/blink/renderer/platform/fonts/font_selection_types.h
  • M third_party/blink/renderer/platform/geometry/geometry_hash_traits.h
  • M third_party/blink/renderer/platform/graphics/compositor_element_id.h
  • M third_party/blink/renderer/platform/graphics/image_decoding_store.h
  • M third_party/blink/renderer/platform/graphics/paint/display_item.h
  • M third_party/blink/renderer/platform/graphics/resource_id_traits.h
  • M third_party/blink/renderer/platform/graphics/skia/sk_image_info_hash.h
  • M third_party/blink/renderer/platform/graphics/skia/sk_size_hash.h
  • M third_party/blink/renderer/platform/heap/cross_thread_persistent.h
  • M third_party/blink/renderer/platform/heap/member.h
  • M third_party/blink/renderer/platform/heap/persistent.h
  • M third_party/blink/renderer/platform/heap/test/heap_test.cc
  • M third_party/blink/renderer/platform/loader/fetch/preload_key.h
  • M third_party/blink/renderer/platform/network/blink_schemeful_site.h
  • M third_party/blink/renderer/platform/network/ip_address.h
  • M third_party/blink/renderer/platform/scheduler/main_thread/attribution_group.h
  • M third_party/blink/renderer/platform/weborigin/kurl.h
  • M third_party/blink/renderer/platform/weborigin/kurl_hash.h
  • M third_party/blink/renderer/platform/weborigin/security_origin.h
  • M third_party/blink/renderer/platform/wtf/hash_functions.h
  • M third_party/blink/renderer/platform/wtf/hash_map.h
  • M third_party/blink/renderer/platform/wtf/hash_traits.h
  • M third_party/blink/renderer/platform/wtf/key_value_pair.h
  • M third_party/blink/renderer/platform/wtf/linked_hash_set_test.cc
  • M third_party/blink/renderer/platform/wtf/text/atomic_string.h
  • M third_party/blink/renderer/platform/wtf/text/atomic_string_hash.h
  • M third_party/blink/renderer/platform/wtf/text/string_hash.h
  • M third_party/blink/renderer/platform/wtf/text/string_impl.h
  • M third_party/blink/renderer/platform/wtf/text/wtf_string.h
  • M third_party/blink/renderer/platform/wtf/wtf_test_helper.h
Change size: L
Delta: 56 files changed, 366 insertions(+), 461 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Daniel Cheng
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I73bee8c3f9de6755eb33688e585ccedaa966ecb0
Gerrit-Change-Number: 6703468
Gerrit-PatchSet: 8
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages