[iOS] Add unit tests for Drive file picker icon fetch handling [chromium/src : main]

1 view
Skip to first unread message

Quentin Pubert (Gerrit)

unread,
Aug 4, 2026, 11:26:08 AM (20 hours ago) Aug 4
to Olivier Robin, chromium...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Olivier Robin

Quentin Pubert voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Olivier Robin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic929ed39c222c9cb62efdc6264d3447a539fccc6
Gerrit-Change-Number: 8192737
Gerrit-PatchSet: 2
Gerrit-Owner: Quentin Pubert <qpu...@google.com>
Gerrit-Reviewer: Olivier Robin <olivie...@chromium.org>
Gerrit-Reviewer: Quentin Pubert <qpu...@google.com>
Gerrit-Attention: Olivier Robin <olivie...@chromium.org>
Gerrit-Comment-Date: Tue, 04 Aug 2026 15:25:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Olivier Robin (Gerrit)

unread,
Aug 4, 2026, 11:32:12 AM (20 hours ago) Aug 4
to Quentin Pubert, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Quentin Pubert

Olivier Robin voted and added 1 comment

Votes added by Olivier Robin

Code-Review+1

1 comment

File ios/chrome/browser/drive_file_picker/coordinator/drive_file_picker_mediator_unittest.mm
Line 65, Patchset 2 (Latest):- (void)setFetchedIcon:(UIImage*)fetchedIcon
Olivier Robin . unresolved

can we pass a mock imagefetcher instead?

Open in Gerrit

Related details

Attention is currently required from:
  • Quentin Pubert
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic929ed39c222c9cb62efdc6264d3447a539fccc6
    Gerrit-Change-Number: 8192737
    Gerrit-PatchSet: 2
    Gerrit-Owner: Quentin Pubert <qpu...@google.com>
    Gerrit-Reviewer: Olivier Robin <olivie...@chromium.org>
    Gerrit-Reviewer: Quentin Pubert <qpu...@google.com>
    Gerrit-Attention: Quentin Pubert <qpu...@google.com>
    Gerrit-Comment-Date: Tue, 04 Aug 2026 15:31:52 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Quentin Pubert (Gerrit)

    unread,
    5:50 AM (2 hours ago) 5:50 AM
    to Olivier Robin, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
    Attention needed from Olivier Robin

    Quentin Pubert voted and added 1 comment

    Votes added by Quentin Pubert

    Auto-Submit+1
    Commit-Queue+1

    1 comment

    File ios/chrome/browser/drive_file_picker/coordinator/drive_file_picker_mediator_unittest.mm
    Line 65, Patchset 2:- (void)setFetchedIcon:(UIImage*)fetchedIcon
    Olivier Robin . resolved

    can we pass a mock imagefetcher instead?

    Quentin Pubert

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Olivier Robin
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ic929ed39c222c9cb62efdc6264d3447a539fccc6
      Gerrit-Change-Number: 8192737
      Gerrit-PatchSet: 3
      Gerrit-Owner: Quentin Pubert <qpu...@google.com>
      Gerrit-Reviewer: Olivier Robin <olivie...@chromium.org>
      Gerrit-Reviewer: Quentin Pubert <qpu...@google.com>
      Gerrit-Attention: Olivier Robin <olivie...@chromium.org>
      Gerrit-Comment-Date: Wed, 05 Aug 2026 09:49:58 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Olivier Robin <olivie...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Olivier Robin (Gerrit)

      unread,
      6:14 AM (1 hour ago) 6:14 AM
      to Quentin Pubert, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
      Attention needed from Quentin Pubert

      Olivier Robin voted

      Code-Review+1
      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Quentin Pubert
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ic929ed39c222c9cb62efdc6264d3447a539fccc6
        Gerrit-Change-Number: 8192737
        Gerrit-PatchSet: 3
        Gerrit-Owner: Quentin Pubert <qpu...@google.com>
        Gerrit-Reviewer: Olivier Robin <olivie...@chromium.org>
        Gerrit-Reviewer: Quentin Pubert <qpu...@google.com>
        Gerrit-Attention: Quentin Pubert <qpu...@google.com>
        Gerrit-Comment-Date: Wed, 05 Aug 2026 10:14:21 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        6:58 AM (25 minutes ago) 6:58 AM
        to Quentin Pubert, Olivier Robin, chromium...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

        Chromium LUCI CQ submitted the change

        Change information

        Commit message:
        [iOS] Add unit tests for Drive file picker icon fetch handling

        This CL adds unit test coverage for DriveFilePickerMediator icon fetch
        handling to prevent future regressions of crbug.com/458016681.

        Specifically, it adds:
        - DriveFilePickerMediatorTest.FetchIconSuccess: Verifies that when an
          icon is successfully fetched, the mediator passes the non-nil UIImage
          and target item identifiers to the consumer.
        - DriveFilePickerMediatorTest.FetchIconFailure: Verifies that when icon
          fetching fails (returning a nil image), the mediator returns early and
          does not pass nil to the consumer (preventing layout constraint
          crashes in DriveFilePickerContentView).
        Bug: 458016681
        Fixed: 458524081
        Change-Id: Ic929ed39c222c9cb62efdc6264d3447a539fccc6
        Reviewed-by: Olivier Robin <olivie...@chromium.org>
        Commit-Queue: Olivier Robin <olivie...@chromium.org>
        Auto-Submit: Quentin Pubert <qpu...@google.com>
        Commit-Queue: Quentin Pubert <qpu...@google.com>
        Cr-Commit-Position: refs/heads/main@{#1674023}
        Files:
        • M ios/chrome/browser/drive_file_picker/coordinator/BUILD.gn
        • M ios/chrome/browser/drive_file_picker/coordinator/drive_file_picker_image_fetcher.h
        • M ios/chrome/browser/drive_file_picker/coordinator/drive_file_picker_mediator_unittest.mm
        Change size: M
        Delta: 3 files changed, 112 insertions(+), 10 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Olivier Robin
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ic929ed39c222c9cb62efdc6264d3447a539fccc6
        Gerrit-Change-Number: 8192737
        Gerrit-PatchSet: 4
        Gerrit-Owner: Quentin Pubert <qpu...@google.com>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Olivier Robin <olivie...@chromium.org>
        Gerrit-Reviewer: Quentin Pubert <qpu...@google.com>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages