[WebAudio] Fix race condition in WebAudioMediaStreamSource disposal [chromium/src : main]

0 views
Skip to first unread message

Hongchan Choi (Gerrit)

unread,
12:37 PM (2 hours ago) 12:37 PM
to Guido Urdaneta, srirama chandra sekhar, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, eric.c...@apple.com, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, tommyw+w...@chromium.org
Attention needed from Guido Urdaneta

Hongchan Choi added 1 comment

Patchset-level comments
File-level comment, Patchset 19 (Latest):
Hongchan Choi . resolved

Guido - could you take a look at the changes in t/b/r/platform/mediastream?

Open in Gerrit

Related details

Attention is currently required from:
  • Guido Urdaneta
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I80382b24bc7b41702225f55c2151b3fa6bc45042
Gerrit-Change-Number: 7779837
Gerrit-PatchSet: 19
Gerrit-Owner: Hongchan Choi <hong...@chromium.org>
Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
Gerrit-Reviewer: Hongchan Choi <hong...@chromium.org>
Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Guido Urdaneta <gui...@chromium.org>
Gerrit-Comment-Date: Thu, 23 Apr 2026 16:37:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

AI Code Reviewer (Gerrit)

unread,
12:42 PM (2 hours ago) 12:42 PM
to Hongchan Choi, Guido Urdaneta, srirama chandra sekhar, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, eric.c...@apple.com, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, tommyw+w...@chromium.org
Attention needed from Guido Urdaneta

AI Code Reviewer added 1 comment

File third_party/blink/renderer/platform/mediastream/webaudio_media_stream_source.h
Line 59, Patchset 19 (Latest): scoped_refptr<AudioConsumer> GetConsumer() { return consumer_; }
AI Code Reviewer . unresolved

nit: Blink Style Guide: Naming - Precede setters with the word “Set”; use bare words for getters. Consider renaming `GetConsumer()` to `Consumer()` as it is a simple getter and does not conflict with the type name `AudioConsumer`.

To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason


_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Open in Gerrit

Related details

Attention is currently required from:
  • Guido Urdaneta
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I80382b24bc7b41702225f55c2151b3fa6bc45042
    Gerrit-Change-Number: 7779837
    Gerrit-PatchSet: 19
    Gerrit-Owner: Hongchan Choi <hong...@chromium.org>
    Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
    Gerrit-Reviewer: Hongchan Choi <hong...@chromium.org>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
    Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
    Gerrit-Attention: Guido Urdaneta <gui...@chromium.org>
    Gerrit-Comment-Date: Thu, 23 Apr 2026 16:42:36 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Guido Urdaneta (Gerrit)

    unread,
    2:42 PM (23 minutes ago) 2:42 PM
    to Hongchan Choi, AI Code Reviewer, srirama chandra sekhar, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, eric.c...@apple.com, blink-re...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, tommyw+w...@chromium.org
    Attention needed from Hongchan Choi

    Guido Urdaneta voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Hongchan Choi
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I80382b24bc7b41702225f55c2151b3fa6bc45042
    Gerrit-Change-Number: 7779837
    Gerrit-PatchSet: 19
    Gerrit-Owner: Hongchan Choi <hong...@chromium.org>
    Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
    Gerrit-Reviewer: Hongchan Choi <hong...@chromium.org>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-CC: Michael Wilson <mjwi...@chromium.org>
    Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
    Gerrit-Attention: Hongchan Choi <hong...@chromium.org>
    Gerrit-Comment-Date: Thu, 23 Apr 2026 18:42:36 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages