Ginny Huang (Gerrit)

unread,

Oct 13, 2025, 4:41:59 PM10/13/25

to Tina Wang, Guillem Perez, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, dimich...@chromium.org, feature-me...@chromium.org, harringt...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, marq+...@chromium.org, petewi...@chromium.org, srahim...@chromium.org, thegreenf...@chromium.org

Attention needed from Guillem Perez and Tina Wang

Ginny Huang added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Ginny Huang . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:

Guillem Perez
Tina Wang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ginny Huang (Gerrit)

unread,

Oct 13, 2025, 4:42:32 PM10/13/25

to Tina Wang, Guillem Perez, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, dimich...@chromium.org, feature-me...@chromium.org, harringt...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, marq+...@chromium.org, petewi...@chromium.org, srahim...@chromium.org, thegreenf...@chromium.org

Attention needed from Guillem Perez

Ginny Huang removed Tina Wang from this change

Deleted Reviewers:

Tina Wang

Open in Gerrit

Related details

Attention is currently required from:

Guillem Perez

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Guillem Perez (Gerrit)

unread,

Oct 13, 2025, 4:42:57 PM10/13/25

to Ginny Huang, Sergio Collazos, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, dimich...@chromium.org, feature-me...@chromium.org, harringt...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, marq+...@chromium.org, petewi...@chromium.org, srahim...@chromium.org, thegreenf...@chromium.org

Attention needed from Ginny Huang and Sergio Collazos

Guillem Perez voted and added 1 comment

Votes added by Guillem Perez

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Guillem Perez . resolved

LGTM Enums and Features.

Open in Gerrit

Related details

Attention is currently required from:

Ginny Huang
Sergio Collazos

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ginny Huang (Gerrit)

unread,

Oct 13, 2025, 4:44:45 PM10/13/25

to Chromium LUCI CQ, Sergio Collazos, Guillem Perez, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, dimich...@chromium.org, feature-me...@chromium.org, harringt...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, marq+...@chromium.org, petewi...@chromium.org, srahim...@chromium.org, thegreenf...@chromium.org

Attention needed from Sergio Collazos

Ginny Huang added 1 comment

File ios/chrome/browser/browser_view/ui_bundled/BUILD.gn

Line 123, Patchset 2 (Latest): "//ios/chrome/browser/follow/model:service",

Ginny Huang . unresolved

I think I should remove this as well

Open in Gerrit

Related details

Attention is currently required from:

Sergio Collazos

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ginny Huang (Gerrit)

unread,

Oct 13, 2025, 4:46:46 PM10/13/25

to Sergio Collazos, Chromium LUCI CQ, Guillem Perez, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, dimich...@chromium.org, feature-me...@chromium.org, harringt...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, marq+...@chromium.org, petewi...@chromium.org, srahim...@chromium.org, thegreenf...@chromium.org

Ginny Huang removed Sergio Collazos from this change

Deleted Reviewers:

Sergio Collazos

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ginny Huang (Gerrit)

unread,

Oct 13, 2025, 4:57:10 PM10/13/25

to Adam Arcaro, Chromium LUCI CQ, Guillem Perez, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, dimich...@chromium.org, feature-me...@chromium.org, harringt...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, marq+...@chromium.org, petewi...@chromium.org, srahim...@chromium.org, thegreenf...@chromium.org

Attention needed from Adam Arcaro and Guillem Perez

Ginny Huang voted and added 1 comment

Votes added by Ginny Huang

Commit-Queue

+1

1 comment

File ios/chrome/browser/browser_view/ui_bundled/BUILD.gn

Line 123, Patchset 2: "//ios/chrome/browser/follow/model:service",

Ginny Huang . resolved

I think I should remove this as well

Ginny Huang

Done

Open in Gerrit

Related details

Attention is currently required from:

Adam Arcaro
Guillem Perez

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Guillem Perez (Gerrit)

unread,

Oct 13, 2025, 5:03:16 PM10/13/25

to Ginny Huang, Adam Arcaro, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, dimich...@chromium.org, feature-me...@chromium.org, harringt...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, marq+...@chromium.org, petewi...@chromium.org, srahim...@chromium.org, thegreenf...@chromium.org

Attention needed from Adam Arcaro and Ginny Huang

Guillem Perez voted and added 1 comment

Votes added by Guillem Perez

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Guillem Perez . resolved

Still lgtm

Open in Gerrit

Related details

Attention is currently required from:

Adam Arcaro
Ginny Huang

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ginny Huang (Gerrit)

unread,

Oct 13, 2025, 6:19:42 PM10/13/25

to Guillem Perez, Adam Arcaro, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, dimich...@chromium.org, feature-me...@chromium.org, harringt...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, marq+...@chromium.org, petewi...@chromium.org, srahim...@chromium.org, thegreenf...@chromium.org

Attention needed from Adam Arcaro

Ginny Huang voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Adam Arcaro

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ginny Huang (Gerrit)

unread,

Oct 13, 2025, 9:45:59 PM10/13/25

to Mark Cogan, Guillem Perez, Adam Arcaro, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, dimich...@chromium.org, feature-me...@chromium.org, harringt...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, marq+...@chromium.org, petewi...@chromium.org, srahim...@chromium.org, thegreenf...@chromium.org

Attention needed from Adam Arcaro and Mark Cogan

Ginny Huang added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Ginny Huang . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:

Adam Arcaro
Mark Cogan

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Mark Cogan (Gerrit)

unread,

Oct 14, 2025, 8:13:28 AM10/14/25

to Ginny Huang, Guillem Perez, Adam Arcaro, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, dimich...@chromium.org, feature-me...@chromium.org, harringt...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, marq+...@chromium.org, petewi...@chromium.org, srahim...@chromium.org, thegreenf...@chromium.org

Attention needed from Adam Arcaro and Ginny Huang

Mark Cogan voted and added 2 comments

Votes added by Mark Cogan

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Mark Cogan . resolved

LGTM modulo a small request.

File ios/chrome/browser/shared/model/prefs/browser_prefs.mm

Line 231, Patchset 4 (Latest):inline constexpr char kFirstFollowUIShownCount[] =

Mark Cogan . unresolved

Maybe mention in the CL description why these are being moved/added here? It's not obvious amid 2.5kloc of deleted code.

Open in Gerrit

Related details

Attention is currently required from:

Adam Arcaro
Ginny Huang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ginny Huang (Gerrit)

unread,

Oct 14, 2025, 10:36:21 AM10/14/25

to Mark Cogan, Guillem Perez, Adam Arcaro, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, dimich...@chromium.org, feature-me...@chromium.org, harringt...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, marq+...@chromium.org, petewi...@chromium.org, srahim...@chromium.org, thegreenf...@chromium.org

Attention needed from Adam Arcaro

Ginny Huang added 1 comment

File ios/chrome/browser/shared/model/prefs/browser_prefs.mm

Line 231, Patchset 4:inline constexpr char kFirstFollowUIShownCount[] =

Mark Cogan . resolved

Maybe mention in the CL description why these are being moved/added here? It's not obvious amid 2.5kloc of deleted code.

Ginny Huang

Done

Open in Gerrit

Related details

Attention is currently required from:

Adam Arcaro

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Adam Arcaro (Gerrit)

unread,

Oct 14, 2025, 5:50:21 PM10/14/25

to Ginny Huang, Mark Cogan, Guillem Perez, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, dimich...@chromium.org, feature-me...@chromium.org, harringt...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, marq+...@chromium.org, petewi...@chromium.org, srahim...@chromium.org, thegreenf...@chromium.org

Attention needed from Ginny Huang

Adam Arcaro voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Ginny Huang

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Oct 15, 2025, 10:56:12 AM10/15/25

to Ginny Huang, Adam Arcaro, Mark Cogan, Guillem Perez, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, dimich...@chromium.org, feature-me...@chromium.org, harringt...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, marq+...@chromium.org, petewi...@chromium.org, srahim...@chromium.org, thegreenf...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[iOS][follow-deprecation] Remove follow model objects

This CL removes follow model objects that are not being used downstream,
including browser agent, service factory and tab helper. Also properly
deprecate profile prefs used.

Bug: 425685705

Change-Id: Ib210ae71baa0e0000ddd813d7e03533981b811d3

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7037277

Reviewed-by: Guillem Perez <guip...@google.com>

Commit-Queue: Ginny Huang <ginny...@chromium.org>

Reviewed-by: Mark Cogan <ma...@chromium.org>

Reviewed-by: Adam Arcaro <ada...@google.com>

Cr-Commit-Position: refs/heads/main@{#1530206}

Files:

M components/feed/core/v2/metrics_reporter.cc
M components/feed/core/v2/public/common_enums.cc
M components/feed/core/v2/public/common_enums.h
M ios/chrome/app/resources/Settings.bundle/Experimental.plist
M ios/chrome/app/strings/ios_strings.grd
D ios/chrome/app/strings/ios_strings_grd/IDS_IOS_DISCOVER_AND_FOLLOWING_FEED_TITLE.png.sha1
D ios/chrome/app/strings/ios_strings_grd/IDS_IOS_FOLLOWING_FEED_TITLE.png.sha1
D ios/chrome/app/strings/ios_strings_grd/IDS_IOS_FOLLOW_WHILE_BROWSING_IPH.png.sha1
D ios/chrome/app/strings/ios_strings_grd/IDS_IOS_SNACKBAR_ACTION_GO_TO_FEED.png.sha1
D ios/chrome/app/strings/ios_strings_grd/IDS_IOS_SNACKBAR_ACTION_TRY_AGAIN.png.sha1
D ios/chrome/app/strings/ios_strings_grd/IDS_IOS_SNACKBAR_ACTION_UNDO.png.sha1
D ios/chrome/app/strings/ios_strings_grd/IDS_IOS_SNACKBAR_MESSAGE_FOLLOW_FAILED.png.sha1
D ios/chrome/app/strings/ios_strings_grd/IDS_IOS_SNACKBAR_MESSAGE_FOLLOW_SUCCEED.png.sha1
D ios/chrome/app/strings/ios_strings_grd/IDS_IOS_SNACKBAR_MESSAGE_UNFOLLOW_FAILED.png.sha1
D ios/chrome/app/strings/ios_strings_grd/IDS_IOS_SNACKBAR_MESSAGE_UNFOLLOW_SUCCEED.png.sha1
M ios/chrome/browser/browser_view/ui_bundled/BUILD.gn
M ios/chrome/browser/browser_view/ui_bundled/browser_coordinator.mm
M ios/chrome/browser/browser_view/ui_bundled/tab_lifecycle_mediator.mm
M ios/chrome/browser/bubble/public/in_product_help_type.h
M ios/chrome/browser/bubble/ui_bundled/bubble_presenter.h
M ios/chrome/browser/bubble/ui_bundled/bubble_presenter.mm
M ios/chrome/browser/bubble/ui_bundled/bubble_presenter_coordinator.mm
M ios/chrome/browser/discover_feed/model/discover_feed_app_agent_profile_helper.mm
M ios/chrome/browser/follow/model/BUILD.gn
D ios/chrome/browser/follow/model/follow_action_state.h
D ios/chrome/browser/follow/model/follow_browser_agent.h
D ios/chrome/browser/follow/model/follow_browser_agent.mm
D ios/chrome/browser/follow/model/follow_browser_agent_observer_bridge.h
D ios/chrome/browser/follow/model/follow_browser_agent_observer_bridge.mm
D ios/chrome/browser/follow/model/follow_browser_agent_observing.h
D ios/chrome/browser/follow/model/follow_features.h
D ios/chrome/browser/follow/model/follow_features.mm
D ios/chrome/browser/follow/model/follow_java_script_feature.h
D ios/chrome/browser/follow/model/follow_java_script_feature.mm
D ios/chrome/browser/follow/model/follow_java_script_feature_unittest.mm
D ios/chrome/browser/follow/model/follow_service_factory.h
D ios/chrome/browser/follow/model/follow_service_factory.mm
D ios/chrome/browser/follow/model/follow_tab_helper.h
D ios/chrome/browser/follow/model/follow_tab_helper.mm
D ios/chrome/browser/follow/model/follow_util.h
D ios/chrome/browser/follow/model/follow_util.mm
D ios/chrome/browser/follow/model/follow_util_unittest.mm
D ios/chrome/browser/follow/model/resources/rss_link.ts
M ios/chrome/browser/main/model/BUILD.gn
M ios/chrome/browser/main/model/DEPS
M ios/chrome/browser/main/model/browser_agent_util.mm
M ios/chrome/browser/ntp/shared/metrics/feed_metrics_constants.h
M ios/chrome/browser/ntp/shared/metrics/feed_metrics_constants.mm
M ios/chrome/browser/ntp/shared/metrics/feed_metrics_recorder.h
M ios/chrome/browser/ntp/shared/metrics/feed_metrics_recorder.mm
M ios/chrome/browser/ntp/ui_bundled/DEPS
M ios/chrome/browser/profile/model/BUILD.gn
M ios/chrome/browser/profile/model/keyed_service_factories.mm
M ios/chrome/browser/settings/ui_bundled/settings_table_view_controller.mm
M ios/chrome/browser/shared/model/prefs/browser_prefs.mm
M ios/chrome/browser/shared/model/prefs/pref_names.h
M ios/chrome/browser/shared/public/commands/new_tab_page_commands.h
M ios/chrome/browser/shared/public/features/features.h
M ios/chrome/browser/shared/public/features/features.mm
M ios/chrome/browser/shared/public/features/system_flags.h
M ios/chrome/browser/shared/public/features/system_flags.mm
M ios/chrome/browser/tabs/model/BUILD.gn
M ios/chrome/browser/tabs/model/tab_helper_util.mm
M ios/chrome/browser/web/model/BUILD.gn
M ios/chrome/browser/web/model/chrome_web_client.mm
M ios/chrome/test/BUILD.gn
M tools/metrics/actions/actions.xml
M tools/metrics/histograms/metadata/content/enums.xml
M tools/metrics/histograms/metadata/content/histograms.xml

Change size: XL

Delta: 69 files changed, 27 insertions(+), 2509 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Mark Cogan, +1 by Guillem Perez, +1 by Adam Arcaro

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Alexei Svitkine (Gerrit)

unread,

2:55 PM (5 hours ago) 2:55 PM

to Chromium LUCI CQ, Ginny Huang, Adam Arcaro, Mark Cogan, Guillem Perez, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, dimich...@chromium.org, feature-me...@chromium.org, harringt...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, marq+...@chromium.org, petewi...@chromium.org, srahim...@chromium.org, thegreenf...@chromium.org

Attention needed from Ginny Huang

Alexei Svitkine added 1 comment

File tools/metrics/histograms/metadata/content/histograms.xml

Line 1553, Patchset 8 (Parent):<histogram name="ContentSuggestions.Feed.WebFeed.FollowCount.{Event}"

Alexei Svitkine . unresolved

Hi, I just noticed that this CL removed these XML entries, but the histograms are still being logged:
https://source.chromium.org/chromium/chromium/src/+/main:components/feed/core/v2/metrics_reporter.cc;drc=4dd12aa131ec6e6a217c10fc2409c2201ba66b34;l=1183

Open in Gerrit

Related details

Attention is currently required from:

Ginny Huang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[iOS][follow-deprecation] Remove follow model objects [chromium/src : main]

Ginny Huang (Gerrit)

Ginny Huang added 1 comment

Related details

Ginny Huang (Gerrit)

Ginny Huang removed Tina Wang from this change

Related details

Guillem Perez (Gerrit)

Guillem Perez voted and added 1 comment

Votes added by Guillem Perez

1 comment

Related details

Ginny Huang (Gerrit)

Ginny Huang added 1 comment

Related details

Ginny Huang (Gerrit)

Ginny Huang removed Sergio Collazos from this change

Related details

Ginny Huang (Gerrit)

Ginny Huang voted and added 1 comment

Votes added by Ginny Huang

1 comment

Related details

Guillem Perez (Gerrit)

Guillem Perez voted and added 1 comment

Votes added by Guillem Perez

1 comment

Related details

Ginny Huang (Gerrit)

Ginny Huang voted Commit-Queue+1

Related details

Ginny Huang (Gerrit)

Ginny Huang added 1 comment

Related details

Mark Cogan (Gerrit)

Mark Cogan voted and added 2 comments

Votes added by Mark Cogan

2 comments

Related details

Ginny Huang (Gerrit)

Ginny Huang added 1 comment

Related details

Adam Arcaro (Gerrit)

Adam Arcaro voted Code-Review+1

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information

Alexei Svitkine (Gerrit)

Alexei Svitkine added 1 comment

Related details