[refactor] Rename OnFileUploadStatus* to OnContextUploadStatus* [chromium/src : main]

0 views
Skip to first unread message

Tibor Goldschwendt (Gerrit)

unread,
Mar 11, 2026, 4:43:56 PMMar 11
to Bofeng Chen, Roman Arora, Sophie Chang, AyeAye, Chromium LUCI CQ, marq+...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ender...@chromium.org, ananyasee...@google.com, christia...@chromium.org, niharm...@google.com, stanfie...@google.com, mercer...@google.com, lens-chrome...@google.com, jdonnel...@chromium.org, ios-r...@chromium.org, omnibox-...@chromium.org
Attention needed from Bofeng Chen and Roman Arora

Tibor Goldschwendt voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Bofeng Chen
  • Roman Arora
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic5a02ca3ddecc82e2e4dc85d6ce1e0a9b1937f31
Gerrit-Change-Number: 7654690
Gerrit-PatchSet: 8
Gerrit-Owner: Bofeng Chen <bofen...@google.com>
Gerrit-Reviewer: Bofeng Chen <bofen...@google.com>
Gerrit-Reviewer: Roman Arora <roman...@chromium.org>
Gerrit-Reviewer: Tibor Goldschwendt <tib...@chromium.org>
Gerrit-CC: Sophie Chang <sophi...@chromium.org>
Gerrit-Attention: Roman Arora <roman...@chromium.org>
Gerrit-Attention: Bofeng Chen <bofen...@google.com>
Gerrit-Comment-Date: Wed, 11 Mar 2026 20:43:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Bofeng Chen (Gerrit)

unread,
Mar 11, 2026, 4:56:27 PMMar 11
to Jennifer Serrano, Tibor Goldschwendt, Roman Arora, Sophie Chang, AyeAye, Chromium LUCI CQ, marq+...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ender...@chromium.org, ananyasee...@google.com, christia...@chromium.org, niharm...@google.com, stanfie...@google.com, mercer...@google.com, lens-chrome...@google.com, jdonnel...@chromium.org, ios-r...@chromium.org, omnibox-...@chromium.org
Attention needed from Jennifer Serrano and Roman Arora

Bofeng Chen added 1 comment

Patchset-level comments
File-level comment, Patchset 8 (Latest):
Bofeng Chen . resolved

Hey @jenns...@google.com, could you help take a look at changes to file `composebox_input_plate_mediator.mm`? Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Jennifer Serrano
  • Roman Arora
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic5a02ca3ddecc82e2e4dc85d6ce1e0a9b1937f31
Gerrit-Change-Number: 7654690
Gerrit-PatchSet: 8
Gerrit-Owner: Bofeng Chen <bofen...@google.com>
Gerrit-Reviewer: Bofeng Chen <bofen...@google.com>
Gerrit-Reviewer: Jennifer Serrano <jenns...@google.com>
Gerrit-Reviewer: Roman Arora <roman...@chromium.org>
Gerrit-Reviewer: Tibor Goldschwendt <tib...@chromium.org>
Gerrit-CC: Sophie Chang <sophi...@chromium.org>
Gerrit-Attention: Roman Arora <roman...@chromium.org>
Gerrit-Attention: Jennifer Serrano <jenns...@google.com>
Gerrit-Comment-Date: Wed, 11 Mar 2026 20:56:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Bofeng Chen (Gerrit)

unread,
Mar 11, 2026, 5:03:08 PMMar 11
to Jennifer Serrano, Tibor Goldschwendt, Roman Arora, Sophie Chang, AyeAye, Chromium LUCI CQ, marq+...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ender...@chromium.org, ananyasee...@google.com, christia...@chromium.org, niharm...@google.com, stanfie...@google.com, mercer...@google.com, lens-chrome...@google.com, jdonnel...@chromium.org, ios-r...@chromium.org, omnibox-...@chromium.org
Attention needed from Jennifer Serrano and Roman Arora

Bofeng Chen added 1 comment

Commit Message
Line 9, Patchset 3:This change renames the `OnFileUploadStatusChanged` method in
Tibor Goldschwendt . resolved

From what I understand, this CL doesn't rename but adds a new listener OnContextUploadStatusChanged. Did I get that right? If so, is the goal that both OnFileUploadStatusChanged and OnContextUploadStatusChanged are called whenever there is an update? Can we instead do a rename and remove OnFileUploadStatusChanged from the code base? I am a bit worried that if we have both OnFileUploadStatusChanged and OnContextUploadStatusChanged, that we will run into subtle where one is called but not the other, or double calls that cause weird behaviors.

Bofeng Chen

Thanks for the review, was going for a 2-phase solution for the renaming task. Rename all occurrences to `OnContextUploadStatusChanged`, and this should prevent the subtle unexpected behaviors.

Bofeng Chen

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Jennifer Serrano
  • Roman Arora
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic5a02ca3ddecc82e2e4dc85d6ce1e0a9b1937f31
    Gerrit-Change-Number: 7654690
    Gerrit-PatchSet: 8
    Gerrit-Owner: Bofeng Chen <bofen...@google.com>
    Gerrit-Reviewer: Bofeng Chen <bofen...@google.com>
    Gerrit-Reviewer: Jennifer Serrano <jenns...@google.com>
    Gerrit-Reviewer: Roman Arora <roman...@chromium.org>
    Gerrit-Reviewer: Tibor Goldschwendt <tib...@chromium.org>
    Gerrit-CC: Sophie Chang <sophi...@chromium.org>
    Gerrit-Attention: Roman Arora <roman...@chromium.org>
    Gerrit-Attention: Jennifer Serrano <jenns...@google.com>
    Gerrit-Comment-Date: Wed, 11 Mar 2026 21:02:59 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Bofeng Chen <bofen...@google.com>
    Comment-In-Reply-To: Tibor Goldschwendt <tib...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Jennifer Serrano (Gerrit)

    unread,
    Mar 11, 2026, 5:24:23 PMMar 11
    to Bofeng Chen, Tibor Goldschwendt, Roman Arora, Sophie Chang, AyeAye, Chromium LUCI CQ, marq+...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ender...@chromium.org, ananyasee...@google.com, christia...@chromium.org, niharm...@google.com, stanfie...@google.com, mercer...@google.com, lens-chrome...@google.com, jdonnel...@chromium.org, ios-r...@chromium.org, omnibox-...@chromium.org
    Attention needed from Bofeng Chen and Roman Arora

    Jennifer Serrano voted and added 1 comment

    Votes added by Jennifer Serrano

    Code-Review+1

    1 comment

    Patchset-level comments
    Jennifer Serrano . resolved

    ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.mm lgtm!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Bofeng Chen
    • Roman Arora
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic5a02ca3ddecc82e2e4dc85d6ce1e0a9b1937f31
    Gerrit-Change-Number: 7654690
    Gerrit-PatchSet: 8
    Gerrit-Owner: Bofeng Chen <bofen...@google.com>
    Gerrit-Reviewer: Bofeng Chen <bofen...@google.com>
    Gerrit-Reviewer: Jennifer Serrano <jenns...@google.com>
    Gerrit-Reviewer: Roman Arora <roman...@chromium.org>
    Gerrit-Reviewer: Tibor Goldschwendt <tib...@chromium.org>
    Gerrit-CC: Sophie Chang <sophi...@chromium.org>
    Gerrit-Attention: Roman Arora <roman...@chromium.org>
    Gerrit-Attention: Bofeng Chen <bofen...@google.com>
    Gerrit-Comment-Date: Wed, 11 Mar 2026 21:24:10 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Bofeng Chen (Gerrit)

    unread,
    Mar 11, 2026, 5:27:02 PMMar 11
    to Jennifer Serrano, Tibor Goldschwendt, Roman Arora, Sophie Chang, AyeAye, Chromium LUCI CQ, marq+...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ender...@chromium.org, ananyasee...@google.com, christia...@chromium.org, niharm...@google.com, stanfie...@google.com, mercer...@google.com, lens-chrome...@google.com, jdonnel...@chromium.org, ios-r...@chromium.org, omnibox-...@chromium.org
    Attention needed from Roman Arora

    Bofeng Chen voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Roman Arora
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic5a02ca3ddecc82e2e4dc85d6ce1e0a9b1937f31
    Gerrit-Change-Number: 7654690
    Gerrit-PatchSet: 8
    Gerrit-Owner: Bofeng Chen <bofen...@google.com>
    Gerrit-Reviewer: Bofeng Chen <bofen...@google.com>
    Gerrit-Reviewer: Jennifer Serrano <jenns...@google.com>
    Gerrit-Reviewer: Roman Arora <roman...@chromium.org>
    Gerrit-Reviewer: Tibor Goldschwendt <tib...@chromium.org>
    Gerrit-CC: Sophie Chang <sophi...@chromium.org>
    Gerrit-Attention: Roman Arora <roman...@chromium.org>
    Gerrit-Comment-Date: Wed, 11 Mar 2026 21:26:52 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Mar 11, 2026, 5:30:15 PMMar 11
    to Bofeng Chen, Jennifer Serrano, Tibor Goldschwendt, Roman Arora, Sophie Chang, AyeAye, marq+...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ender...@chromium.org, ananyasee...@google.com, christia...@chromium.org, niharm...@google.com, stanfie...@google.com, mercer...@google.com, lens-chrome...@google.com, jdonnel...@chromium.org, ios-r...@chromium.org, omnibox-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [refactor] Rename OnFileUploadStatus* to OnContextUploadStatus*

    This change renames the observer method OnFileUploadStatusChanged to
    OnContextUploadStatusChanged and updates the parameter names from
    file_token to context_token and file_upload_status to
    context_upload_status across all implementing classes and call sites.
    This better reflects that the status updates are for general contextual
    data uploads, not just files.
    Bug: b:488378154
    Change-Id: Ic5a02ca3ddecc82e2e4dc85d6ce1e0a9b1937f31
    Reviewed-by: Tibor Goldschwendt <tib...@chromium.org>
    Reviewed-by: Jennifer Serrano <jenns...@google.com>
    Commit-Queue: Bofeng Chen <bofen...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1597994}
    Files:
    • M chrome/browser/android/omnibox/composebox_query_controller_bridge.cc
    • M chrome/browser/android/omnibox/composebox_query_controller_bridge.h
    • M chrome/browser/contextual_tasks/contextual_tasks_composebox_handler.cc
    • M chrome/browser/contextual_tasks/contextual_tasks_composebox_handler.h
    • M chrome/browser/contextual_tasks/contextual_tasks_composebox_handler_unittest.cc
    • M chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/fusebox/ComposeboxQueryControllerBridge.java
    • M chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/fusebox/FuseboxAttachmentModelList.java
    • M chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/fusebox/FuseboxAttachmentModelListUnitTest.java
    • M chrome/browser/ui/lens/lens_query_flow_router.cc
    • M chrome/browser/ui/lens/lens_query_flow_router.h
    • M chrome/browser/ui/lens/lens_query_flow_router_unittest.cc
    • M chrome/browser/ui/webui/cr_components/searchbox/contextual_searchbox_handler.cc
    • M chrome/browser/ui/webui/cr_components/searchbox/contextual_searchbox_handler.h
    • M chrome/browser/ui/webui/searchbox/contextual_searchbox_handler_unittest.cc
    • M chrome/browser/ui/webui/searchbox/contextual_searchbox_test_utils.h
    • M components/contextual_search/contextual_search_context_controller.h
    • M components/contextual_search/contextual_search_metrics_recorder.cc
    • M components/contextual_search/contextual_search_metrics_recorder.h
    • M components/contextual_search/contextual_search_metrics_recorder_unittest.cc
    • M components/contextual_search/contextual_search_session_entry.cc
    • M components/contextual_search/contextual_search_session_entry.h
    • M components/contextual_search/contextual_search_session_entry_unittest.cc
    • M components/contextual_search/internal/composebox_query_controller.cc
    • M components/contextual_search/internal/composebox_query_controller_unittest.cc
    • M components/omnibox/composebox/ios/composebox_file_upload_observer_bridge.h
    • M components/omnibox/composebox/ios/composebox_file_upload_observer_bridge.mm
    • M ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.mm
    Change size: L
    Delta: 27 files changed, 220 insertions(+), 215 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Tibor Goldschwendt, +1 by Jennifer Serrano
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic5a02ca3ddecc82e2e4dc85d6ce1e0a9b1937f31
    Gerrit-Change-Number: 7654690
    Gerrit-PatchSet: 9
    Gerrit-Owner: Bofeng Chen <bofen...@google.com>
    Gerrit-Reviewer: Bofeng Chen <bofen...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Jennifer Serrano <jenns...@google.com>
    Gerrit-Reviewer: Roman Arora <roman...@chromium.org>
    Gerrit-Reviewer: Tibor Goldschwendt <tib...@chromium.org>
    Gerrit-CC: Sophie Chang <sophi...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages