[iOS][PRDBD] Adds QuickDeleteOtherDataVC and "other data" delegates [chromium/src : main]
Noémie St-Onge (Gerrit)
Noémie St-Onge added 7 comments![]( "Open in Gerrit")
- (void)stopOtherDataPage {this coordinator should set itself as the `_otherDataCoordinator`'s delegate in `showOtherDataPage`. Otherwise, this function will never be executed. The delegate should also be set to `nil` before calling `[_otherDataCoordinator stop]`
#pragma mark - QuickDeleteOtherDataDelegate
- (void)stopOtherDataPage {
[_otherDataCoordinator stop];
_otherDataCoordinator = nil;
// TODO(crbug.com/476398061) Move voiceover focus to the appropriate row in
// QuickDeleteBrowsingDataViewController.
}I would move this between the `QuickDeleteOtherDataDelegate` and `SignoutActionSheetCoordinatorDelegate` pragma marks to respect the alphabetical order
_navigationController = [[UINavigationController alloc]
initWithRootViewController:_viewController];
_navigationController.modalPresentationStyle = UIModalPresentationFormSheet;
_navigationController.presentationController.delegate = self;
[self.baseViewController presentViewController:_navigationControllerThe "Manage other data" page should be presented in the same navigation stack as the "Browsing data" page, that's how we're going to get the back navigation bar button. Here we're creating a new navigation stack, which is only going to contain the "Manage other data" page
- (void)dismissOtherDataPage {
[self.delegate stopOtherDataPage];
}we try to avoid message forwarding go/bling-best-practices#message-forwarding
// Provides the tableview for Quick Delete Other Data.`table view`
- (instancetype)init {
UITableViewStyle style = ChromeTableViewStyle();
return [super initWithStyle:style];
}No need to override a method if we're just going to call the superclass implementation
- (void)viewDidLoad {
[super viewDidLoad];
}No need to override a method if we're just going to call the superclass implementation
Related details
- Angela Novakovic
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |