Enable more webrtc/sharing related tests for Android. [chromium/src : main]

0 views
Skip to first unread message

Eliot Courtney (Gerrit)

unread,
Oct 17, 2025, 4:36:09 AM10/17/25
to Elad Alon, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, chfreme...@chromium.org, feature-me...@chromium.org, rmcelra...@chromium.org
Attention needed from Elad Alon

Eliot Courtney added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Eliot Courtney . unresolved
Hi Elad, I found that 
WebRtcEventLogManagerTestOnMobileDevices.RemoteBoundLoggingDisabled
 is failing on Android (so it's actually starting the logging). Before I look into this too deeply, do you know if that's expected or what? This test wasn't running/built on Android before. Thanks
Open in Gerrit

Related details

Attention is currently required from:
  • Elad Alon
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6fbfcb7b1f8ff0ed137c9fa942e5bc229f3fde7b
Gerrit-Change-Number: 7052583
Gerrit-PatchSet: 4
Gerrit-Owner: Eliot Courtney <edcou...@chromium.org>
Gerrit-Reviewer: Elad Alon <elad...@chromium.org>
Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Elad Alon <elad...@chromium.org>
Gerrit-Comment-Date: Fri, 17 Oct 2025 08:35:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Elad Alon (Gerrit)

unread,
Oct 17, 2025, 6:34:21 AM10/17/25
to Eliot Courtney, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, chfreme...@chromium.org, feature-me...@chromium.org, rmcelra...@chromium.org
Attention needed from Eliot Courtney

Elad Alon voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Eliot Courtney
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6fbfcb7b1f8ff0ed137c9fa942e5bc229f3fde7b
Gerrit-Change-Number: 7052583
Gerrit-PatchSet: 4
Gerrit-Owner: Eliot Courtney <edcou...@chromium.org>
Gerrit-Reviewer: Elad Alon <elad...@chromium.org>
Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Eliot Courtney <edcou...@chromium.org>
Gerrit-Comment-Date: Fri, 17 Oct 2025 10:34:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Elad Alon (Gerrit)

unread,
Oct 20, 2025, 4:34:49 AM10/20/25
to Eliot Courtney, Guido Urdaneta, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, chfreme...@chromium.org, feature-me...@chromium.org, rmcelra...@chromium.org
Attention needed from Eliot Courtney

Elad Alon added 1 comment

Patchset-level comments
Eliot Courtney . unresolved
Hi Elad, I found that 
WebRtcEventLogManagerTestOnMobileDevices.RemoteBoundLoggingDisabled
 is failing on Android (so it's actually starting the logging). Before I look into this too deeply, do you know if that's expected or what? This test wasn't running/built on Android before. Thanks
Elad Alon

So far you have only enabled tests, and that's OK. But before you actually enable the uploading of the logs, please make sure that:
1. There is someone intending to ingest them in the foreseeable future.
2. The impact on performance has been measured and approved.

Additionally, there is work underway to revamp the way these logs are collected. Guido (guidou@) is you man there.

Open in Gerrit

Related details

Attention is currently required from:
  • Eliot Courtney
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6fbfcb7b1f8ff0ed137c9fa942e5bc229f3fde7b
Gerrit-Change-Number: 7052583
Gerrit-PatchSet: 4
Gerrit-Owner: Eliot Courtney <edcou...@chromium.org>
Gerrit-Reviewer: Elad Alon <elad...@chromium.org>
Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Guido Urdaneta <gui...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Eliot Courtney <edcou...@chromium.org>
Gerrit-Comment-Date: Mon, 20 Oct 2025 08:34:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eliot Courtney <edcou...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Eliot Courtney (Gerrit)

unread,
Nov 11, 2025, 2:07:02 AM11/11/25
to Guido Urdaneta, Elad Alon, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, chfreme...@chromium.org, feature-me...@chromium.org, rmcelra...@chromium.org
Attention needed from Guido Urdaneta

Eliot Courtney added 1 comment

Patchset-level comments
Eliot Courtney . unresolved

Hi Guido,
I found that
WebRtcEventLogManagerTestOnMobileDevices.RemoteBoundLoggingDisabled
is failing on Android (so it's actually starting the logging). I heard you might have a plan for this file or something, do you have a recommendation here? Maybe I can just not enable this test or disable logging for android etc

WDYT?
Thanks

Open in Gerrit

Related details

Attention is currently required from:
  • Guido Urdaneta
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6fbfcb7b1f8ff0ed137c9fa942e5bc229f3fde7b
Gerrit-Change-Number: 7052583
Gerrit-PatchSet: 4
Gerrit-Owner: Eliot Courtney <edcou...@chromium.org>
Gerrit-Reviewer: Elad Alon <elad...@chromium.org>
Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Guido Urdaneta <gui...@chromium.org>
Gerrit-Comment-Date: Tue, 11 Nov 2025 07:06:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Guido Urdaneta (Gerrit)

unread,
Nov 25, 2025, 6:16:56 AM11/25/25
to Eliot Courtney, Code Review Nudger, Elad Alon, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, chfreme...@chromium.org, feature-me...@chromium.org, rmcelra...@chromium.org
Attention needed from Eliot Courtney

Guido Urdaneta voted and added 1 comment

Votes added by Guido Urdaneta

Code-Review+1

1 comment

Patchset-level comments
Guido Urdaneta . resolved

lgtm, but look at the test failures

Open in Gerrit

Related details

Attention is currently required from:
  • Eliot Courtney
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6fbfcb7b1f8ff0ed137c9fa942e5bc229f3fde7b
Gerrit-Change-Number: 7052583
Gerrit-PatchSet: 4
Gerrit-Owner: Eliot Courtney <edcou...@chromium.org>
Gerrit-Reviewer: Elad Alon <elad...@chromium.org>
Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Eliot Courtney <edcou...@chromium.org>
Gerrit-Comment-Date: Tue, 25 Nov 2025 11:16:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Grace Cham (Gerrit)

unread,
Jul 10, 2026, 2:57:17 AMJul 10
to Eliot Courtney, Eric Lok, Guido Urdaneta, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, chfreme...@chromium.org, feature-me...@chromium.org, rmcelra...@chromium.org
Attention needed from Eliot Courtney

Grace Cham added 1 comment

Patchset-level comments
Grace Cham . resolved

Note to Eric who will take over remaining media capture work: Eliot was trying to enable these test but some were failing on the builders

Open in Gerrit

Related details

Attention is currently required from:
  • Eliot Courtney
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6fbfcb7b1f8ff0ed137c9fa942e5bc229f3fde7b
    Gerrit-Change-Number: 7052583
    Gerrit-PatchSet: 4
    Gerrit-Owner: Eliot Courtney <edcou...@chromium.org>
    Gerrit-Reviewer: Eliot Courtney <edcou...@chromium.org>
    Gerrit-Reviewer: Guido Urdaneta <gui...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-CC: Eric Lok <lok...@google.com>
    Gerrit-CC: Grace Cham <hsc...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-Attention: Eliot Courtney <edcou...@chromium.org>
    Gerrit-Comment-Date: Fri, 10 Jul 2026 06:56:45 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Guido Urdaneta (Gerrit)

    unread,
    6:20 AM (1 hour ago) 6:20 AM
    to Eliot Courtney, Eric Lok, Grace Cham, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, chfreme...@chromium.org, feature-me...@chromium.org, rmcelra...@chromium.org
    Attention needed from Eliot Courtney

    Guido Urdaneta added 1 comment

    Patchset-level comments
    Grace Cham . unresolved

    Note to Eric who will take over remaining media capture work: Eliot was trying to enable these test but some were failing on the builders

    Guido Urdaneta

    Since you're now making the webrrc_event_log_manager files to be built on android you should remove the android compile guards and the android-specific `WebRtcEventLogManagerTestOnMobileDevices` in chrome/browser/media/webrtc/webrtc_event_log_manager_remote.cc so that the full tests run on Android.

    The android-specific version of the test failing in the bot is one that was assuming this code was not compiled for Android.

    Gerrit-Comment-Date: Wed, 05 Aug 2026 10:20:37 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Grace Cham <hsc...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages