[TDR] Remove TODOs linked to issue 40167137 [chromium/src : main]

0 views
Skip to first unread message

Tomasz Lichoń (Gerrit)

unread,
Jan 19, 2026, 7:53:13 AM (3 days ago) Jan 19
to Philip Eliasson, AyeAye, feature-me...@chromium.org
Attention needed from Philip Eliasson

Message from Tomasz Lichoń

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • Philip Eliasson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I94e3cfc439542b6c9182ffd74a13a5531255ecba
Gerrit-Change-Number: 7486417
Gerrit-PatchSet: 2
Gerrit-Owner: Tomasz Lichoń <lic...@google.com>
Gerrit-Reviewer: Philip Eliasson <phil...@chromium.org>
Gerrit-Attention: Philip Eliasson <phil...@chromium.org>
Gerrit-Comment-Date: Mon, 19 Jan 2026 12:52:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Philip Eliasson (Gerrit)

unread,
Jan 19, 2026, 8:50:23 AM (3 days ago) Jan 19
to Tomasz Lichoń, AyeAye, feature-me...@chromium.org
Attention needed from Tomasz Lichoń

Philip Eliasson voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Tomasz Lichoń
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I94e3cfc439542b6c9182ffd74a13a5531255ecba
    Gerrit-Change-Number: 7486417
    Gerrit-PatchSet: 2
    Gerrit-Owner: Tomasz Lichoń <lic...@google.com>
    Gerrit-Reviewer: Philip Eliasson <phil...@chromium.org>
    Gerrit-Attention: Tomasz Lichoń <lic...@google.com>
    Gerrit-Comment-Date: Mon, 19 Jan 2026 13:50:14 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Rick Byers (Gerrit)

    unread,
    Jan 20, 2026, 1:26:16 PM (2 days ago) Jan 20
    to Tomasz Lichoń, Philip Eliasson, AyeAye, feature-me...@chromium.org
    Attention needed from Tomasz Lichoń

    Rick Byers voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Tomasz Lichoń
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I94e3cfc439542b6c9182ffd74a13a5531255ecba
      Gerrit-Change-Number: 7486417
      Gerrit-PatchSet: 2
      Gerrit-Owner: Tomasz Lichoń <lic...@google.com>
      Gerrit-Reviewer: Philip Eliasson <phil...@chromium.org>
      Gerrit-Reviewer: Rick Byers <rby...@chromium.org>
      Gerrit-Attention: Tomasz Lichoń <lic...@google.com>
      Gerrit-Comment-Date: Tue, 20 Jan 2026 18:26:07 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Ted (Chromium) Meyer (Gerrit)

      unread,
      Jan 21, 2026, 1:38:38 PM (21 hours ago) Jan 21
      to Tomasz Lichoń, Rick Byers, Philip Eliasson, AyeAye, feature-me...@chromium.org
      Attention needed from Tomasz Lichoń

      Ted (Chromium) Meyer voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Tomasz Lichoń
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I94e3cfc439542b6c9182ffd74a13a5531255ecba
      Gerrit-Change-Number: 7486417
      Gerrit-PatchSet: 2
      Gerrit-Owner: Tomasz Lichoń <lic...@google.com>
      Gerrit-Reviewer: Philip Eliasson <phil...@chromium.org>
      Gerrit-Reviewer: Rick Byers <rby...@chromium.org>
      Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
      Gerrit-Attention: Tomasz Lichoń <lic...@google.com>
      Gerrit-Comment-Date: Wed, 21 Jan 2026 18:38:27 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Tomasz Lichoń (Gerrit)

      unread,
      5:50 AM (5 hours ago) 5:50 AM
      to Ted (Chromium) Meyer, Rick Byers, Philip Eliasson, AyeAye, feature-me...@chromium.org

      Tomasz Lichoń voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I94e3cfc439542b6c9182ffd74a13a5531255ecba
      Gerrit-Change-Number: 7486417
      Gerrit-PatchSet: 2
      Gerrit-Owner: Tomasz Lichoń <lic...@google.com>
      Gerrit-Reviewer: Philip Eliasson <phil...@chromium.org>
      Gerrit-Reviewer: Rick Byers <rby...@chromium.org>
      Gerrit-Reviewer: Ted (Chromium) Meyer <tmath...@chromium.org>
      Gerrit-Reviewer: Tomasz Lichoń <lic...@google.com>
      Gerrit-Comment-Date: Thu, 22 Jan 2026 10:49:56 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Tomasz Lichoń (Gerrit)

      unread,
      7:38 AM (3 hours ago) 7:38 AM
      to Chromium LUCI CQ, Ted (Chromium) Meyer, Rick Byers, Philip Eliasson, AyeAye, feature-me...@chromium.org
      Gerrit-Comment-Date: Thu, 22 Jan 2026 12:38:31 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      8:07 AM (2 hours ago) 8:07 AM
      to Tomasz Lichoń, Ted (Chromium) Meyer, Rick Byers, Philip Eliasson, AyeAye, feature-me...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      [TDR] Remove TODOs linked to issue 40167137

      This CL was generated by an AI agent and verified by the CL owner before
      sending for review. The TODOs were identified as stale by TODO Removal
      Agent (http://go/dead-todo-removal-agent).
      * Detailed reasoning can be found in the CL comments.
      * How to review this CL: http://go/tdr-review-instructions
      * To opt-out from future reviews: http://go/tdr-opt-out.

      The associated bug crbug.com/40167137 is marked as 'FIXED'. The
      investigation reveals that the function GetSupportedVideoDecoderConfigs,
      which the TODO requests to be implemented, was subsequently removed from
      the base class DecoderFactory in a later CL
      (https://crrev.com/c/3929659). The commit message explains that the
      function was unused. Since the target function no longer exists, the
      TODO is obsolete.
      Change-Id: I94e3cfc439542b6c9182ffd74a13a5531255ecba
      Bug: 40167137
      Commit-Queue: Tomasz Lichoń <lic...@google.com>
      Reviewed-by: Rick Byers <rby...@chromium.org>
      Reviewed-by: Ted (Chromium) Meyer <tmath...@chromium.org>
      Reviewed-by: Philip Eliasson <phil...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1572920}
      Files:
      • M media/mojo/clients/mojo_decoder_factory.h
      Change size: XS
      Delta: 1 file changed, 0 insertions(+), 2 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Rick Byers, +1 by Ted (Chromium) Meyer, +1 by Philip Eliasson
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I94e3cfc439542b6c9182ffd74a13a5531255ecba
      Gerrit-Change-Number: 7486417
      Gerrit-PatchSet: 3
      Gerrit-Owner: Tomasz Lichoń <lic...@google.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages