Enabled the PIP mute button feature flag by default This CL follows up on the work done in CL 7682308. This enables the feature flag for the mute/unmute button by default. [chromium/src : main]

0 views
Skip to first unread message

Tomas Gunnarsson (Gerrit)

unread,
Jun 26, 2026, 4:27:31 AM (7 days ago) Jun 26
to Tochukwu Ibe-Ekeocha, android-bu...@system.gserviceaccount.com, Dale Curtis, Mark Foltz, Sangbaek Park, Sangwhan Moon, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Dale Curtis, Mark Foltz, Sangbaek Park, Sangwhan Moon and Tochukwu Ibe-Ekeocha

Tomas Gunnarsson voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dale Curtis
  • Mark Foltz
  • Sangbaek Park
  • Sangwhan Moon
  • Tochukwu Ibe-Ekeocha
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaf70280e8a5af9db2859a27018f32c7b57b6882a
Gerrit-Change-Number: 8007691
Gerrit-PatchSet: 1
Gerrit-Owner: Tochukwu Ibe-Ekeocha <tibee...@microsoft.com>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Mark Foltz <mfo...@chromium.org>
Gerrit-Reviewer: Sangbaek Park <sangba...@chromium.org>
Gerrit-Reviewer: Sangwhan Moon <s...@google.com>
Gerrit-Reviewer: Tomas Gunnarsson <to...@chromium.org>
Gerrit-Attention: Mark Foltz <mfo...@chromium.org>
Gerrit-Attention: Sangbaek Park <sangba...@chromium.org>
Gerrit-Attention: Sangwhan Moon <s...@google.com>
Gerrit-Attention: Tochukwu Ibe-Ekeocha <tibee...@microsoft.com>
Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
Gerrit-Comment-Date: Fri, 26 Jun 2026 08:27:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Sangbaek Park (Gerrit)

unread,
Jun 26, 2026, 2:11:30 PM (6 days ago) Jun 26
to Tochukwu Ibe-Ekeocha, Tomas Gunnarsson, android-bu...@system.gserviceaccount.com, Dale Curtis, Mark Foltz, Sangwhan Moon, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Dale Curtis, Mark Foltz, Sangwhan Moon and Tochukwu Ibe-Ekeocha

Sangbaek Park voted and added 1 comment

Votes added by Sangbaek Park

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Sangbaek Park . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Dale Curtis
  • Mark Foltz
  • Sangwhan Moon
  • Tochukwu Ibe-Ekeocha
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iaf70280e8a5af9db2859a27018f32c7b57b6882a
    Gerrit-Change-Number: 8007691
    Gerrit-PatchSet: 1
    Gerrit-Owner: Tochukwu Ibe-Ekeocha <tibee...@microsoft.com>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Mark Foltz <mfo...@chromium.org>
    Gerrit-Reviewer: Sangbaek Park <sangba...@chromium.org>
    Gerrit-Reviewer: Sangwhan Moon <s...@google.com>
    Gerrit-Reviewer: Tomas Gunnarsson <to...@chromium.org>
    Gerrit-Attention: Mark Foltz <mfo...@chromium.org>
    Gerrit-Attention: Sangwhan Moon <s...@google.com>
    Gerrit-Attention: Tochukwu Ibe-Ekeocha <tibee...@microsoft.com>
    Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
    Gerrit-Comment-Date: Fri, 26 Jun 2026 18:11:11 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Benjamin Keen (Gerrit)

    unread,
    Jun 26, 2026, 3:12:27 PM (6 days ago) Jun 26
    to Tochukwu Ibe-Ekeocha, Sangbaek Park, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, feature-me...@chromium.org
    Attention needed from Tochukwu Ibe-Ekeocha

    Benjamin Keen voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Tochukwu Ibe-Ekeocha
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iaf70280e8a5af9db2859a27018f32c7b57b6882a
    Gerrit-Change-Number: 8007691
    Gerrit-PatchSet: 1
    Gerrit-Owner: Tochukwu Ibe-Ekeocha <tibee...@microsoft.com>
    Gerrit-Reviewer: Benjamin Keen <bk...@google.com>
    Gerrit-Reviewer: Sangbaek Park <sangba...@chromium.org>
    Gerrit-Attention: Tochukwu Ibe-Ekeocha <tibee...@microsoft.com>
    Gerrit-Comment-Date: Fri, 26 Jun 2026 19:12:17 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Tochukwu Ibe-Ekeocha (Gerrit)

    unread,
    Jun 26, 2026, 4:34:33 PM (6 days ago) Jun 26
    to Tomas Gunnarsson, Mark Foltz, Jordan Bayles, Olga Sharonova, Henrik Andreasson, Chromium LUCI CQ, Benjamin Keen, Sangbaek Park, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, feature-me...@chromium.org
    Attention needed from Henrik Andreasson, Jordan Bayles, Mark Foltz, Olga Sharonova and Tomas Gunnarsson

    Tochukwu Ibe-Ekeocha added 1 comment

    Patchset-level comments
    Tochukwu Ibe-Ekeocha . resolved

    Hey, I would appreciate a review from some owners

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Henrik Andreasson
    • Jordan Bayles
    • Mark Foltz
    • Olga Sharonova
    • Tomas Gunnarsson
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iaf70280e8a5af9db2859a27018f32c7b57b6882a
    Gerrit-Change-Number: 8007691
    Gerrit-PatchSet: 1
    Gerrit-Owner: Tochukwu Ibe-Ekeocha <tibee...@microsoft.com>
    Gerrit-Reviewer: Benjamin Keen <bk...@google.com>
    Gerrit-Reviewer: Henrik Andreasson <hen...@chromium.org>
    Gerrit-Reviewer: Jordan Bayles <jop...@chromium.org>
    Gerrit-Reviewer: Mark Foltz <mfo...@chromium.org>
    Gerrit-Reviewer: Olga Sharonova <ol...@chromium.org>
    Gerrit-Reviewer: Sangbaek Park <sangba...@chromium.org>
    Gerrit-Reviewer: Tochukwu Ibe-Ekeocha <tibee...@microsoft.com>
    Gerrit-Reviewer: Tomas Gunnarsson <to...@chromium.org>
    Gerrit-Attention: Olga Sharonova <ol...@chromium.org>
    Gerrit-Attention: Mark Foltz <mfo...@chromium.org>
    Gerrit-Attention: Tomas Gunnarsson <to...@chromium.org>
    Gerrit-Attention: Henrik Andreasson <hen...@chromium.org>
    Gerrit-Attention: Jordan Bayles <jop...@chromium.org>
    Gerrit-Comment-Date: Fri, 26 Jun 2026 20:34:20 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Benjamin Keen (Gerrit)

    unread,
    Jun 26, 2026, 7:37:49 PM (6 days ago) Jun 26
    to Tochukwu Ibe-Ekeocha, Tomas Gunnarsson, Chromium LUCI CQ, Sangbaek Park, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, feature-me...@chromium.org
    Attention needed from Sangbaek Park, Tochukwu Ibe-Ekeocha and Tomas Gunnarsson

    Benjamin Keen added 2 comments

    Patchset-level comments
    File-level comment, Patchset 2 (Latest):
    Benjamin Keen . resolved

    Thanks for the CL Tochukwu.

    Regarding owners, we usually try to avoid adding every listed owner for a file unless a multi-owner sign off is explicitly needed.

    I'll keep @to...@chromium.org for `m/b/media_switches.cc` since they have already looked at the CL.

    File chrome/browser/picture_in_picture/video_picture_in_picture_window_controller_browsertest.cc
    Line 2267, Patchset 2 (Latest):// Test fixture with kPictureInPictureMuteControl enabled.
    Benjamin Keen . unresolved

    nit: This should be "disabled".

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Sangbaek Park
    • Tochukwu Ibe-Ekeocha
    • Tomas Gunnarsson
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iaf70280e8a5af9db2859a27018f32c7b57b6882a
      Gerrit-Change-Number: 8007691
      Gerrit-PatchSet: 2
      Gerrit-Owner: Tochukwu Ibe-Ekeocha <tibee...@microsoft.com>
      Gerrit-Reviewer: Benjamin Keen <bk...@google.com>
      Gerrit-Reviewer: Sangbaek Park <sangba...@chromium.org>
      Gerrit-Reviewer: Tochukwu Ibe-Ekeocha <tibee...@microsoft.com>
      Gerrit-Reviewer: Tomas Gunnarsson <to...@chromium.org>
      Gerrit-Attention: Sangbaek Park <sangba...@chromium.org>
      Gerrit-Attention: Tomas Gunnarsson <to...@chromium.org>
      Gerrit-Attention: Tochukwu Ibe-Ekeocha <tibee...@microsoft.com>
      Gerrit-Comment-Date: Fri, 26 Jun 2026 23:37:37 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages