[iOS][PRDBD] Removes the password option from delete browsing data [chromium/src : main]
0 views
Skip to first unread message
Angela Novakovic (Gerrit)
Jan 14, 2026, 3:56:27 PM (5 days ago) Jan 14
to Filipa Senra, Noémie St-Onge, Chromium LUCI CQ, chromium...@chromium.org, dullweb...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, msrame...@chromium.org
Attention needed from Filipa Senra and Noémie St-Onge
Angela Novakovic added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 11:
Noémie St-Onge . resolved
Angela NovakovicLGTM! I see that unit tests for the mediator will be added in a subsequent CL (side note: we should mention it in the CL description). We probably should look at adding/adapting existing EG tests that will fail when we'll enable the flag
Done
Related details
Attention is currently required from:
- Filipa Senra
- Noémie St-Onge
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Filipa Senra (Gerrit)
Jan 15, 2026, 10:30:49 AM (4 days ago) Jan 15
to Angela Novakovic, Chromium Metrics Reviews, AyeAye, Noémie St-Onge, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, dullweb...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, msrame...@chromium.org
Attention needed from Angela Novakovic and Noémie St-Onge
Filipa Senra added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 15 (Latest):
Filipa Senra . unresolved
I think the new patch did something unintended.
Related details
Attention is currently required from:
- Angela Novakovic
- Noémie St-Onge
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Filipa Senra (Gerrit)
Jan 15, 2026, 10:35:52 AM (4 days ago) Jan 15
to Angela Novakovic, Chromium Metrics Reviews, AyeAye, Noémie St-Onge, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, dullweb...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, msrame...@chromium.org
Attention needed from Angela Novakovic and Noémie St-Onge
Filipa Senra voted and added 4 comments![]( "Open in Gerrit")
Votes added by Filipa Senra
| Code-Review | +1 |
4 comments
Patchset-level comments
Filipa Senra . resolved
lgtm % if you revert back to patchet 14
File ios/chrome/browser/settings/ui_bundled/clear_browsing_data/coordinator/quick_delete_mediator.mm
Line 127, Patchset 14:
NSString* _passwordsSummary;Filipa Senra . unresolved
nit: should you add a similar to do to the ones in VC for deleting this variable?
Line 694, Patchset 14:
if (_browsingHistorySummary && _tabsSummary &&
(IsPasswordRemovalFromDeleteBrowsingDataEnabled() || _passwordsSummary) &&
_addressesSummary && _paymentMethodsSummary && _suggestionsSummary) {Filipa Senra . unresolved
optional nit: this is getting a little to complicated to follow. perhaps you can extract the password part into a variable. up to you
Line 940, Patchset 14:
!IsPasswordRemovalFromDeleteBrowsingDataEnabled()) {Filipa Senra . unresolved
optional tiny nit: for consistency with the other if statements, perhaps move this to be the first thing on the if.
Related details
Attention is currently required from:
- Angela Novakovic
- Noémie St-Onge
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Angela Novakovic (Gerrit)
Jan 15, 2026, 12:15:16 PM (4 days ago) Jan 15
to Filipa Senra, Chromium Metrics Reviews, AyeAye, Noémie St-Onge, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, dullweb...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, msrame...@chromium.org
Attention needed from Filipa Senra and Noémie St-Onge
Angela Novakovic voted and added 4 comments![]( "Open in Gerrit")
Votes added by Angela Novakovic
| Commit-Queue | +1 |
I think the new patch did something unintended.
Angela Novakovic
Acknowledged
File ios/chrome/browser/settings/ui_bundled/clear_browsing_data/coordinator/quick_delete_mediator.mm
Line 127, Patchset 14:
NSString* _passwordsSummary;Filipa Senra . resolved
nit: should you add a similar to do to the ones in VC for deleting this variable?
Angela Novakovic
Done
Line 694, Patchset 14:
if (_browsingHistorySummary && _tabsSummary &&
(IsPasswordRemovalFromDeleteBrowsingDataEnabled() || _passwordsSummary) &&
_addressesSummary && _paymentMethodsSummary && _suggestionsSummary) {Filipa Senra . resolved
optional nit: this is getting a little to complicated to follow. perhaps you can extract the password part into a variable. up to you
Angela Novakovic
Done
Line 940, Patchset 14:
!IsPasswordRemovalFromDeleteBrowsingDataEnabled()) {Filipa Senra . resolved
optional tiny nit: for consistency with the other if statements, perhaps move this to be the first thing on the if.
Attention is currently required from:
- Filipa Senra
- Noémie St-Onge
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Noémie St-Onge (Gerrit)
Jan 15, 2026, 1:29:47 PM (4 days ago) Jan 15
to Angela Novakovic, Filipa Senra, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, dullweb...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, msrame...@chromium.org
Attention needed from Angela Novakovic and Filipa Senra
Noémie St-Onge voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Angela Novakovic
- Filipa Senra
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Filipa Senra (Gerrit)
8:54 AM (11 hours ago) 8:54 AM
to Angela Novakovic, Noémie St-Onge, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, dullweb...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, msrame...@chromium.org
Attention needed from Angela Novakovic
Filipa Senra voted and added 1 comment![]( "Open in Gerrit")
Votes added by Filipa Senra
| Code-Review | +1 |
1 comment
File ios/chrome/browser/settings/ui_bundled/clear_browsing_data/coordinator/quick_delete_mediator.mm
Line 696, Patchset 17 (Latest):
BOOL passwordsSummaryDone =Filipa Senra . unresolved
nit: perhaps `passwordsSummaryReady` is better. totally up to you
Related details
Attention is currently required from:
- Angela Novakovic
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Angela Novakovic (Gerrit)
9:57 AM (10 hours ago) 9:57 AM
to Filipa Senra, Noémie St-Onge, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, dullweb...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, msrame...@chromium.org
Attention needed from Angela Novakovic, Filipa Senra and Noémie St-Onge
Angela Novakovic voted and added 1 comment![]( "Open in Gerrit")
Votes added by Angela Novakovic
| Commit-Queue | +1 |
1 comment
File ios/chrome/browser/settings/ui_bundled/clear_browsing_data/coordinator/quick_delete_mediator.mm
nit: perhaps `passwordsSummaryReady` is better. totally up to you
Attention is currently required from:
- Angela Novakovic
- Filipa Senra
- Noémie St-Onge
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Noémie St-Onge (Gerrit)
2:00 PM (6 hours ago) 2:00 PM
to Angela Novakovic, Filipa Senra, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, dullweb...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, msrame...@chromium.org
Attention needed from Angela Novakovic and Filipa Senra
Noémie St-Onge voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Angela Novakovic
- Filipa Senra
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sourav Uttam Sinha (Gerrit)
2:06 PM (6 hours ago) 2:06 PM
to Angela Novakovic, Noémie St-Onge, Filipa Senra, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, dullweb...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, msrame...@chromium.org
Attention needed from Angela Novakovic and Filipa Senra
Sourav Uttam Sinha voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Angela Novakovic
- Filipa Senra
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Angela Novakovic (Gerrit)
2:08 PM (6 hours ago) 2:08 PM
to Sourav Uttam Sinha, Noémie St-Onge, Filipa Senra, Chromium Metrics Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, asvitkine...@chromium.org, dullweb...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, msrame...@chromium.org
Attention needed from Filipa Senra
Angela Novakovic voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Filipa Senra
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
2:54 PM (5 hours ago) 2:54 PM
to Angela Novakovic, Sourav Uttam Sinha, Noémie St-Onge, Filipa Senra, Chromium Metrics Reviews, AyeAye, chromium...@chromium.org, asvitkine...@chromium.org, dullweb...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, msrame...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS][PRDBD] Removes the password option from delete browsing data
This CL removes the password option from `Quick Delete Browsing Data`
and the logic behind the removal by disabling it when the feature flag
`kPasswordRemovalFromDeleteBrowsingData` is turned on.
Mediator Unit tests and EG tests are to be added in a following CL.
Design Doc: go/bling-delete-browsing-data
Feature on: https://screenshot.googleplex.com/8ChQTRzmPYyGhaJ.png
Feature off: https://screenshot.googleplex.com/A8xcXsFjr2wUZDk.png
Fixed: 464551392
Bug: 463402932
Change-Id: I80b162c54794512e989484dfba3e8d248fee9048
Reviewed-by: Sourav Uttam Sinha <sinha...@google.com>
Reviewed-by: Noémie St-Onge <noe...@google.com>
Commit-Queue: Angela Novakovic <novak...@google.com>
Cr-Commit-Position: refs/heads/main@{#1571315}
Files:
- M ios/chrome/browser/settings/ui_bundled/clear_browsing_data/coordinator/BUILD.gn
- M ios/chrome/browser/settings/ui_bundled/clear_browsing_data/coordinator/quick_delete_mediator.mm
- M ios/chrome/browser/settings/ui_bundled/clear_browsing_data/quick_delete_browsing_data/ui/BUILD.gn
- M ios/chrome/browser/settings/ui_bundled/clear_browsing_data/quick_delete_browsing_data/ui/quick_delete_browsing_data_view_controller.mm
- M ios/chrome/browser/settings/ui_bundled/clear_browsing_data/ui/quick_delete_consumer.h
- M ios/chrome/browser/settings/ui_bundled/clear_browsing_data/ui/quick_delete_view_controller.mm
Change size: M
Delta: 6 files changed, 64 insertions(+), 14 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Noémie St-Onge, +1 by Sourav Uttam Sinha
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages