Media Capabilities: add encryptionScheme to decodingInfo [chromium/src : main]
Sangbaek Park (Gerrit)
Sangbaek Park voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
- Dale Curtis
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Dale Curtis added 1 comment![]( "Open in Gerrit")
DOMString? encryptionScheme;Needs RuntimeEnabledFeatures set to disabled and a later change to enable after intent to ship
Related details
- Sangbaek Park
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xiaohan Wang (Gerrit)
Xiaohan Wang added 2 comments![]( "Open in Gerrit")
Thanks for fixing this! One drive-by nit.
// https://w3c.github.io/media-capabilities/#dictdef-keysystemtrackconfigurationIt's recommendation now, use this link?
https://www.w3.org/TR/media-capabilities/#keysystemtrackconfiguration
Sangbaek Park (Gerrit)
Sangbaek Park added 3 comments![]( "Open in Gerrit")
// https://w3c.github.io/media-capabilities/#dictdef-keysystemtrackconfigurationIt's recommendation now, use this link?
https://www.w3.org/TR/media-capabilities/#keysystemtrackconfiguration
Done
Needs RuntimeEnabledFeatures set to disabled and a later change to enable after intent to ship
Done
LAYOUTTESTS APIS: import-maps/data-driven/resources/test-helper-iframe.jsAdded this exception due to the following error:
```
`wpt lint` failed:
***************
ERROR:lint:media-capabilities\decodingInfoEncryptedMedia.https.html:275: eventSender/testRunner/internals used; these are LayoutTests-specific APIs (WebKit/Blink) (LAYOUTTESTS APIS)
ERROR:lint:media-capabilities\decodingInfoEncryptedMedia.https.html:301: eventSender/testRunner/internals used; these are LayoutTests-specific APIs (WebKit/Blink) (LAYOUTTESTS APIS)
INFO:lint:
INFO:lint:There were 2 errors (LAYOUTTESTS APIS: 2)
INFO:lint:You must fix all errors; for details on how to fix them, see
INFO:lint:https://web-platform-tests.org/writing-tests/lint-tool.html
INFO:lint:
INFO:lint:However, instead of fixing a particular error, it's sometimes
INFO:lint:OK to add a line to the lint.ignore file in the root of the
INFO:lint:web-platform-tests directory to make the lint tool ignore it.
INFO:lint:
INFO:lint:For example, to make the lint tool ignore all 'LAYOUTTESTS APIS'
INFO:lint:errors in the media-capabilities\decodingInfoEncryptedMedia.https.html file,
INFO:lint:you could add the following line to the lint.ignore file.
INFO:lint:
INFO:lint:LAYOUTTESTS APIS: media-capabilities\decodingInfoEncryptedMedia.https.html
***************
```
Not sure there is a better approach?
Related details
- Dale Curtis
- Xiaohan Wang
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Dale Curtis added 1 comment![]( "Open in Gerrit")
if (window.internals.runtimeFlags.KeySystemTrackConfigurationEncryptionScheme) {Tests already run with experimental APIs, so this shouldn't be needed.
Related details
- Sangbaek Park
- Xiaohan Wang
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sangbaek Park (Gerrit)
Sangbaek Park added 2 comments![]( "Open in Gerrit")
LAYOUTTESTS APIS: import-maps/data-driven/resources/test-helper-iframe.jsAdded this exception due to the following error:
```
`wpt lint` failed:***************
ERROR:lint:media-capabilities\decodingInfoEncryptedMedia.https.html:275: eventSender/testRunner/internals used; these are LayoutTests-specific APIs (WebKit/Blink) (LAYOUTTESTS APIS)
ERROR:lint:media-capabilities\decodingInfoEncryptedMedia.https.html:301: eventSender/testRunner/internals used; these are LayoutTests-specific APIs (WebKit/Blink) (LAYOUTTESTS APIS)
INFO:lint:
INFO:lint:There were 2 errors (LAYOUTTESTS APIS: 2)
INFO:lint:You must fix all errors; for details on how to fix them, see
INFO:lint:https://web-platform-tests.org/writing-tests/lint-tool.html
INFO:lint:
INFO:lint:However, instead of fixing a particular error, it's sometimes
INFO:lint:OK to add a line to the lint.ignore file in the root of the
INFO:lint:web-platform-tests directory to make the lint tool ignore it.
INFO:lint:
INFO:lint:For example, to make the lint tool ignore all 'LAYOUTTESTS APIS'
INFO:lint:errors in the media-capabilities\decodingInfoEncryptedMedia.https.html file,
INFO:lint:you could add the following line to the lint.ignore file.
INFO:lint:
INFO:lint:LAYOUTTESTS APIS: media-capabilities\decodingInfoEncryptedMedia.https.html
***************
```
Not sure there is a better approach?
Removed this since tests already run with experimental APIs.
if (window.internals.runtimeFlags.KeySystemTrackConfigurationEncryptionScheme) {Tests already run with experimental APIs, so this shouldn't be needed.
- Dale Curtis
- Xiaohan Wang
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Dale Curtis voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dale Curtis
| Code-Review | +1 |
1 comment
if (!RuntimeEnabledFeatures::There's a `ScopedRuntimeEnabledFeature` thing you can use to ensure test can always run
Related details
- Sangbaek Park
- Xiaohan Wang
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sangbaek Park (Gerrit)
Sangbaek Park added 2 comments![]( "Open in Gerrit")
There's a `ScopedRuntimeEnabledFeature` thing you can use to ensure test can always run
Thanks! I used `ScopedKeySystemTrackConfigurationEncryptionSchemeForTest`.
Related details
- Mike Taylor
- Xiaohan Wang
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mike Taylor (Gerrit)
Mike Taylor added 1 comment![]( "Open in Gerrit")
third_party/blink/renderer/platform/runtime_enabled_features.json5 lgtm
Related details
- Sangbaek Park
- Xiaohan Wang
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mike Taylor (Gerrit)
Mike Taylor voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mike Taylor
| Code-Review | +1 |
1 comment
(actually lgtm now)
Related details
- Sangbaek Park
- Xiaohan Wang
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sangbaek Park (Gerrit)
Sangbaek Park voted Commit-Queue+2![]( "Open in Gerrit")
- Xiaohan Wang
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/58961.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
- Xiaohan Wang
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sangbaek Park (Gerrit)
Sangbaek Park voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |