Video: Disable VP conversion when colorspace is not supported [chromium/src : main]

0 views
Skip to first unread message

Sida Zhu (Gerrit)

unread,
Jul 3, 2024, 12:28:40 PM (2 days ago) Jul 3
to ccameron chromium, Dale Curtis, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blundell+...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, penghu...@chromium.org
Attention needed from Dale Curtis and ccameron chromium

Sida Zhu added 1 comment

Patchset-level comments
File-level comment, Patchset 8 (Latest):
Sida Zhu . resolved

PTAL, thanks

Open in Gerrit

Related details

Attention is currently required from:
  • Dale Curtis
  • ccameron chromium
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I218913a0d2b12e307b180d4f005898a7851358c3
Gerrit-Change-Number: 5669121
Gerrit-PatchSet: 8
Gerrit-Owner: Sida Zhu <zhu...@bytedance.com>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Sida Zhu <zhu...@bytedance.com>
Gerrit-Reviewer: ccameron chromium <ccam...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
Gerrit-Attention: ccameron chromium <ccam...@chromium.org>
Gerrit-Comment-Date: Wed, 03 Jul 2024 16:28:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Dale Curtis (Gerrit)

unread,
Jul 3, 2024, 12:36:36 PM (2 days ago) Jul 3
to ccameron chromium, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blundell+...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, penghu...@chromium.org
Attention needed from Sida Zhu and ccameron chromium

Dale Curtis voted and added 1 comment

Votes added by Dale Curtis

Code-Review+1

1 comment

Patchset-level comments
Dale Curtis . unresolved

Thanks! I thought maybe we could fix GetDXGIColorSpace(), but then I remembered we have RGB DXGI values, but they still don't work with VP. Can you add some unit tests to `media/gpu/windows/d3d11_texture_selector_unittest.cc` ?

Open in Gerrit

Related details

Attention is currently required from:
  • Sida Zhu
  • ccameron chromium
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I218913a0d2b12e307b180d4f005898a7851358c3
Gerrit-Change-Number: 5669121
Gerrit-PatchSet: 8
Gerrit-Owner: Sida Zhu <zhu...@bytedance.com>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Sida Zhu <zhu...@bytedance.com>
Gerrit-Reviewer: ccameron chromium <ccam...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: ccameron chromium <ccam...@chromium.org>
Gerrit-Attention: Sida Zhu <zhu...@bytedance.com>
Gerrit-Comment-Date: Wed, 03 Jul 2024 16:36:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Sida Zhu (Gerrit)

unread,
Jul 3, 2024, 11:43:26 PM (2 days ago) Jul 3
to Dale Curtis, ccameron chromium, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blundell+...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, penghu...@chromium.org
Attention needed from Dale Curtis and ccameron chromium

Sida Zhu added 1 comment

Patchset-level comments
File-level comment, Patchset 8:
Dale Curtis . resolved

Thanks! I thought maybe we could fix GetDXGIColorSpace(), but then I remembered we have RGB DXGI values, but they still don't work with VP. Can you add some unit tests to `media/gpu/windows/d3d11_texture_selector_unittest.cc` ?

Sida Zhu

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Dale Curtis
  • ccameron chromium
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I218913a0d2b12e307b180d4f005898a7851358c3
Gerrit-Change-Number: 5669121
Gerrit-PatchSet: 9
Gerrit-Owner: Sida Zhu <zhu...@bytedance.com>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Sida Zhu <zhu...@bytedance.com>
Gerrit-Reviewer: ccameron chromium <ccam...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
Gerrit-Attention: ccameron chromium <ccam...@chromium.org>
Gerrit-Comment-Date: Thu, 04 Jul 2024 03:43:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Dale Curtis <dalec...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Sida Zhu (Gerrit)

unread,
1:30 AM (3 hours ago) 1:30 AM
to Dale Curtis, ccameron chromium, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blundell+...@chromium.org, cc-...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org, penghu...@chromium.org
Attention needed from Dale Curtis and ccameron chromium

Sida Zhu added 1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Dale Curtis
  • ccameron chromium
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I218913a0d2b12e307b180d4f005898a7851358c3
Gerrit-Change-Number: 5669121
Gerrit-PatchSet: 12
Gerrit-Owner: Sida Zhu <zhu...@bytedance.com>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Sida Zhu <zhu...@bytedance.com>
Gerrit-Reviewer: ccameron chromium <ccam...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
Gerrit-Attention: ccameron chromium <ccam...@chromium.org>
Gerrit-Comment-Date: Fri, 05 Jul 2024 05:30:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages