media: Fix DecryptConfig kUnencrypted validation bypass and JNI bounds [chromium/src : main]

0 views
Skip to first unread message

Vikram Pasupathy (Gerrit)

unread,
1:05 PM (6 hours ago) 1:05 PM
to Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org
Attention needed from Dale Curtis

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Dale Curtis
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I347b837ade617291e4a1bd7aec4268cfab6e765d
Gerrit-Change-Number: 7723068
Gerrit-PatchSet: 5
Gerrit-Owner: Vikram Pasupathy <vpasu...@chromium.org>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Vikram Pasupathy <vpasu...@chromium.org>
Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
Gerrit-Comment-Date: Thu, 02 Apr 2026 17:05:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Dale Curtis (Gerrit)

unread,
2:27 PM (5 hours ago) 2:27 PM
to Vikram Pasupathy, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org
Attention needed from Vikram Pasupathy

Dale Curtis voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Vikram Pasupathy
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I347b837ade617291e4a1bd7aec4268cfab6e765d
    Gerrit-Change-Number: 7723068
    Gerrit-PatchSet: 5
    Gerrit-Owner: Vikram Pasupathy <vpasu...@chromium.org>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Vikram Pasupathy <vpasu...@chromium.org>
    Gerrit-Attention: Vikram Pasupathy <vpasu...@chromium.org>
    Gerrit-Comment-Date: Thu, 02 Apr 2026 18:27:30 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    gwsq (Gerrit)

    unread,
    2:43 PM (5 hours ago) 2:43 PM
    to Vikram Pasupathy, Chromium IPC Reviews, Daniel Cheng, Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org
    Attention needed from Daniel Cheng

    Message from gwsq

    From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
    IPC: dch...@chromium.org

    📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

    IPC reviewer(s): dch...@chromium.org


    Reviewer source(s):
    dch...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Cheng
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I347b837ade617291e4a1bd7aec4268cfab6e765d
    Gerrit-Change-Number: 7723068
    Gerrit-PatchSet: 5
    Gerrit-Owner: Vikram Pasupathy <vpasu...@chromium.org>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Vikram Pasupathy <vpasu...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Thu, 02 Apr 2026 18:42:55 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    4:27 PM (3 hours ago) 4:27 PM
    to Vikram Pasupathy, Chromium IPC Reviews, Daniel Cheng, Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org
    Attention needed from Vikram Pasupathy

    Daniel Cheng added 1 comment

    Patchset-level comments
    File-level comment, Patchset 5 (Latest):
    Daniel Cheng . unresolved

    Is this something we can consider typemapping (even if not now, in the future)? It's a bit hard/clunky to percolate errors up through type converters.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Vikram Pasupathy
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I347b837ade617291e4a1bd7aec4268cfab6e765d
      Gerrit-Change-Number: 7723068
      Gerrit-PatchSet: 5
      Gerrit-Owner: Vikram Pasupathy <vpasu...@chromium.org>
      Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: Vikram Pasupathy <vpasu...@chromium.org>
      Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
      Gerrit-CC: gwsq
      Gerrit-Attention: Vikram Pasupathy <vpasu...@chromium.org>
      Gerrit-Comment-Date: Thu, 02 Apr 2026 20:26:53 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Vikram Pasupathy (Gerrit)

      unread,
      4:34 PM (3 hours ago) 4:34 PM
      to Chromium IPC Reviews, Daniel Cheng, Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ipc-securi...@chromium.org
      Attention needed from Daniel Cheng

      Vikram Pasupathy added 1 comment

      Patchset-level comments
      Daniel Cheng . unresolved

      Is this something we can consider typemapping (even if not now, in the future)? It's a bit hard/clunky to percolate errors up through type converters.

      Vikram Pasupathy

      I'll re-open crbug/40468949 and create CLs for those: It seems like there are three more ones that we want to do:

          DecryptConfig
      DecoderBuffer
      AudioBuffer
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Daniel Cheng
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I347b837ade617291e4a1bd7aec4268cfab6e765d
      Gerrit-Change-Number: 7723068
      Gerrit-PatchSet: 5
      Gerrit-Owner: Vikram Pasupathy <vpasu...@chromium.org>
      Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: Vikram Pasupathy <vpasu...@chromium.org>
      Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
      Gerrit-CC: gwsq
      Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
      Gerrit-Comment-Date: Thu, 02 Apr 2026 20:33:59 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Daniel Cheng <dch...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages