media: Use VideoFrameConverter in NdkVideoEncodeAccelerator [chromium/src : main]
0 views
Skip to first unread message
Dale Curtis (Gerrit)
Jan 20, 2026, 1:57:34 PM (12 hours ago) Jan 20
to Eugene Zemtsov, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org
Attention needed from Eugene Zemtsov
Dale Curtis voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dale Curtis
| Code-Review | +1 |
1 comment
File media/gpu/android/ndk_video_encode_accelerator.cc
Line 1040, Patchset 1 (Latest):
// Y-Plane: stride, offset, sizeDale Curtis . unresolved
Use .name syntax instead of comment?
Related details
Attention is currently required from:
- Eugene Zemtsov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eugene Zemtsov (Gerrit)
Jan 20, 2026, 4:41:39 PM (9 hours ago) Jan 20
to Eugene Zemtsov, Dale Curtis, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org
Eugene Zemtsov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Eugene Zemtsov
| Commit-Queue | +2 |
1 comment
File media/gpu/android/ndk_video_encode_accelerator.cc
Use .name syntax instead of comment?
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 20, 2026, 6:39:13 PM (8 hours ago) Jan 20
to Eugene Zemtsov, Dale Curtis, AyeAye, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: media/gpu/android/ndk_video_encode_accelerator.cc
Insertions: 4, Deletions: 4.
@@ -1037,10 +1037,10 @@
const size_t y_plane_size =
input_buffer_stride_ * input_buffer_yplane_height_;
const std::vector<ColorPlaneLayout> dst_planes = {
- // Y-Plane: stride, offset, size
- {static_cast<size_t>(input_buffer_stride_), 0, y_plane_size},
- // UV-Plane: stride, offset, size
- {static_cast<size_t>(input_buffer_stride_), y_plane_size, uv_plane_len},
+ ColorPlaneLayout(/*stride=*/static_cast<size_t>(input_buffer_stride_),
+ /*offset=*/0, /*size=*/y_plane_size),
+ ColorPlaneLayout(/*stride=*/static_cast<size_t>(input_buffer_stride_),
+ /*offset=*/y_plane_size, /*size=*/uv_plane_len),
};
auto dst_layout = VideoFrameLayout::CreateWithPlanes(
```
Change information
Commit message:
media: Use VideoFrameConverter in NdkVideoEncodeAccelerator
Refactors FeedInputBuffer to use VideoFrameConverter for scaling and format
conversion instead of direct libyuv calls.
This simplifies the input handling logic.
Change-Id: Ie0d11636b3bff8cac9780386b0554ec0432a70a5
Reviewed-by: Dale Curtis <dalec...@chromium.org>
Commit-Queue: Eugene Zemtsov <eug...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1571931}
Files:
- M media/gpu/android/ndk_video_encode_accelerator.cc
- M media/gpu/android/ndk_video_encode_accelerator.h
Change size: M
Delta: 2 files changed, 34 insertions(+), 33 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dale Curtis
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Jan 20, 2026, 6:40:48 PM (7 hours ago) Jan 20
to Chromium LUCI CQ, Eugene Zemtsov, AyeAye, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org
Attention needed from Eugene Zemtsov
Dale Curtis added 1 comment![]( "Open in Gerrit")
File media/gpu/android/ndk_video_encode_accelerator.cc
Line 1040, Patchset 3 (Latest):
ColorPlaneLayout(/*stride=*/static_cast<size_t>(input_buffer_stride_),Dale Curtis . unresolved
I meant `{.stride=$$$, .offset=$$$, .size=$$$}` but this is fine too
Related details
Attention is currently required from:
- Eugene Zemtsov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eugene Zemtsov (Gerrit)
Jan 20, 2026, 6:54:17 PM (7 hours ago) Jan 20
to Chromium LUCI CQ, Eugene Zemtsov, Dale Curtis, AyeAye, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org
Eugene Zemtsov added 1 comment![]( "Open in Gerrit")
File media/gpu/android/ndk_video_encode_accelerator.cc
Line 1040, Patchset 3 (Latest):
ColorPlaneLayout(/*stride=*/static_cast<size_t>(input_buffer_stride_),Dale Curtis . resolved
I meant `{.stride=$$$, .offset=$$$, .size=$$$}` but this is fine too
Eugene Zemtsov
it doesn't work when since `ColorPlaneLayout` has a constructor
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Jan 20, 2026, 6:55:26 PM (7 hours ago) Jan 20
to Chromium LUCI CQ, Eugene Zemtsov, AyeAye, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org
Dale Curtis added 1 comment![]( "Open in Gerrit")
File media/gpu/android/ndk_video_encode_accelerator.cc
Line 1040, Patchset 3 (Latest):
ColorPlaneLayout(/*stride=*/static_cast<size_t>(input_buffer_stride_),Dale Curtis . resolved
Eugene ZemtsovI meant `{.stride=$$$, .offset=$$$, .size=$$$}` but this is fine too
it doesn't work when since `ColorPlaneLayout` has a constructor
Dale Curtis
ðŸ˜
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages