media: Fix non-standard url parameter in provisioning [chromium/src : main]
0 views
Skip to first unread message
Vikram Pasupathy (Gerrit)
Oct 29, 2025, 2:33:27 PMOct 29
to AyeAye, Chromium LUCI CQ, feature-me...@chromium.org
Attention needed from Xiaohan Wang
Vikram Pasupathy voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vikram Pasupathy
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Vikram Pasupathy . resolved
ptal. I verified that it worked beforehand with the & due to lenient parsing, but this is the correct structuring.
I will cherry-pick this after.
Related details
Attention is currently required from:
- Xiaohan Wang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xiaohan Wang (Gerrit)
Oct 29, 2025, 3:28:05 PMOct 29
to Vikram Pasupathy, AyeAye, Chromium LUCI CQ, feature-me...@chromium.org
Attention needed from Vikram Pasupathy
Xiaohan Wang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Xiaohan Wang
| Code-Review | +1 |
1 comment
Patchset-level comments
Xiaohan Wang . resolved
lgtm, but please check my question in the bug. thanks!
Related details
Attention is currently required from:
- Vikram Pasupathy
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vikram Pasupathy (Gerrit)
Oct 29, 2025, 3:33:48 PMOct 29
to AyeAye, Chromium LUCI CQ, feature-me...@chromium.org
Vikram Pasupathy voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vikram Pasupathy (Gerrit)
Oct 29, 2025, 3:34:07 PMOct 29
to AyeAye, Chromium LUCI CQ, feature-me...@chromium.org
Vikram Pasupathy added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Xiaohan Wang . resolved
lgtm, but please check my question in the bug. thanks!
Vikram Pasupathy
Done.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vikram Pasupathy (Gerrit)
Oct 29, 2025, 5:19:47 PMOct 29
to AyeAye, Chromium LUCI CQ, feature-me...@chromium.org
Vikram Pasupathy voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 29, 2025, 5:46:23 PMOct 29
to Vikram Pasupathy, AyeAye, feature-me...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
media: Fix non-standard url parameter in provisioning
The url parameter was added via an ampersand, when the start of
parameters should actually include a question mark. This worked because
of lenient parsing, but should be fixed to match the standard, as the
question mark is recognized as the start of the query string by all
servers.
Tested manually with flag enabled to verify it worked.
Media.EME.MediaDrm.Provisioning returns success each time.
Media.EME.UrlProvisionFetcher.ResponseCode returns 200 each time.
Bug: 456186326
Change-Id: I21cc325a03d30328cc6b00bb03508e4c18977877
Reviewed-by: Xiaohan Wang <xhw...@chromium.org>
Commit-Queue: Vikram Pasupathy <vpasu...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1537542}
Files:
- M content/browser/media/url_provision_fetcher.cc
- M content/browser/media/url_provision_fetcher_unittest.cc
Change size: XS
Delta: 2 files changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Xiaohan Wang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vikram Pasupathy (Gerrit)
Nov 12, 2025, 7:29:41 PM (10 hours ago) Nov 12
to Chromium LUCI CQ, Vikram Pasupathy, AyeAye, feature-me...@chromium.org
Vikram Pasupathy has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages