WTF: Add String::contains(StringView) [chromium/src : main]
Kent Tamura (Gerrit)
Kent Tamura voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kent Tamura
| Auto-Submit | +1 |
1 comment
Related details
- Fredrik Söderquist
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
AI Code Reviewer (Gerrit)
AI Code Reviewer added 1 comment![]( "Open in Gerrit")
bool contains(const StringView& value) const { return find(value) != npos; }nit: Blink Style Guide: Naming - Use 'CamelCase' for all function names. This method should be named 'Contains'. Note that a 'Contains' method accepting 'StringView' already exists (via the overload with a default argument), so this addition appears redundant.
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason
_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
Related details
- Fredrik Söderquist
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fredrik Söderquist (Gerrit)
Fredrik Söderquist voted and added 1 comment![]( "Open in Gerrit")
Votes added by Fredrik Söderquist
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
bool contains(const StringView& value) const { return find(value) != npos; }nit: Blink Style Guide: Naming - Use 'CamelCase' for all function names. This method should be named 'Contains'. Note that a 'Contains' method accepting 'StringView' already exists (via the overload with a default argument), so this addition appears redundant.
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason
_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
OK But Won't Fix: It's intentional. For std::string compatibility.
Related details
- Kent Tamura
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
WTF: Add String::contains(StringView)
This change introduces a new method `String::contains(StringView)` which
is compatible with the C++23 `std::string::contains`.
This new method is then used to replace numerous calls to
`String::Find(...) != kNotFound` and `String::Find(...) == kNotFound`,
improving code readability across many files.
- M third_party/blink/renderer/core/exported/web_frame_serializer_sanitization_test.cc
- M third_party/blink/renderer/core/html/forms/html_input_element.cc
- M third_party/blink/renderer/core/html/track/vtt/vtt_region.cc
- M third_party/blink/renderer/core/inspector/dom_patch_support.cc
- M third_party/blink/renderer/core/inspector/inspector_style_sheet.cc
- M third_party/blink/renderer/modules/mediarecorder/media_recorder_handler.cc
- M third_party/blink/renderer/modules/mediarecorder/media_recorder_handler_unittest.cc
- M third_party/blink/renderer/modules/peerconnection/rtc_peer_connection.cc
- M third_party/blink/renderer/platform/wtf/text/wtf_string.h
Code-Review: +1 by Fredrik Söderquist
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
Kent Tamura added 1 comment![]( "Open in Gerrit")
bool contains(const StringView& value) const { return find(value) != npos; }Fredrik Söderquistnit: Blink Style Guide: Naming - Use 'CamelCase' for all function names. This method should be named 'Contains'. Note that a 'Contains' method accepting 'StringView' already exists (via the overload with a default argument), so this addition appears redundant.
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason
_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
OK But Won't Fix: It's intentional. For std::string compatibility.
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |