[XR]: Update XR Scenecore APIs [chromium/src : main]

0 views
Skip to first unread message

Oleh Desiatyrikov (xWF) (Gerrit)

unread,
May 12, 2026, 9:02:29 PM (6 days ago) May 12
to Gurmeet Kalra, Nick Mondello, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org
Attention needed from Gurmeet Kalra and Nick Mondello

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Gurmeet Kalra
  • Nick Mondello
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0e968abd23b977be61c19af0f0b30e03659e6d95
Gerrit-Change-Number: 7838180
Gerrit-PatchSet: 5
Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
Gerrit-Reviewer: Nick Mondello <mond...@google.com>
Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
Gerrit-Attention: Gurmeet Kalra <gurm...@google.com>
Gerrit-Attention: Nick Mondello <mond...@google.com>
Gerrit-Comment-Date: Wed, 13 May 2026 01:02:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Nick Mondello (Gerrit)

unread,
May 14, 2026, 2:23:54 PM (4 days ago) May 14
to Oleh Desiatyrikov (xWF), Gurmeet Kalra, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org
Attention needed from Gurmeet Kalra and Oleh Desiatyrikov (xWF)

Nick Mondello added 2 comments

File chrome/android/modules/xr/internal/java/src/org/chromium/chrome/browser/xr/scenecore/XrEntityHolderImpl.java
Line 128, Patchset 10 (Latest): public void addChild(XrEntityHolder<?> child) {
Nick Mondello . unresolved

Do you ever set the parent of this child? Maybe want to link `setParent` in this function to make sure no one misses that.

File chrome/android/modules/xr/internal/java/src/org/chromium/chrome/browser/xr/scenecore/XrInteractableComponentImpl.java
Line 71, Patchset 10 (Latest): mHandler.removeCallbacks(mClickTimeoutRunnable);
Nick Mondello . unresolved

nit: Consider extracting this to a helper method since it's used here, in the CANCEL branch, and at the end of the UP branch.

Open in Gerrit

Related details

Attention is currently required from:
  • Gurmeet Kalra
  • Oleh Desiatyrikov (xWF)
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0e968abd23b977be61c19af0f0b30e03659e6d95
    Gerrit-Change-Number: 7838180
    Gerrit-PatchSet: 10
    Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
    Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
    Gerrit-Reviewer: Nick Mondello <mond...@google.com>
    Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
    Gerrit-Attention: Gurmeet Kalra <gurm...@google.com>
    Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>
    Gerrit-Comment-Date: Thu, 14 May 2026 18:23:45 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Gurmeet Kalra (Gerrit)

    unread,
    3:25 AM (6 hours ago) 3:25 AM
    to Oleh Desiatyrikov (xWF), Nick Mondello, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org
    Attention needed from Oleh Desiatyrikov (xWF)

    Gurmeet Kalra added 1 comment

    File chrome/android/modules/xr/internal/java/src/org/chromium/chrome/browser/xr/scenecore/XrMovableComponentImpl.java
    Line 43, Patchset 10 (Latest): updateMovableComponent(movable, scaleInZ);
    Gurmeet Kalra . unresolved

    If `setMovable(true, ...)` is called after a custom handler has been configured via `setCustomMovable()`, it will currently reuse `mCustomMoveHandler` rather than creating a system movable.

    If the intention of `setMovable` is to strictly use the standard system movable, consider clearing `mCustomMoveHandler = null` here. If this behavior is intentional and expected, consider adding a brief comment to clarify it.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Oleh Desiatyrikov (xWF)
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0e968abd23b977be61c19af0f0b30e03659e6d95
    Gerrit-Change-Number: 7838180
    Gerrit-PatchSet: 10
    Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
    Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
    Gerrit-Reviewer: Nick Mondello <mond...@google.com>
    Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
    Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>
    Gerrit-Comment-Date: Mon, 18 May 2026 07:25:38 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages