Remove AttributionReportingCrossAppWeb features [chromium/src : main]

0 views

Skip to first unread message

Andrew Paseltiner (Gerrit)

unread,

Nov 5, 2024, 10:12:31 AM11/5/24

to Nan Lin, Tricium, Chromium Metrics Reviews, chromium...@chromium.org, Luna Lu, apaselti...@chromium.org, asvitkine...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, network-ser...@chromium.org

Attention needed from Nan Lin

Andrew Paseltiner voted and added 1 comment

Votes added by Andrew Paseltiner

Commit-Queue

1 comment

File content/browser/attribution_reporting/cross_app_web_attribution_browsertest.cc

Line 94, Patchset 2 (Latest):

        TestCase{
            .conversion_measurement_enabled = true,
            .expected = true,
        },

Andrew Paseltiner . unresolved

@lin...@chromium.org This test case is failing with this CL: The feature policy apparently doesn't include `attribution-reporting` (line 109). Any ideas what's going on here?

Separately, it probably makes sense to rename this file and the associated test fixtures and/or move this to WPT.

Open in Gerrit

Related details

Attention is currently required from:

Nan Lin

Submit Requirements:

Code-Coverage
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Andrew Paseltiner (Gerrit)

unread,

Nov 5, 2024, 10:23:17 AM11/5/24

to Chromium LUCI CQ, Nan Lin, Tricium, Chromium Metrics Reviews, chromium...@chromium.org, Luna Lu, apaselti...@chromium.org, asvitkine...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, network-ser...@chromium.org