ds: Add direct-sockets-private permissions policy [chromium/src : main]

3 views
Skip to first unread message

Andrew Rayskiy (Gerrit)

unread,
Sep 18, 2024, 10:43:48 AM9/18/24
to Reilly Grant, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, Simon Hangl, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, rmcelra...@chromium.org
Attention needed from Reilly Grant

Andrew Rayskiy voted and added 1 comment

Votes added by Andrew Rayskiy

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Andrew Rayskiy . resolved

Hey Reilly, PTAL.

Open in Gerrit

Related details

Attention is currently required from:
  • Reilly Grant
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4e30fa33018548e99b0c51b7e1d7efe33e57baaf
Gerrit-Change-Number: 5872524
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Rayskiy <green...@google.com>
Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Luna Lu <loon...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Reilly Grant <rei...@chromium.org>
Gerrit-Comment-Date: Wed, 18 Sep 2024 14:43:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Reilly Grant (Gerrit)

unread,
Sep 18, 2024, 8:16:19 PM9/18/24
to Andrew Rayskiy, Reilly Grant, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, Simon Hangl, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, rmcelra...@chromium.org
Attention needed from Andrew Rayskiy

Reilly Grant added 1 comment

File chrome/browser/direct_sockets/chrome_direct_sockets_delegate.cc
Line 88, Patchset 5 (Latest): std::move(callback).Run(/*access_allowed=*/rfh.IsFeatureEnabled(
blink::mojom::PermissionsPolicyFeature::kDirectSocketsPrivate));
Reilly Grant . unresolved

This should be checked in the `//content` layer.

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Rayskiy
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4e30fa33018548e99b0c51b7e1d7efe33e57baaf
    Gerrit-Change-Number: 5872524
    Gerrit-PatchSet: 5
    Gerrit-Owner: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Luna Lu <loon...@chromium.org>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-Attention: Andrew Rayskiy <green...@google.com>
    Gerrit-Comment-Date: Thu, 19 Sep 2024 00:16:09 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Andrew Rayskiy (Gerrit)

    unread,
    Sep 19, 2024, 7:28:59 AM9/19/24
    to Reilly Grant, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, Simon Hangl, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, rmcelra...@chromium.org
    Attention needed from Reilly Grant

    Andrew Rayskiy added 1 comment

    File chrome/browser/direct_sockets/chrome_direct_sockets_delegate.cc
    Line 88, Patchset 5: std::move(callback).Run(/*access_allowed=*/rfh.IsFeatureEnabled(
    blink::mojom::PermissionsPolicyFeature::kDirectSocketsPrivate));
    Reilly Grant . resolved

    This should be checked in the `//content` layer.

    Andrew Rayskiy

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Reilly Grant
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4e30fa33018548e99b0c51b7e1d7efe33e57baaf
    Gerrit-Change-Number: 5872524
    Gerrit-PatchSet: 6
    Gerrit-Owner: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Luna Lu <loon...@chromium.org>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-Attention: Reilly Grant <rei...@chromium.org>
    Gerrit-Comment-Date: Thu, 19 Sep 2024 11:28:48 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Reilly Grant <rei...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Andrew Rayskiy (Gerrit)

    unread,
    Sep 19, 2024, 9:27:48 AM9/19/24
    to Daniel Cheng, Reilly Grant, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, Simon Hangl, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, rmcelra...@chromium.org
    Attention needed from Daniel Cheng and Reilly Grant

    Andrew Rayskiy added 1 comment

    Patchset-level comments
    File-level comment, Patchset 7 (Latest):
    Andrew Rayskiy . resolved

    + Daniel for blink files -- PTAL!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Cheng
    • Reilly Grant
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4e30fa33018548e99b0c51b7e1d7efe33e57baaf
    Gerrit-Change-Number: 5872524
    Gerrit-PatchSet: 7
    Gerrit-Owner: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Luna Lu <loon...@chromium.org>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Attention: Reilly Grant <rei...@chromium.org>
    Gerrit-Comment-Date: Thu, 19 Sep 2024 13:27:36 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    Sep 19, 2024, 3:36:19 PM9/19/24
    to Andrew Rayskiy, Daniel Cheng, Reilly Grant, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, Simon Hangl, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, rmcelra...@chromium.org
    Attention needed from Andrew Rayskiy and Reilly Grant

    Daniel Cheng voted and added 1 comment

    Votes added by Daniel Cheng

    Code-Review+1

    1 comment

    Patchset-level comments
    Daniel Cheng . unresolved

    LGTM assuming the rest of the usual Blink intent process is being followed.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Andrew Rayskiy
    • Reilly Grant
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4e30fa33018548e99b0c51b7e1d7efe33e57baaf
    Gerrit-Change-Number: 5872524
    Gerrit-PatchSet: 7
    Gerrit-Owner: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Luna Lu <loon...@chromium.org>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-Attention: Reilly Grant <rei...@chromium.org>
    Gerrit-Attention: Andrew Rayskiy <green...@google.com>
    Gerrit-Comment-Date: Thu, 19 Sep 2024 19:36:08 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Reilly Grant (Gerrit)

    unread,
    Sep 19, 2024, 3:55:11 PM9/19/24
    to Andrew Rayskiy, Reilly Grant, Daniel Cheng, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, Simon Hangl, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, rmcelra...@chromium.org
    Attention needed from Andrew Rayskiy

    Reilly Grant voted and added 3 comments

    Votes added by Reilly Grant

    Code-Review+1

    3 comments

    Patchset-level comments
    Daniel Cheng . resolved

    LGTM assuming the rest of the usual Blink intent process is being followed.

    Reilly Grant

    This change is in response to Security review feedback on the Blink launch, so it's covered under the currently pending Intent to Ship.

    Reilly Grant . resolved

    LGTM

    File third_party/blink/renderer/core/permissions_policy/permissions_policy_features.json5
    Line 259, Patchset 7 (Latest): permissions_policy_name: "direct-sockets-private",
    Reilly Grant . unresolved

    Please update the Direct Sockets specification with this new policy.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Andrew Rayskiy
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4e30fa33018548e99b0c51b7e1d7efe33e57baaf
    Gerrit-Change-Number: 5872524
    Gerrit-PatchSet: 7
    Gerrit-Owner: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Luna Lu <loon...@chromium.org>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-Attention: Andrew Rayskiy <green...@google.com>
    Gerrit-Comment-Date: Thu, 19 Sep 2024 19:55:02 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Daniel Cheng <dch...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Andrew Rayskiy (Gerrit)

    unread,
    Sep 19, 2024, 6:33:25 PM9/19/24
    to Reilly Grant, Daniel Cheng, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, Simon Hangl, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, rmcelra...@chromium.org

    Andrew Rayskiy voted and added 1 comment

    Votes added by Andrew Rayskiy

    Commit-Queue+2

    1 comment

    File third_party/blink/renderer/core/permissions_policy/permissions_policy_features.json5
    Line 259, Patchset 7: permissions_policy_name: "direct-sockets-private",
    Reilly Grant . resolved

    Please update the Direct Sockets specification with this new policy.

    Andrew Rayskiy

    Will be done shortly afterwards -- thanks for reminding!

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4e30fa33018548e99b0c51b7e1d7efe33e57baaf
    Gerrit-Change-Number: 5872524
    Gerrit-PatchSet: 8
    Gerrit-Owner: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Luna Lu <loon...@chromium.org>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-Comment-Date: Thu, 19 Sep 2024 22:33:10 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Reilly Grant <rei...@chromium.org>
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 19, 2024, 6:37:40 PM9/19/24
    to Andrew Rayskiy, Reilly Grant, Daniel Cheng, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, Simon Hangl, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, rmcelra...@chromium.org

    Chromium LUCI CQ submitted the change with unreviewed changes

    Unreviewed changes

    7 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    ds: Add direct-sockets-private permissions policy

    This IWA-only permissions policy is a requirement for private network
    access in the context of Direct Sockets.
    Bug: 367741436
    Change-Id: I4e30fa33018548e99b0c51b7e1d7efe33e57baaf
    Commit-Queue: Andrew Rayskiy <green...@google.com>
    Reviewed-by: Reilly Grant <rei...@chromium.org>
    Reviewed-by: Daniel Cheng <dch...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1357891}
    Files:
    • M chrome/browser/direct_sockets/direct_sockets_apitest.cc
    • M content/browser/direct_sockets/direct_sockets_service_impl.cc
    • M content/browser/direct_sockets/direct_sockets_test_utils.cc
    • M third_party/blink/public/devtools_protocol/browser_protocol.pdl
    • M third_party/blink/public/mojom/permissions_policy/permissions_policy_feature.mojom
    • M third_party/blink/renderer/core/permissions_policy/permissions_policy_features.json5
    • M third_party/blink/web_tests/wpt_internal/isolated-permissions-policy/permissions_policy.https.html
    • M tools/metrics/histograms/enums.xml
    Change size: M
    Delta: 8 files changed, 97 insertions(+), 8 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Daniel Cheng, +1 by Reilly Grant
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4e30fa33018548e99b0c51b7e1d7efe33e57baaf
    Gerrit-Change-Number: 5872524
    Gerrit-PatchSet: 9
    Gerrit-Owner: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages