Rename fenced-frame-unpartitioned-data permissions policy. [chromium/src : main]
1 view
Skip to first unread message
gwsq (Gerrit)
Oct 24, 2024, 1:37:44 PM10/24/24
to Andrew Verge, Chromium IPC Reviews, Ken Buchanan, Yao Xiao, Jeremy Roman, Chromium LUCI CQ, Chromium Metrics Reviews, Luna Lu, AyeAye, iclella...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, devtools...@chromium.org, feature-co...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org
Attention needed from Jeremy Roman, Ken Buchanan and Yao Xiao
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: ke...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): ke...@chromium.org
Reviewer source(s):
ke...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
Attention is currently required from:
- Jeremy Roman
- Ken Buchanan
- Yao Xiao
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeremy Roman (Gerrit)
Oct 24, 2024, 1:55:12 PM10/24/24
to Andrew Verge, Jeremy Roman, Chromium IPC Reviews, Ken Buchanan, Yao Xiao, Chromium LUCI CQ, Chromium Metrics Reviews, Luna Lu, AyeAye, iclella...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, devtools...@chromium.org, feature-co...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org
Attention needed from Andrew Verge, Ken Buchanan and Yao Xiao
Jeremy Roman voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jeremy Roman
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Andrew Verge
- Ken Buchanan
- Yao Xiao
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ken Buchanan (Gerrit)
Oct 24, 2024, 1:57:37 PM10/24/24
to Andrew Verge, Jeremy Roman, Chromium IPC Reviews, Yao Xiao, Chromium LUCI CQ, Chromium Metrics Reviews, Luna Lu, AyeAye, iclella...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, devtools...@chromium.org, feature-co...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org
Attention needed from Andrew Verge and Yao Xiao
Ken Buchanan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ken Buchanan
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Andrew Verge
- Yao Xiao
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yao Xiao (Gerrit)
Oct 24, 2024, 2:04:07 PM10/24/24
to Andrew Verge, Ken Buchanan, Jeremy Roman, Chromium IPC Reviews, Chromium LUCI CQ, Chromium Metrics Reviews, Luna Lu, AyeAye, iclella...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, devtools...@chromium.org, feature-co...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org
Attention needed from Andrew Verge
Yao Xiao voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Andrew Verge
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrew Verge (Gerrit)
Oct 24, 2024, 2:33:56 PM10/24/24
to Yao Xiao, Ken Buchanan, Jeremy Roman, Chromium IPC Reviews, Chromium LUCI CQ, Chromium Metrics Reviews, Luna Lu, AyeAye, iclella...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, devtools...@chromium.org, feature-co...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org
Andrew Verge voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 24, 2024, 2:39:49 PM10/24/24
to Andrew Verge, Yao Xiao, Ken Buchanan, Jeremy Roman, Chromium IPC Reviews, Chromium Metrics Reviews, Luna Lu, AyeAye, iclella...@chromium.org, devtools-re...@chromium.org, kinuko...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, devtools...@chromium.org, feature-co...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Rename fenced-frame-unpartitioned-data permissions policy.
The new name, fenced-unpartitioned-storage-read, is closer to the one that will be used in external documentation to describe the feature we're gating.
Change-Id: Id77cc71ae3681485701e3c62e19efe6108d20dfa
Reviewed-by: Jeremy Roman <jbr...@chromium.org>
Reviewed-by: Yao Xiao <yao...@chromium.org>
Reviewed-by: Ken Buchanan <ke...@chromium.org>
Commit-Queue: Andrew Verge <ave...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1373473}
Files:
- M content/browser/shared_storage/shared_storage_document_service_impl.cc
- M third_party/blink/public/common/frame/fenced_frame_permissions_policies.h
- M third_party/blink/public/devtools_protocol/browser_protocol.pdl
- M third_party/blink/public/mojom/permissions_policy/permissions_policy_feature.mojom
- M third_party/blink/renderer/core/permissions_policy/permissions_policy_features.json5
- M third_party/blink/renderer/modules/shared_storage/shared_storage.cc
- R third_party/blink/web_tests/wpt_internal/fenced_frame/resources/unpartitioned_storage_permissions_policy_helper.js
- D third_party/blink/web_tests/wpt_internal/fenced_frame/unpartitioned-data-permissions-policy-none.tentative.https.sub.html.headers
- D third_party/blink/web_tests/wpt_internal/fenced_frame/unpartitioned-data-permissions-policy-self.tentative.https.sub.html.headers
- R third_party/blink/web_tests/wpt_internal/fenced_frame/unpartitioned-storage-permissions-policy-allow.tentative.https.sub.html
- R third_party/blink/web_tests/wpt_internal/fenced_frame/unpartitioned-storage-permissions-policy-none.tentative.https.sub.html
- A third_party/blink/web_tests/wpt_internal/fenced_frame/unpartitioned-storage-permissions-policy-none.tentative.https.sub.html.headers
- R third_party/blink/web_tests/wpt_internal/fenced_frame/unpartitioned-storage-permissions-policy-self.tentative.https.sub.html
- A third_party/blink/web_tests/wpt_internal/fenced_frame/unpartitioned-storage-permissions-policy-self.tentative.https.sub.html.headers
- M tools/metrics/histograms/enums.xml
Change size: M
Delta: 15 files changed, 42 insertions(+), 42 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ken Buchanan, +1 by Jeremy Roman, +1 by Yao Xiao
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages