Implement `fenced-frame-unparititioned-data` Permissions Policy [chromium/src : main]

1 view
Skip to first unread message

Andrew Verge (Gerrit)

unread,
Oct 9, 2024, 12:41:34 PM10/9/24
to Luna Lu, Chromium Metrics Reviews, AyeAye, alexmo...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, navigation...@chromium.org, creis...@chromium.org, devtools...@chromium.org, feature-co...@chromium.org, blink-re...@chromium.org, iclella...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Message from Andrew Verge

Set Ready For Review

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ieb8184dafd0dc4281c0375b0141c012cb0f0f793
Gerrit-Change-Number: 5920994
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Verge <ave...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Luna Lu <loon...@chromium.org>
Gerrit-Comment-Date: Wed, 09 Oct 2024 16:41:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Andrew Verge (Gerrit)

unread,
Oct 15, 2024, 5:45:24 PM10/15/24
to Chromium IPC Reviews, Yao Xiao, Alex Rudenko, Jeremy Roman, Ari Chivukula, Liam Brady, Chromium LUCI CQ, Luna Lu, Chromium Metrics Reviews, AyeAye, alexmo...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, navigation...@chromium.org, creis...@chromium.org, devtools...@chromium.org, feature-co...@chromium.org, blink-re...@chromium.org, iclella...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Alex Rudenko, Andrew Verge, Ari Chivukula, Chromium IPC Reviews, Jeremy Roman, Liam Brady and Yao Xiao

Andrew Verge added 1 comment

Patchset-level comments
File-level comment, Patchset 11 (Latest):
Andrew Verge . resolved

Adding yaoxia@ for Shared Storage OWNERS

Adding alexrudenko@ for Devtools OWNERS

Adding jbroman@ for fenced_frame_permissions_policies.h OWNERS

Adding arichiv@ for permissions_policy_features.json5 OWNERS

Adding lbrady@ for reviewing the core logic of the CL.

Open in Gerrit

Related details

Attention is currently required from:
  • Alex Rudenko
  • Andrew Verge
  • Ari Chivukula
  • Chromium IPC Reviews
  • Jeremy Roman
  • Liam Brady
  • Yao Xiao
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ieb8184dafd0dc4281c0375b0141c012cb0f0f793
Gerrit-Change-Number: 5920994
Gerrit-PatchSet: 11
Gerrit-Owner: Andrew Verge <ave...@google.com>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Andrew Verge <ave...@google.com>
Gerrit-Reviewer: Ari Chivukula <ari...@chromium.org>
Gerrit-Reviewer: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
Gerrit-Reviewer: Liam Brady <lbr...@google.com>
Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Luna Lu <loon...@chromium.org>
Gerrit-Attention: Ari Chivukula <ari...@chromium.org>
Gerrit-Attention: Jeremy Roman <jbr...@chromium.org>
Gerrit-Attention: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
Gerrit-Attention: Andrew Verge <ave...@google.com>
Gerrit-Attention: Liam Brady <lbr...@google.com>
Gerrit-Attention: Yao Xiao <yao...@chromium.org>
Gerrit-Comment-Date: Tue, 15 Oct 2024 21:45:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Andrew Verge (Gerrit)

unread,
Oct 15, 2024, 5:46:44 PM10/15/24
to Shivani Sharma, Xiaochen Zhou, Chromium IPC Reviews, Yao Xiao, Alex Rudenko, Jeremy Roman, Liam Brady, Chromium LUCI CQ, Luna Lu, Chromium Metrics Reviews, AyeAye, alexmo...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, navigation...@chromium.org, creis...@chromium.org, devtools...@chromium.org, feature-co...@chromium.org, blink-re...@chromium.org, iclella...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Alex Rudenko, Andrew Verge, Chromium IPC Reviews, Jeremy Roman, Liam Brady and Yao Xiao

Andrew Verge added 1 comment

Patchset-level comments
Andrew Verge . resolved

Removing arichiv@ due to OWNERS overlap.

Open in Gerrit

Related details

Attention is currently required from:
  • Alex Rudenko
  • Andrew Verge
  • Chromium IPC Reviews
  • Jeremy Roman
  • Liam Brady
  • Yao Xiao
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ieb8184dafd0dc4281c0375b0141c012cb0f0f793
Gerrit-Change-Number: 5920994
Gerrit-PatchSet: 11
Gerrit-Owner: Andrew Verge <ave...@google.com>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Andrew Verge <ave...@google.com>
Gerrit-Reviewer: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
Gerrit-Reviewer: Liam Brady <lbr...@google.com>
Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
Gerrit-CC: Andrew Verge <ave...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Luna Lu <loon...@chromium.org>
Gerrit-CC: Shivani Sharma <shiva...@chromium.org>
Gerrit-CC: Xiaochen Zhou <xiaoc...@chromium.org>
Gerrit-Attention: Jeremy Roman <jbr...@chromium.org>
Gerrit-Attention: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
Gerrit-Attention: Andrew Verge <ave...@google.com>
Gerrit-Attention: Liam Brady <lbr...@google.com>
Gerrit-Attention: Yao Xiao <yao...@chromium.org>
Gerrit-Comment-Date: Tue, 15 Oct 2024 21:46:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Oct 15, 2024, 5:49:20 PM10/15/24
to Andrew Verge, Chromium IPC Reviews, Ken Buchanan, Shivani Sharma, Xiaochen Zhou, Yao Xiao, Alex Rudenko, Jeremy Roman, Liam Brady, Chromium LUCI CQ, Luna Lu, Chromium Metrics Reviews, AyeAye, alexmo...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, navigation...@chromium.org, creis...@chromium.org, devtools...@chromium.org, feature-co...@chromium.org, blink-re...@chromium.org, iclella...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Alex Rudenko, Andrew Verge, Jeremy Roman, Ken Buchanan, Liam Brady and Yao Xiao

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: ke...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): ke...@chromium.org


Reviewer source(s):
ke...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Alex Rudenko
  • Andrew Verge
  • Jeremy Roman
  • Ken Buchanan
  • Liam Brady
  • Yao Xiao
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ieb8184dafd0dc4281c0375b0141c012cb0f0f793
Gerrit-Change-Number: 5920994
Gerrit-PatchSet: 11
Gerrit-Owner: Andrew Verge <ave...@google.com>
Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
Gerrit-Reviewer: Andrew Verge <ave...@google.com>
Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
Gerrit-Reviewer: Liam Brady <lbr...@google.com>
Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
Gerrit-CC: Andrew Verge <ave...@chromium.org>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Luna Lu <loon...@chromium.org>
Gerrit-CC: Shivani Sharma <shiva...@chromium.org>
Gerrit-CC: Xiaochen Zhou <xiaoc...@chromium.org>
Gerrit-CC: gwsq
Gerrit-Attention: Jeremy Roman <jbr...@chromium.org>
Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
Gerrit-Attention: Ken Buchanan <ke...@chromium.org>
Gerrit-Attention: Andrew Verge <ave...@google.com>
Gerrit-Attention: Liam Brady <lbr...@google.com>
Gerrit-Attention: Yao Xiao <yao...@chromium.org>
Gerrit-Comment-Date: Tue, 15 Oct 2024 21:49:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Alex Rudenko (Gerrit)

unread,
Oct 16, 2024, 2:17:17 AM10/16/24
to Andrew Verge, Chromium IPC Reviews, Ken Buchanan, Shivani Sharma, Xiaochen Zhou, Yao Xiao, Jeremy Roman, Liam Brady, Chromium LUCI CQ, Luna Lu, Chromium Metrics Reviews, AyeAye, alexmo...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, navigation...@chromium.org, creis...@chromium.org, devtools...@chromium.org, feature-co...@chromium.org, blink-re...@chromium.org, iclella...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Andrew Verge, Andrew Verge, Jeremy Roman, Ken Buchanan, Liam Brady and Yao Xiao

Alex Rudenko voted and added 1 comment

Votes added by Alex Rudenko

Code-Review+1

1 comment

Patchset-level comments
Alex Rudenko . resolved

devtools lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Verge
  • Andrew Verge
  • Jeremy Roman
  • Ken Buchanan
  • Liam Brady
  • Yao Xiao
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Gerrit-Attention: Andrew Verge <ave...@chromium.org>
    Gerrit-Attention: Ken Buchanan <ke...@chromium.org>
    Gerrit-Attention: Andrew Verge <ave...@google.com>
    Gerrit-Attention: Liam Brady <lbr...@google.com>
    Gerrit-Attention: Yao Xiao <yao...@chromium.org>
    Gerrit-Comment-Date: Wed, 16 Oct 2024 06:17:00 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Andrew Verge (Gerrit)

    unread,
    Oct 16, 2024, 11:41:18 AM10/16/24
    to Ian Clelland, Alex Rudenko, Chromium IPC Reviews, Ken Buchanan, Shivani Sharma, Xiaochen Zhou, Yao Xiao, Jeremy Roman, Liam Brady, Chromium LUCI CQ, Luna Lu, Chromium Metrics Reviews, AyeAye, alexmo...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, navigation...@chromium.org, creis...@chromium.org, devtools...@chromium.org, feature-co...@chromium.org, blink-re...@chromium.org, iclella...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
    Attention needed from Andrew Verge, Jeremy Roman, Ken Buchanan, Liam Brady and Yao Xiao

    Andrew Verge added 1 comment

    Patchset-level comments
    Andrew Verge . resolved

    Adding iclelland@ for Permissions Policy expertise in general.

    Sorry for so many reviewers, trying to balance domain expertise and OWNERs approvals.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Andrew Verge
    • Jeremy Roman
    • Ken Buchanan
    • Liam Brady
    • Yao Xiao
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ieb8184dafd0dc4281c0375b0141c012cb0f0f793
    Gerrit-Change-Number: 5920994
    Gerrit-PatchSet: 11
    Gerrit-Owner: Andrew Verge <ave...@google.com>
    Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Reviewer: Andrew Verge <ave...@google.com>
    Gerrit-Reviewer: Ian Clelland <icle...@chromium.org>
    Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
    Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
    Gerrit-Reviewer: Liam Brady <lbr...@google.com>
    Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
    Gerrit-CC: Andrew Verge <ave...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Luna Lu <loon...@chromium.org>
    Gerrit-CC: Shivani Sharma <shiva...@chromium.org>
    Gerrit-CC: Xiaochen Zhou <xiaoc...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-Attention: Jeremy Roman <jbr...@chromium.org>
    Gerrit-Attention: Ken Buchanan <ke...@chromium.org>
    Gerrit-Attention: Andrew Verge <ave...@google.com>
    Gerrit-Attention: Liam Brady <lbr...@google.com>
    Gerrit-Attention: Yao Xiao <yao...@chromium.org>
    Gerrit-Comment-Date: Wed, 16 Oct 2024 15:41:08 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy

    Liam Brady (Gerrit)

    unread,
    Oct 16, 2024, 11:46:28 AM10/16/24
    to Andrew Verge, Ian Clelland, Alex Rudenko, Chromium IPC Reviews, Ken Buchanan, Shivani Sharma, Xiaochen Zhou, Yao Xiao, Jeremy Roman, Chromium LUCI CQ, Luna Lu, Chromium Metrics Reviews, AyeAye, alexmo...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, navigation...@chromium.org, creis...@chromium.org, devtools...@chromium.org, feature-co...@chromium.org, blink-re...@chromium.org, iclella...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
    Attention needed from Andrew Verge, Jeremy Roman, Ken Buchanan and Yao Xiao

    Liam Brady added 3 comments

    Patchset-level comments
    Liam Brady . resolved

    Core logic looks good. Just a couple test-based things.

    File third_party/blink/web_tests/wpt_internal/fenced_frame/resources/permissions_policy_helper.js
    Line 1, Patchset 11 (Latest):// Runs a single test case that checks if the fenced-frame-unpartitioned-data
    Liam Brady . unresolved

    I think this file should either be generalized or renamed to something unpartitioned-data-specific. (Probably easier to just rename). It might be confusing since there are other permissions tests that don't use this file as a helper.

    File third_party/blink/web_tests/wpt_internal/fenced_frame/unpartitioned-data-permissions-policy-self.tentative.https.sub.html
    Line 15, Patchset 11 (Latest): // Set sharedStorage value for HTTPS_ORIGIN
    Liam Brady . unresolved

    Should this be a function in the helper js file? And have the 3 files just invoke that in their `promise_setup()`?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Andrew Verge
    • Jeremy Roman
    • Ken Buchanan
    • Yao Xiao
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      Gerrit-Attention: Yao Xiao <yao...@chromium.org>
      Gerrit-Comment-Date: Wed, 16 Oct 2024 15:46:15 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Yao Xiao (Gerrit)

      unread,
      Oct 16, 2024, 2:32:59 PM10/16/24
      to Andrew Verge, Ian Clelland, Alex Rudenko, Chromium IPC Reviews, Ken Buchanan, Shivani Sharma, Xiaochen Zhou, Jeremy Roman, Liam Brady, Chromium LUCI CQ, Luna Lu, Chromium Metrics Reviews, AyeAye, alexmo...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, navigation...@chromium.org, creis...@chromium.org, devtools...@chromium.org, feature-co...@chromium.org, blink-re...@chromium.org, iclella...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
      Attention needed from Andrew Verge, Andrew Verge, Ian Clelland, Jeremy Roman and Ken Buchanan

      Yao Xiao voted and added 1 comment

      Votes added by Yao Xiao

      Code-Review+1

      1 comment

      Patchset-level comments
      Yao Xiao . resolved

      Shared Storage LGTM

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Andrew Verge
      • Andrew Verge
      • Ian Clelland
      • Jeremy Roman
      • Ken Buchanan
      Gerrit-Attention: Ian Clelland <icle...@chromium.org>
      Gerrit-Attention: Jeremy Roman <jbr...@chromium.org>
      Gerrit-Attention: Andrew Verge <ave...@chromium.org>
      Gerrit-Attention: Ken Buchanan <ke...@chromium.org>
      Gerrit-Attention: Andrew Verge <ave...@google.com>
      Gerrit-Comment-Date: Wed, 16 Oct 2024 18:32:46 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Ken Buchanan (Gerrit)

      unread,
      Oct 17, 2024, 9:27:12 AM10/17/24
      to Andrew Verge, Yao Xiao, Ian Clelland, Alex Rudenko, Chromium IPC Reviews, Shivani Sharma, Xiaochen Zhou, Jeremy Roman, Liam Brady, Chromium LUCI CQ, Luna Lu, Chromium Metrics Reviews, AyeAye, alexmo...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, navigation...@chromium.org, creis...@chromium.org, devtools...@chromium.org, feature-co...@chromium.org, blink-re...@chromium.org, iclella...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
      Attention needed from Andrew Verge, Andrew Verge, Ian Clelland and Jeremy Roman

      Ken Buchanan voted and added 1 comment

      Votes added by Ken Buchanan

      Code-Review+1

      1 comment

      Patchset-level comments
      Ken Buchanan . resolved

      mojom lgtm

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Andrew Verge
      • Andrew Verge
      • Ian Clelland
      • Jeremy Roman
      Gerrit-Attention: Andrew Verge <ave...@google.com>
      Gerrit-Comment-Date: Thu, 17 Oct 2024 13:26:59 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Jeremy Roman (Gerrit)

      unread,
      Oct 17, 2024, 3:40:47 PM10/17/24
      to Andrew Verge, Jeremy Roman, Ken Buchanan, Yao Xiao, Ian Clelland, Alex Rudenko, Chromium IPC Reviews, Shivani Sharma, Xiaochen Zhou, Liam Brady, Chromium LUCI CQ, Luna Lu, Chromium Metrics Reviews, AyeAye, alexmo...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, navigation...@chromium.org, creis...@chromium.org, devtools...@chromium.org, feature-co...@chromium.org, blink-re...@chromium.org, iclella...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
      Attention needed from Andrew Verge, Andrew Verge and Ian Clelland

      Jeremy Roman voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Andrew Verge
      • Andrew Verge
      • Ian Clelland
      Gerrit-Attention: Andrew Verge <ave...@chromium.org>
      Gerrit-Attention: Andrew Verge <ave...@google.com>
      Gerrit-Comment-Date: Thu, 17 Oct 2024 19:40:35 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Andrew Verge (Gerrit)

      unread,
      Oct 18, 2024, 11:28:10 AM10/18/24
      to Jeremy Roman, Ken Buchanan, Yao Xiao, Ian Clelland, Alex Rudenko, Chromium IPC Reviews, Shivani Sharma, Xiaochen Zhou, Liam Brady, Chromium LUCI CQ, Luna Lu, Chromium Metrics Reviews, AyeAye, alexmo...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, navigation...@chromium.org, creis...@chromium.org, devtools...@chromium.org, feature-co...@chromium.org, blink-re...@chromium.org, iclella...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
      Attention needed from Alex Rudenko, Andrew Verge, Ian Clelland, Jeremy Roman, Ken Buchanan, Liam Brady and Yao Xiao

      Andrew Verge added 2 comments

      File third_party/blink/web_tests/wpt_internal/fenced_frame/resources/permissions_policy_helper.js
      Line 1, Patchset 11:// Runs a single test case that checks if the fenced-frame-unpartitioned-data
      Liam Brady . resolved

      I think this file should either be generalized or renamed to something unpartitioned-data-specific. (Probably easier to just rename). It might be confusing since there are other permissions tests that don't use this file as a helper.

      Andrew Verge

      Renamed.

      File third_party/blink/web_tests/wpt_internal/fenced_frame/unpartitioned-data-permissions-policy-self.tentative.https.sub.html
      Line 15, Patchset 11: // Set sharedStorage value for HTTPS_ORIGIN
      Liam Brady . resolved

      Should this be a function in the helper js file? And have the 3 files just invoke that in their `promise_setup()`?

      Andrew Verge

      Done.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Alex Rudenko
      • Andrew Verge
      • Ian Clelland
      • Jeremy Roman
      • Ken Buchanan
      • Liam Brady
      • Yao Xiao
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Review
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ieb8184dafd0dc4281c0375b0141c012cb0f0f793
        Gerrit-Change-Number: 5920994
        Gerrit-PatchSet: 12
        Gerrit-Owner: Andrew Verge <ave...@google.com>
        Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
        Gerrit-Reviewer: Andrew Verge <ave...@google.com>
        Gerrit-Reviewer: Ian Clelland <icle...@chromium.org>
        Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
        Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
        Gerrit-Reviewer: Liam Brady <lbr...@google.com>
        Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
        Gerrit-CC: Andrew Verge <ave...@chromium.org>
        Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-CC: Luna Lu <loon...@chromium.org>
        Gerrit-CC: Shivani Sharma <shiva...@chromium.org>
        Gerrit-CC: Xiaochen Zhou <xiaoc...@chromium.org>
        Gerrit-CC: gwsq
        Gerrit-Attention: Ian Clelland <icle...@chromium.org>
        Gerrit-Attention: Jeremy Roman <jbr...@chromium.org>
        Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
        Gerrit-Attention: Ken Buchanan <ke...@chromium.org>
        Gerrit-Attention: Andrew Verge <ave...@google.com>
        Gerrit-Attention: Liam Brady <lbr...@google.com>
        Gerrit-Attention: Yao Xiao <yao...@chromium.org>
        Gerrit-Comment-Date: Fri, 18 Oct 2024 15:28:03 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Liam Brady <lbr...@google.com>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Liam Brady (Gerrit)

        unread,
        Oct 18, 2024, 11:43:25 AM10/18/24
        to Andrew Verge, Jeremy Roman, Ken Buchanan, Yao Xiao, Ian Clelland, Alex Rudenko, Chromium IPC Reviews, Shivani Sharma, Xiaochen Zhou, Chromium LUCI CQ, Luna Lu, Chromium Metrics Reviews, AyeAye, alexmo...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, navigation...@chromium.org, creis...@chromium.org, devtools...@chromium.org, feature-co...@chromium.org, blink-re...@chromium.org, iclella...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
        Attention needed from Alex Rudenko, Andrew Verge, Andrew Verge, Ian Clelland, Jeremy Roman, Ken Buchanan and Yao Xiao

        Liam Brady voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Alex Rudenko
        • Andrew Verge
        • Andrew Verge
        • Ian Clelland
        • Jeremy Roman
        • Ken Buchanan
        • Yao Xiao
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Review
        Gerrit-Attention: Andrew Verge <ave...@chromium.org>
        Gerrit-Attention: Ken Buchanan <ke...@chromium.org>
        Gerrit-Attention: Andrew Verge <ave...@google.com>
        Gerrit-Attention: Yao Xiao <yao...@chromium.org>
        Gerrit-Comment-Date: Fri, 18 Oct 2024 15:43:14 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Ken Buchanan (Gerrit)

        unread,
        Oct 18, 2024, 11:48:56 AM10/18/24
        to Andrew Verge, Liam Brady, Jeremy Roman, Yao Xiao, Ian Clelland, Alex Rudenko, Chromium IPC Reviews, Shivani Sharma, Xiaochen Zhou, Chromium LUCI CQ, Luna Lu, Chromium Metrics Reviews, AyeAye, alexmo...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, navigation...@chromium.org, creis...@chromium.org, devtools...@chromium.org, feature-co...@chromium.org, blink-re...@chromium.org, iclella...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
        Attention needed from Alex Rudenko, Andrew Verge, Andrew Verge, Ian Clelland, Jeremy Roman and Yao Xiao

        Ken Buchanan voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Alex Rudenko
        • Andrew Verge
        • Andrew Verge
        • Ian Clelland
        • Jeremy Roman
        • Yao Xiao
        Gerrit-Attention: Andrew Verge <ave...@google.com>
        Gerrit-Attention: Yao Xiao <yao...@chromium.org>
        Gerrit-Comment-Date: Fri, 18 Oct 2024 15:48:41 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Yao Xiao (Gerrit)

        unread,
        Oct 18, 2024, 5:11:38 PM10/18/24
        to Andrew Verge, Ken Buchanan, Liam Brady, Jeremy Roman, Ian Clelland, Alex Rudenko, Chromium IPC Reviews, Shivani Sharma, Xiaochen Zhou, Chromium LUCI CQ, Luna Lu, Chromium Metrics Reviews, AyeAye, alexmo...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, navigation...@chromium.org, creis...@chromium.org, devtools...@chromium.org, feature-co...@chromium.org, blink-re...@chromium.org, iclella...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
        Attention needed from Alex Rudenko, Andrew Verge, Andrew Verge, Ian Clelland and Jeremy Roman

        Yao Xiao voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Alex Rudenko
        • Andrew Verge
        • Andrew Verge
        • Ian Clelland
        • Jeremy Roman
        Gerrit-Comment-Date: Fri, 18 Oct 2024 21:11:24 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Ian Clelland (Gerrit)

        unread,
        Oct 21, 2024, 11:54:35 AM10/21/24
        to Andrew Verge, Yao Xiao, Ken Buchanan, Liam Brady, Jeremy Roman, Alex Rudenko, Chromium IPC Reviews, Shivani Sharma, Xiaochen Zhou, Chromium LUCI CQ, Luna Lu, Chromium Metrics Reviews, AyeAye, alexmo...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, navigation...@chromium.org, creis...@chromium.org, devtools...@chromium.org, feature-co...@chromium.org, blink-re...@chromium.org, iclella...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
        Attention needed from Alex Rudenko, Andrew Verge, Andrew Verge and Jeremy Roman

        Ian Clelland voted and added 1 comment

        Votes added by Ian Clelland

        Code-Review+1

        1 comment

        Patchset-level comments
        File-level comment, Patchset 12 (Latest):
        Ian Clelland . resolved

        Permissions policy integration LGTM, thanks!

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Alex Rudenko
        • Andrew Verge
        • Andrew Verge
        • Jeremy Roman
        Gerrit-Attention: Jeremy Roman <jbr...@chromium.org>
        Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
        Gerrit-Attention: Andrew Verge <ave...@chromium.org>
        Gerrit-Attention: Andrew Verge <ave...@google.com>
        Gerrit-Comment-Date: Mon, 21 Oct 2024 15:54:20 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Andrew Verge (Gerrit)

        unread,
        Oct 21, 2024, 12:25:07 PM10/21/24
        to Ian Clelland, Yao Xiao, Ken Buchanan, Liam Brady, Jeremy Roman, Alex Rudenko, Chromium IPC Reviews, Shivani Sharma, Xiaochen Zhou, Chromium LUCI CQ, Luna Lu, Chromium Metrics Reviews, AyeAye, alexmo...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, navigation...@chromium.org, creis...@chromium.org, devtools...@chromium.org, feature-co...@chromium.org, blink-re...@chromium.org, iclella...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
        Attention needed from Alex Rudenko, Andrew Verge and Jeremy Roman

        Andrew Verge voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Alex Rudenko
        • Andrew Verge
        • Jeremy Roman
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Review
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ieb8184dafd0dc4281c0375b0141c012cb0f0f793
        Gerrit-Change-Number: 5920994
        Gerrit-PatchSet: 12
        Gerrit-Owner: Andrew Verge <ave...@google.com>
        Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
        Gerrit-Reviewer: Andrew Verge <ave...@chromium.org>
        Gerrit-Reviewer: Andrew Verge <ave...@google.com>
        Gerrit-Reviewer: Ian Clelland <icle...@chromium.org>
        Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
        Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
        Gerrit-Reviewer: Liam Brady <lbr...@google.com>
        Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
        Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-CC: Luna Lu <loon...@chromium.org>
        Gerrit-CC: Shivani Sharma <shiva...@chromium.org>
        Gerrit-CC: Xiaochen Zhou <xiaoc...@chromium.org>
        Gerrit-CC: gwsq
        Gerrit-Attention: Jeremy Roman <jbr...@chromium.org>
        Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
        Gerrit-Attention: Andrew Verge <ave...@google.com>
        Gerrit-Comment-Date: Mon, 21 Oct 2024 16:24:52 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        Oct 21, 2024, 1:23:41 PM10/21/24
        to Andrew Verge, Ian Clelland, Yao Xiao, Ken Buchanan, Liam Brady, Jeremy Roman, Alex Rudenko, Chromium IPC Reviews, Shivani Sharma, Xiaochen Zhou, Luna Lu, Chromium Metrics Reviews, AyeAye, alexmo...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, navigation...@chromium.org, creis...@chromium.org, devtools...@chromium.org, feature-co...@chromium.org, blink-re...@chromium.org, iclella...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

        Chromium LUCI CQ submitted the change

        Change information

        Commit message:
        Implement `fenced-frame-unparititioned-data` Permissions Policy

        The default value for this permission is *. 

        Regarding testing: The existing permissions_policy.js test framework relies on postMessage() to send test results out of the frame. Fenced frames do not have access to postMessage(), by design. I rolled my own test helper using RemoteContext instead.
        Change-Id: Ieb8184dafd0dc4281c0375b0141c012cb0f0f793
        Commit-Queue: Andrew Verge <ave...@chromium.org>
        Reviewed-by: Yao Xiao <yao...@chromium.org>
        Reviewed-by: Liam Brady <lbr...@google.com>
        Reviewed-by: Ken Buchanan <ke...@chromium.org>
        Reviewed-by: Ian Clelland <icle...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1371476}
        Files:
        • M content/browser/shared_storage/shared_storage_document_service_impl.cc
        • M third_party/blink/public/common/frame/fenced_frame_permissions_policies.h
        • M third_party/blink/public/devtools_protocol/browser_protocol.pdl
        • M third_party/blink/public/mojom/permissions_policy/permissions_policy_feature.mojom
        • M third_party/blink/renderer/core/permissions_policy/permissions_policy_features.json5
        • M third_party/blink/renderer/modules/shared_storage/shared_storage.cc
        • A third_party/blink/web_tests/wpt_internal/fenced_frame/resources/unpartitioned_data_permissions_policy_helper.js
        • A third_party/blink/web_tests/wpt_internal/fenced_frame/unpartitioned-data-permissions-policy-allow.tentative.https.sub.html
        • A third_party/blink/web_tests/wpt_internal/fenced_frame/unpartitioned-data-permissions-policy-none.tentative.https.sub.html
        • A third_party/blink/web_tests/wpt_internal/fenced_frame/unpartitioned-data-permissions-policy-none.tentative.https.sub.html.headers
        • A third_party/blink/web_tests/wpt_internal/fenced_frame/unpartitioned-data-permissions-policy-self.tentative.https.sub.html
        • A third_party/blink/web_tests/wpt_internal/fenced_frame/unpartitioned-data-permissions-policy-self.tentative.https.sub.html.headers
        • M tools/metrics/histograms/enums.xml
        Change size: M
        Delta: 13 files changed, 246 insertions(+), 0 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Ken Buchanan, +1 by Ian Clelland, +1 by Liam Brady, +1 by Yao Xiao
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ieb8184dafd0dc4281c0375b0141c012cb0f0f793
        Gerrit-Change-Number: 5920994
        Gerrit-PatchSet: 13
        Gerrit-Owner: Andrew Verge <ave...@google.com>
        Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
        Gerrit-Reviewer: Andrew Verge <ave...@chromium.org>
        Gerrit-Reviewer: Andrew Verge <ave...@google.com>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Ian Clelland <icle...@chromium.org>
        Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
        Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
        Gerrit-Reviewer: Liam Brady <lbr...@google.com>
        Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
        Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages