Alex N. Jose (Gerrit)

unread,

Sep 9, 2024, 8:29:55 PM9/9/24

to Koji Ishii, Chromium IPC Reviews, Kouhei Ueno, Chromium LUCI CQ, Kyra Seevers, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, Luna Lu, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org

Attention needed from Chromium IPC Reviews, Koji Ishii and Kouhei Ueno

Alex N. Jose added 1 comment

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Alex N. Jose . resolved

kouhei@, kojii@, chromium-ipc-reviews@, could I get your review of this CL?

Open in Gerrit

Related details

Attention is currently required from:

Chromium IPC Reviews
Koji Ishii
Kouhei Ueno

Submit Requirements:

Code-Coverage
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

gwsq (Gerrit)

unread,

Sep 9, 2024, 8:31:46 PM9/9/24

to Alex N. Jose, Chromium IPC Reviews, Alex Gough, Koji Ishii, Kouhei Ueno, Chromium LUCI CQ, Kyra Seevers, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, Luna Lu, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org

Attention needed from Alex Gough, Koji Ishii and Kouhei Ueno

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: aj...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): aj...@chromium.org

Reviewer source(s):
aj...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

Alex Gough
Koji Ishii
Kouhei Ueno

Submit Requirements:

Code-Coverage
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alex N. Jose (Gerrit)

unread,

Sep 9, 2024, 8:34:57 PM9/9/24

to Chromium IPC Reviews, Alex Gough, Koji Ishii, Kouhei Ueno, Chromium LUCI CQ, Kyra Seevers, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, Luna Lu, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org

Attention needed from Alex Gough, Koji Ishii and Kouhei Ueno

Alex N. Jose added 1 comment

File third_party/blink/web_tests/virtual/expect-no-embedded-resources/README.md

Line 4, Patchset 4:See crbug.com/<TODO>.

Alex N. Jose . resolved

Comment to track this ticket ID replacement TODO

Alex N. Jose

Done

Open in Gerrit

Related details

Attention is currently required from:

Alex Gough
Koji Ishii
Kouhei Ueno

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alex Gough (Gerrit)

unread,

Sep 9, 2024, 11:35:10 PM9/9/24

to Alex N. Jose, Alex Gough, Chromium IPC Reviews, Koji Ishii, Kouhei Ueno, Chromium LUCI CQ, Kyra Seevers, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, Luna Lu, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org

Attention needed from Alex N. Jose, Koji Ishii and Kouhei Ueno

Alex Gough voted and added 1 comment

Votes added by Alex Gough

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Alex Gough . resolved

lgtm mojom

Open in Gerrit

Related details

Attention is currently required from:

Alex N. Jose
Koji Ishii
Kouhei Ueno

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Koji Ishii (Gerrit)

unread,

Sep 10, 2024, 2:52:30 AM9/10/24

to Alex N. Jose, Domenic Denicola, Alex Gough, Chromium IPC Reviews, Kouhei Ueno, Chromium LUCI CQ, Kyra Seevers, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, Luna Lu, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org

Attention needed from Alex N. Jose and Kouhei Ueno

Koji Ishii added 1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Koji Ishii . resolved

third_party/blink/web_tests/VirtualTestSuites lgtm but I'd like to ask @kouhei to review other `blink/renderer` files.

Open in Gerrit

Related details

Attention is currently required from:

Alex N. Jose
Kouhei Ueno

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Kouhei Ueno (Gerrit)

unread,

Sep 10, 2024, 7:55:21 AM9/10/24

to Alex N. Jose, Domenic Denicola, Alex Gough, Chromium IPC Reviews, Koji Ishii, Chromium LUCI CQ, Kyra Seevers, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, Luna Lu, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org

Attention needed from Alex N. Jose

Kouhei Ueno voted and added 2 comments

Votes added by Kouhei Ueno

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Kouhei Ueno . resolved

cr+1 % nit

File third_party/blink/renderer/core/html/parser/html_document_parser.cc

Line 1753, Patchset 7 (Latest):bool HTMLDocumentParser::ShouldSkipPreloadScan() {

Kouhei Ueno . unresolved

Can we invoke+cache this on the `HTMLDocumentParser` ctor?

Open in Gerrit

Related details

Attention is currently required from:

Alex N. Jose

Submit Requirements:

Code-Coverage
Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alex N. Jose (Gerrit)

unread,

Sep 10, 2024, 6:55:03 PM9/10/24

to Kouhei Ueno, Domenic Denicola, Alex Gough, Chromium IPC Reviews, Koji Ishii, Chromium LUCI CQ, Kyra Seevers, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, Luna Lu, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org

Alex N. Jose added 1 comment

File third_party/blink/renderer/core/html/parser/html_document_parser.cc

Line 1753, Patchset 7:bool HTMLDocumentParser::ShouldSkipPreloadScan() {

Kouhei Ueno . resolved

Can we invoke+cache this on the `HTMLDocumentParser` ctor?

Alex N. Jose

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Alex N. Jose (Gerrit)

unread,

Sep 11, 2024, 11:06:26 AM9/11/24

to Kouhei Ueno, Domenic Denicola, Alex Gough, Chromium IPC Reviews, Koji Ishii, Chromium LUCI CQ, Kyra Seevers, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, Luna Lu, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org

Alex N. Jose added 1 comment

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Alex N. Jose . resolved

kojii@, could I have your review on third_party/blink/web_tests/VirtualTestSuites?

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Koji Ishii (Gerrit)

unread,

Sep 11, 2024, 5:06:36 PM9/11/24

to Alex N. Jose, Kouhei Ueno, Domenic Denicola, Alex Gough, Chromium IPC Reviews, Chromium LUCI CQ, Kyra Seevers, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, Luna Lu, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org

Attention needed from Alex N. Jose

Koji Ishii voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Alex N. Jose

satisfied_requirement

open

diffy

Alex N. Jose (Gerrit)

unread,

Sep 11, 2024, 6:54:12 PM9/11/24

to Koji Ishii, Kouhei Ueno, Domenic Denicola, Alex Gough, Chromium IPC Reviews, Chromium LUCI CQ, Kyra Seevers, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, Luna Lu, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org

Alex N. Jose voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Sep 11, 2024, 6:58:25 PM9/11/24

to Alex N. Jose, Koji Ishii, Kouhei Ueno, Domenic Denicola, Alex Gough, Chromium IPC Reviews, Kyra Seevers, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, Luna Lu, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Implement Document-Policy: expect-no-embedded-resources

The expect-no-linked-resources configuration point in Document Policy allows a document to hint to the user agent to better optimize its loading sequence, such as not using the default speculative parsing behavior. The current implementation on this CL skips attaching PreloadScanner if the policy is supplied.

Bug: 365632977

Change-Id: Ia4b307a4eac2051cca77d6ad1fe8354aa74a6790

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5840722

Reviewed-by: Kouhei Ueno <kou...@chromium.org>

Commit-Queue: Alex N. Jose <ale...@chromium.org>

Reviewed-by: Alex Gough <aj...@chromium.org>

Reviewed-by: Koji Ishii <ko...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1354246}

Files:

M third_party/blink/public/mojom/permissions_policy/document_policy_feature.mojom
M third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
M third_party/blink/renderer/core/html/parser/html_document_parser.cc
M third_party/blink/renderer/core/html/parser/html_document_parser.h
M third_party/blink/renderer/core/permissions_policy/document_policy_features.json5
M third_party/blink/renderer/platform/runtime_enabled_features.json5
M third_party/blink/web_tests/VirtualTestSuites
A third_party/blink/web_tests/http/tests/expect-no-embedded-resources/no-preloadscanning-when-no-resources.php
A third_party/blink/web_tests/virtual/expect-no-embedded-resources/README.md
M tools/metrics/histograms/enums.xml

Change size: M

Delta: 10 files changed, 88 insertions(+), 4 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Koji Ishii, +1 by Kouhei Ueno, +1 by Alex Gough

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Implement Document-Policy: expect-no-embedded-resources [chromium/src : main]

Alex N. Jose (Gerrit)

Alex N. Jose added 1 comment

Related details

gwsq (Gerrit)

Message from gwsq

Related details

Alex N. Jose (Gerrit)

Alex N. Jose added 1 comment

Related details

Alex Gough (Gerrit)

Alex Gough voted and added 1 comment

Votes added by Alex Gough

1 comment

Related details

Koji Ishii (Gerrit)

Koji Ishii added 1 comment

Related details

Kouhei Ueno (Gerrit)

Kouhei Ueno voted and added 2 comments

Votes added by Kouhei Ueno

2 comments

Related details

Alex N. Jose (Gerrit)

Alex N. Jose added 1 comment

Related details

Alex N. Jose (Gerrit)

Alex N. Jose added 1 comment

Related details

Koji Ishii (Gerrit)

Koji Ishii voted Code-Review+1

Related details

Alex N. Jose (Gerrit)

Alex N. Jose voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information