[Partitioned Popins] (6) Add permissions policy for popin [chromium/src : main]
0 views
Skip to first unread message
Ari Chivukula (Gerrit)
Aug 21, 2024, 9:47:53 AM8/21/24
to Daniel Cheng, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, blink-revie...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Daniel Cheng
Ari Chivukula voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Aug 21, 2024, 12:29:54 PM8/21/24
to Ari Chivukula, Daniel Cheng, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, blink-revi...@chromium.org, blink-revie...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Ari Chivukula
Daniel Cheng voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Ari Chivukula
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ari Chivukula (Gerrit)
Aug 21, 2024, 12:30:51 PM8/21/24
to Daniel Cheng, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, blink-revi...@chromium.org, blink-revie...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Ari Chivukula voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Aug 21, 2024, 12:44:57 PM8/21/24
to Ari Chivukula, Daniel Cheng, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, blink-revi...@chromium.org, blink-revie...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/47719.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Aug 21, 2024, 12:45:51 PM8/21/24
to Ari Chivukula, Blink W3C Test Autoroller, Daniel Cheng, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, blink-revi...@chromium.org, blink-revie...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Partitioned Popins] (6) Add permissions policy for popin
This CL adds a permissions policy to control access to the partitioned
popin feature and sets the default to 'self'.
This series of CLs implement core components of the Partitioned Popin
system, significant additional effort will be needed to align with the
explainer and I2P, but all of that will depend on this work:
(1) Implement `popin` window feature
(2) `popin` feature triggers tab modal popup
(3) `popin` feature triggers third-party storage partitioning
(4) Renderer awareness of popin top-origin
(5) Limit window.opener access for popin
(6) Add permissions policy for popin
Explainer: https://explainers-by-googlers.github.io/partitioned-popins/
I2P: https://groups.google.com/a/chromium.org/g/blink-dev/c/ApU_zUmpQ2g/
Bug: 340606651
Change-Id: Ifde9f8e3529d794b5242df561603df7739a1f892
Auto-Submit: Ari Chivukula <ari...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Commit-Queue: Ari Chivukula <ari...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1344862}
Files:
- M third_party/blink/public/devtools_protocol/browser_protocol.pdl
- M third_party/blink/public/mojom/permissions_policy/permissions_policy_feature.mojom
- M third_party/blink/renderer/core/frame/local_dom_window.cc
- M third_party/blink/renderer/core/permissions_policy/permissions_policy_features.json5
- A third_party/blink/web_tests/external/wpt/partitioned-popins/partitioned-popins.permission-all.tentative.sub.https.window.js
- A third_party/blink/web_tests/external/wpt/partitioned-popins/partitioned-popins.permission-all.tentative.sub.https.window.js.headers
- A third_party/blink/web_tests/external/wpt/partitioned-popins/partitioned-popins.permission-default.tentative.sub.https.window.js
- A third_party/blink/web_tests/external/wpt/partitioned-popins/partitioned-popins.permission-self.tentative.sub.https.window.js
- A third_party/blink/web_tests/external/wpt/partitioned-popins/partitioned-popins.permission-self.tentative.sub.https.window.js.headers
- A third_party/blink/web_tests/external/wpt/partitioned-popins/resources/partitioned-popins.permissions-iframe.html
- A third_party/blink/web_tests/external/wpt/partitioned-popins/resources/partitioned-popins.permissions-popin.html
- M third_party/blink/web_tests/webexposed/feature-policy-features-expected.txt
- M tools/metrics/histograms/enums.xml
Change size: M
Delta: 13 files changed, 152 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Daniel Cheng
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Aug 21, 2024, 1:15:31 PM8/21/24
to Ari Chivukula, Chromium LUCI CQ, Daniel Cheng, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, blink-revi...@chromium.org, blink-revie...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/47719
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages