Siye Liu (Gerrit)

unread,

Oct 22, 2024, 4:33:57 PM10/22/24

to Ian Clelland, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Luna Lu, feature-me...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org

Attention needed from Ian Clelland

Siye Liu added 1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Siye Liu . resolved

Thank you!

Open in Gerrit

Related details

Attention is currently required from:

Ian Clelland

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Sanket Joshi (Gerrit)

unread,

Oct 22, 2024, 5:28:42 PM10/22/24

to Siye Liu, Ian Clelland, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Luna Lu, feature-me...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org

Attention needed from Ian Clelland and Siye Liu

Sanket Joshi voted and added 4 comments

Votes added by Sanket Joshi

Code-Review

+1

4 comments

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Sanket Joshi . resolved

LGTM % a few minor suggestions

File third_party/blink/web_tests/external/wpt/permissions-policy/experimental-features/focus-without-user-activation-default-permissions-policy.tentative.https.sub.html

Line 22, Patchset 5 (Latest): }, header + " dones't allow cross-origin iframes.");

Sanket Joshi . unresolved

```suggestion
    }, header + " doesn't allow cross-origin iframes.");
```

File third_party/blink/web_tests/http/tests/feature-policy/fullscreen-allowed-by-container-policy-relocate.html

Line 16, Patchset 5 (Latest): var allow = getAllowAttribute(iframe, 'fullscreen');

Sanket Joshi . unresolved

I would expect a `get` API to retrieve the attribute, whereas this is just returning true/false. Would a name like `hasAttributeWithValue` be more appropriate?

File third_party/blink/web_tests/http/tests/feature-policy/resources/helper.js

Line 11, Patchset 5 (Latest):

  if (!frame.hasAttribute('allow')) {
    return false;
  }
  return frame.getAttribute('allow').includes(feature);

Sanket Joshi . unresolved

```suggestion
  return frame.hasAttribute('allow') && frame.getAttribute('allow').includes(feature);
```

Open in Gerrit

Related details

Attention is currently required from:

Ian Clelland
Siye Liu

Submit Requirements:

Code-Coverage
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Siye Liu (Gerrit)

unread,

Oct 23, 2024, 2:02:33 PM10/23/24

to Sanket Joshi, Ian Clelland, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Luna Lu, feature-me...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org

Attention needed from Ian Clelland and Sanket Joshi

Siye Liu added 3 comments

File third_party/blink/web_tests/external/wpt/permissions-policy/experimental-features/focus-without-user-activation-default-permissions-policy.tentative.https.sub.html

Line 22, Patchset 5: }, header + " dones't allow cross-origin iframes.");

Sanket Joshi . resolved

```suggestion
    }, header + " doesn't allow cross-origin iframes.");
```

Siye Liu

Done

File third_party/blink/web_tests/http/tests/feature-policy/fullscreen-allowed-by-container-policy-relocate.html

Line 16, Patchset 5: var allow = getAllowAttribute(iframe, 'fullscreen');

Sanket Joshi . unresolved

I would expect a `get` API to retrieve the attribute, whereas this is just returning true/false. Would a name like `hasAttributeWithValue` be more appropriate?

Siye Liu

Renamed to `hasAllowAttributeWithValue`.

File third_party/blink/web_tests/http/tests/feature-policy/resources/helper.js

Line 11, Patchset 5: if (!frame.hasAttribute('allow')) {


    return false;
  }
  return frame.getAttribute('allow').includes(feature);

Sanket Joshi . resolved

```suggestion
  return frame.hasAttribute('allow') && frame.getAttribute('allow').includes(feature);
```

Siye Liu

Done

Open in Gerrit

Related details

Attention is currently required from:

Ian Clelland
Sanket Joshi

Submit Requirements:

Code-Coverage
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Siye Liu (Gerrit)

unread,

Oct 23, 2024, 2:03:16 PM10/23/24

to Sanket Joshi, Ian Clelland, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Luna Lu, feature-me...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org

Attention needed from Ian Clelland and Sanket Joshi

Siye Liu added 1 comment

File third_party/blink/web_tests/http/tests/feature-policy/fullscreen-allowed-by-container-policy-relocate.html

Line 16, Patchset 5: var allow = getAllowAttribute(iframe, 'fullscreen');

Sanket Joshi . resolved

I would expect a `get` API to retrieve the attribute, whereas this is just returning true/false. Would a name like `hasAttributeWithValue` be more appropriate?

Siye Liu

Renamed to `hasAllowAttributeWithValue`.

Siye Liu

Done

Open in Gerrit

Related details

Attention is currently required from:

Ian Clelland
Sanket Joshi

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Ian Clelland (Gerrit)

unread,

Oct 25, 2024, 11:16:52 AM10/25/24

to Siye Liu, Sanket Joshi, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Luna Lu, feature-me...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org

Attention needed from Sanket Joshi and Siye Liu

Ian Clelland voted and added 2 comments

Votes added by Ian Clelland

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Ian Clelland . resolved

This looks good, with one comment about the syntax used in the allow attributes

File third_party/blink/web_tests/external/wpt/focus/support/activeelement-after-calling-window-focus-middle.sub.html

Line 5, Patchset 6 (Latest):

<iframe allow="focus-without-user-activation *" src="https://{{hosts[][www]}}:{{ports[https][0]}}/focus/support/activeelement-after-calling-window-focus-inner.html"></iframe>

Ian Clelland . unresolved

The "*" shouldn't be necessary here unless you expect the framed content to redirect to a new origin. (Same comment for the other tests here)

Open in Gerrit

Related details

Attention is currently required from:

Sanket Joshi
Siye Liu

Submit Requirements:

Code-Coverage
Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Siye Liu (Gerrit)

unread,

Oct 28, 2024, 2:14:09 PM10/28/24

to Ian Clelland, Sanket Joshi, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Luna Lu, feature-me...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org

Attention needed from Sanket Joshi

Siye Liu voted and added 1 comment

Votes added by Siye Liu

Commit-Queue

+1

1 comment

File third_party/blink/web_tests/external/wpt/focus/support/activeelement-after-calling-window-focus-middle.sub.html

Line 5, Patchset 6:

<iframe allow="focus-without-user-activation *" src="https://{{hosts[][www]}}:{{ports[https][0]}}/focus/support/activeelement-after-calling-window-focus-inner.html"></iframe>

Ian Clelland . resolved

The "*" shouldn't be necessary here unless you expect the framed content to redirect to a new origin. (Same comment for the other tests here)

Siye Liu

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:

Sanket Joshi

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Blink W3C Test Autoroller (Gerrit)

unread,

Oct 28, 2024, 2:19:25 PM10/28/24

to Siye Liu, Ian Clelland, Sanket Joshi, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Luna Lu, feature-me...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org

Attention needed from Sanket Joshi

Message from Blink W3C Test Autoroller

Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/48842.

When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

Open in Gerrit

Related details

Attention is currently required from:

Sanket Joshi

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Siye Liu (Gerrit)

unread,

Oct 28, 2024, 4:12:08 PM10/28/24

to Blink W3C Test Autoroller, Ian Clelland, Sanket Joshi, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Luna Lu, feature-me...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org

Attention needed from Sanket Joshi

Siye Liu voted Commit-Queue+2

Commit-Queue

+2

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Oct 28, 2024, 5:05:42 PM10/28/24

to Siye Liu, Blink W3C Test Autoroller, Ian Clelland, Sanket Joshi, AyeAye, chromium...@chromium.org, Luna Lu, feature-me...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

6 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: third_party/blink/web_tests/http/tests/feature-policy/web-share.html
Insertions: 2, Deletions: 2.

@@ -2,8 +2,8 @@
 <script src="../../resources/testharness.js"></script>
 <script src="../../resources/testharnessreport.js"></script>
 <script src="resources/helper.js"></script>
-<iframe allow="focus-without-user-activation *"></iframe>
-<iframe allow="web-share; focus-without-user-activation *"></iframe>
+<iframe allow="focus-without-user-activation"></iframe>
+<iframe allow="web-share; focus-without-user-activation;"></iframe>
 <script>
 var srcs = [
   "resources/feature-policy-web-share.html",
```
```
The name of the file: third_party/blink/web_tests/http/tests/feature-policy/fullscreen-enabledforself.php
Insertions: 2, Deletions: 2.

@@ -14,8 +14,8 @@
 <script src="../../resources/testharness.js"></script>
 <script src="../../resources/testharnessreport.js"></script>
 <script src="resources/helper.js"></script>
-<iframe allow="focus-without-user-activation *"></iframe>
-<iframe allow="focus-without-user-activation *" allowfullscreen></iframe>
+<iframe allow="focus-without-user-activation"></iframe>
+<iframe allow="focus-without-user-activation" allowfullscreen></iframe>
 <script>
 var srcs = [
   "resources/feature-policy-fullscreen.html",
```
```
The name of the file: third_party/blink/web_tests/external/wpt/focus/support/iframe-contentwindow-focus-with-different-site-intermediate-frame-middle.sub.html
Insertions: 1, Deletions: 1.

@@ -1,7 +1,7 @@
 <!doctype html>
 <meta charset="utf-8">
 <title>iframe.contentWindow.focus() with different-site intermediate frame middle</title>
-<iframe allow="focus-without-user-activation *" src="http://{{hosts[][www]}}:{{ports[http][0]}}/focus/support/iframe-contentwindow-focus-with-different-site-intermediate-frame-inner.html"></iframe>
+<iframe allow="focus-without-user-activation" src="http://{{hosts[][www]}}:{{ports[http][0]}}/focus/support/iframe-contentwindow-focus-with-different-site-intermediate-frame-inner.html"></iframe>
 <script>
 let iframe = document.getElementsByTagName("iframe")[0];
 let log = "";
```
```
The name of the file: third_party/blink/web_tests/external/wpt/focus/support/iframe-contentwindow-focus-with-same-as-top-intermediate-frame-outer.html
Insertions: 1, Deletions: 1.

@@ -19,4 +19,4 @@
     }, 2000);
 }
 </script>
-<iframe allow="focus-without-user-activation *" src="iframe-contentwindow-focus-with-same-as-top-intermediate-frame-middle.sub.html"></iframe>
+<iframe allow="focus-without-user-activation" src="iframe-contentwindow-focus-with-same-as-top-intermediate-frame-middle.sub.html"></iframe>
```
```
The name of the file: third_party/blink/web_tests/external/wpt/focus/support/iframe-focus-with-different-site-intermediate-frame-outer.sub.html
Insertions: 1, Deletions: 1.

@@ -19,4 +19,4 @@
     }, 3000);
 }
 </script>
-<iframe allow="focus-without-user-activation *" src="http://{{hosts[alt][www]}}:{{ports[http][0]}}/focus/support/iframe-focus-with-different-site-intermediate-frame-middle.sub.html"></iframe>
+<iframe allow="focus-without-user-activation" src="http://{{hosts[alt][www]}}:{{ports[http][0]}}/focus/support/iframe-focus-with-different-site-intermediate-frame-middle.sub.html"></iframe>
```
```
The name of the file: third_party/blink/web_tests/external/wpt/focus/support/activeelement-after-calling-window-focus-outer-same.sub.html
Insertions: 1, Deletions: 1.

@@ -1,7 +1,7 @@
 <!doctype html>
 <meta charset="utf-8">
 <title>Focus test outer document</title>
-<iframe allow="focus-without-user-activation *" src="https://{{hosts[][www]}}:{{ports[https][0]}}/focus/support/activeelement-after-calling-window-focus-middle.sub.html"></iframe>
+<iframe allow="focus-without-user-activation" src="https://{{hosts[][www]}}:{{ports[https][0]}}/focus/support/activeelement-after-calling-window-focus-middle.sub.html"></iframe>
 <script>
 let outerlog = "outerlog:";
 
```
```
The name of the file: third_party/blink/web_tests/external/wpt/generic-sensor/generic-sensor-iframe-tests.sub.js
Insertions: 1, Deletions: 1.

@@ -96,7 +96,7 @@
 
     // Create cross-origin iframe and a sensor inside it.
     const iframe = document.createElement('iframe');
-    iframe.allow = featurePolicies.join(';') + '; focus-without-user-activation *;';
+    iframe.allow = featurePolicies.join(';') + '; focus-without-user-activation;';
     iframe.src =
         'https://{{domains[www1]}}:{{ports[https][0]}}/generic-sensor/resources/iframe_sensor_handler.html';
     const iframeLoadWatcher = new EventWatcher(t, iframe, 'load');
```
```
The name of the file: third_party/blink/web_tests/external/wpt/focus/support/activeelement-after-calling-window-focus-outer-different.sub.html
Insertions: 1, Deletions: 1.

@@ -1,7 +1,7 @@
 <!doctype html>
 <meta charset="utf-8">
 <title>Focus test outer document</title>
-<iframe allow="focus-without-user-activation *" src="https://{{hosts[alt][www]}}:{{ports[https][0]}}/focus/support/activeelement-after-calling-window-focus-middle.sub.html"></iframe>
+<iframe allow="focus-without-user-activation" src="https://{{hosts[alt][www]}}:{{ports[https][0]}}/focus/support/activeelement-after-calling-window-focus-middle.sub.html"></iframe>
 <script>
 let outerlog = "outerlog:";
 
```
```
The name of the file: third_party/blink/web_tests/http/tests/feature-policy/web-share-use-count.html
Insertions: 2, Deletions: 2.

@@ -2,8 +2,8 @@
 <script src="../../resources/testharness.js"></script>
 <script src="../../resources/testharnessreport.js"></script>
 <script src="resources/helper.js"></script>
-<iframe allow="focus-without-user-activation *"></iframe>
-<iframe allow="web-share; focus-without-user-activation *"></iframe>
+<iframe allow="focus-without-user-activation;"></iframe>
+<iframe allow="web-share; focus-without-user-activation;"></iframe>
 <script>
 var srcs = [
   "resources/feature-policy-web-share-use-count.html",
```
```
The name of the file: third_party/blink/web_tests/external/wpt/focus/support/iframe-contentwindow-focus-with-same-as-top-intermediate-frame-middle.sub.html
Insertions: 1, Deletions: 1.

@@ -1,7 +1,7 @@
 <!doctype html>
 <meta charset="utf-8">
 <title>iframe.contentWindow.focus() with same-as-top intermediate frame middle</title>
-<iframe allow="focus-without-user-activation *" src="http://{{hosts[alt][www]}}:{{ports[http][0]}}/focus/support/iframe-contentwindow-focus-with-same-as-top-intermediate-frame-inner.html"></iframe>
+<iframe allow="focus-without-user-activation" src="http://{{hosts[alt][www]}}:{{ports[http][0]}}/focus/support/iframe-contentwindow-focus-with-same-as-top-intermediate-frame-inner.html"></iframe>
 <script>
 let iframe = document.getElementsByTagName("iframe")[0];
 let log = "";
```
```
The name of the file: third_party/blink/web_tests/http/tests/feature-policy/fullscreen-enabledforall.php
Insertions: 2, Deletions: 2.

@@ -14,8 +14,8 @@
 <script src="../../resources/testharness.js"></script>
 <script src="../../resources/testharnessreport.js"></script>
 <script src="resources/helper.js"></script>
-<iframe allow="focus-without-user-activation *"></iframe>
-<iframe allow="focus-without-user-activation *" allowfullscreen></iframe>
+<iframe allow="focus-without-user-activation"></iframe>
+<iframe allow="focus-without-user-activation" allowfullscreen></iframe>
 <script>
 var srcs = [
   "resources/feature-policy-fullscreen.html",
```
```
The name of the file: third_party/blink/web_tests/external/wpt/focus/support/activeelement-after-calling-window-focus-middle.sub.html
Insertions: 1, Deletions: 1.

@@ -2,7 +2,7 @@
 <meta charset="utf-8">
 <title>Focus test middle document</title>
 <h1>Middle</h1><br>
-<iframe allow="focus-without-user-activation *" src="https://{{hosts[][www]}}:{{ports[https][0]}}/focus/support/activeelement-after-calling-window-focus-inner.html"></iframe>
+<iframe allow="focus-without-user-activation" src="https://{{hosts[][www]}}:{{ports[https][0]}}/focus/support/activeelement-after-calling-window-focus-inner.html"></iframe>
 <script>
 let middlelog = "middlelog:";
 
```
```
The name of the file: third_party/blink/web_tests/external/wpt/focus/support/activeelement-after-focusing-different-site-iframe-outer-contentwindow.sub.html
Insertions: 1, Deletions: 1.

@@ -26,4 +26,4 @@
     }, 1500);
 }
 </script>
-<iframe allow="focus-without-user-activation *" src="http://{{hosts[alt][www]}}:{{ports[http][0]}}/focus/support/activeelement-after-focusing-different-site-iframe-inner-contentwindow.html"></iframe>
+<iframe allow="focus-without-user-activation" src="http://{{hosts[alt][www]}}:{{ports[http][0]}}/focus/support/activeelement-after-focusing-different-site-iframe-inner-contentwindow.html"></iframe>
```
```
The name of the file: third_party/blink/web_tests/external/wpt/focus/support/iframe-contentwindow-focus-with-different-site-intermediate-frame-outer.sub.html
Insertions: 1, Deletions: 1.

@@ -19,4 +19,4 @@
     }, 3000);
 }
 </script>
-<iframe allow="focus-without-user-activation *" src="http://{{hosts[alt][www]}}:{{ports[http][0]}}/focus/support/iframe-contentwindow-focus-with-different-site-intermediate-frame-middle.sub.html"></iframe>
+<iframe allow="focus-without-user-activation" src="http://{{hosts[alt][www]}}:{{ports[http][0]}}/focus/support/iframe-contentwindow-focus-with-different-site-intermediate-frame-middle.sub.html"></iframe>
```

Change information

Commit message:

[Permissions Policy] update default for `focus-without-user-activation`

According to discussion[1] in webappsec WG and WHATWG, we should set
the default of `focus-without-user-activation` permissions policy to
`EnableForSelf`.

[1]: https://github.com/w3c/webappsec-permissions-policy/issues/273#issuecomment-2384287101

Bug: 371112534

Change-Id: I7deb757d0074e1262d07f768e58ea53a99d5faa5

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5950528

Reviewed-by: Sanket Joshi <sa...@microsoft.com>

Commit-Queue: Siye Liu <si...@microsoft.com>

Reviewed-by: Ian Clelland <icle...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1374868}

Files:

M third_party/blink/renderer/core/permissions_policy/permissions_policy_features.json5
M third_party/blink/web_tests/external/wpt/focus/support/activeelement-after-calling-window-focus-middle.sub.html
M third_party/blink/web_tests/external/wpt/focus/support/activeelement-after-calling-window-focus-outer-different.sub.html
M third_party/blink/web_tests/external/wpt/focus/support/activeelement-after-calling-window-focus-outer-same.sub.html
M third_party/blink/web_tests/external/wpt/focus/support/activeelement-after-focusing-different-site-iframe-outer-contentwindow.sub.html
M third_party/blink/web_tests/external/wpt/focus/support/iframe-contentwindow-focus-with-different-site-intermediate-frame-middle.sub.html
M third_party/blink/web_tests/external/wpt/focus/support/iframe-contentwindow-focus-with-different-site-intermediate-frame-outer.sub.html
M third_party/blink/web_tests/external/wpt/focus/support/iframe-contentwindow-focus-with-same-as-top-intermediate-frame-middle.sub.html
M third_party/blink/web_tests/external/wpt/focus/support/iframe-contentwindow-focus-with-same-as-top-intermediate-frame-outer.html
M third_party/blink/web_tests/external/wpt/focus/support/iframe-focus-with-different-site-intermediate-frame-outer.sub.html
M third_party/blink/web_tests/external/wpt/generic-sensor/generic-sensor-iframe-tests.sub.js
A third_party/blink/web_tests/external/wpt/permissions-policy/experimental-features/focus-without-user-activation-default-permissions-policy.tentative.https.sub.html
A third_party/blink/web_tests/external/wpt/permissions-policy/experimental-features/resources/permissions-policy-focus-without-user-activation.html
M third_party/blink/web_tests/http/tests/feature-policy/fullscreen-allowed-by-container-policy-relocate.html
M third_party/blink/web_tests/http/tests/feature-policy/fullscreen-enabledforall.php
M third_party/blink/web_tests/http/tests/feature-policy/fullscreen-enabledforself.php
M third_party/blink/web_tests/http/tests/feature-policy/resources/helper.js
M third_party/blink/web_tests/http/tests/feature-policy/web-share-use-count.html
M third_party/blink/web_tests/http/tests/feature-policy/web-share.html

Change size: M

Delta: 19 files changed, 64 insertions(+), 25 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Sanket Joshi, +1 by Ian Clelland

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Blink W3C Test Autoroller (Gerrit)

unread,

Oct 28, 2024, 5:46:56 PM10/28/24

to Chromium LUCI CQ, Siye Liu, Ian Clelland, Sanket Joshi, AyeAye, chromium...@chromium.org, Luna Lu, feature-me...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org

Message from Blink W3C Test Autoroller

The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/48842

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[Permissions Policy] update default for `focus-without-user-activation` [chromium/src : main]

Siye Liu (Gerrit)

Siye Liu added 1 comment

Related details

Sanket Joshi (Gerrit)

Sanket Joshi voted and added 4 comments

Votes added by Sanket Joshi

4 comments

Related details

Siye Liu (Gerrit)

Siye Liu added 3 comments

Related details

Siye Liu (Gerrit)

Siye Liu added 1 comment

Related details

Ian Clelland (Gerrit)

Ian Clelland voted and added 2 comments

Votes added by Ian Clelland

2 comments

Related details

Siye Liu (Gerrit)

Siye Liu voted and added 1 comment

Votes added by Siye Liu

1 comment

Related details

Blink W3C Test Autoroller (Gerrit)

Message from Blink W3C Test Autoroller

Related details

Siye Liu (Gerrit)

Siye Liu voted Commit-Queue+2

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information

Blink W3C Test Autoroller (Gerrit)

Message from Blink W3C Test Autoroller

Related details