Rename expect-no-embedded-resources Document-Policy to the new name [chromium/src : refs/branch-heads/6723]
5 views
Skip to first unread message
Alex N. Jose (Gerrit)
Sep 18, 2024, 10:29:33 PM9/18/24
to Kouhei Ueno, Kyra Seevers, Luna Lu, Chromium Metrics Reviews, AyeAye, blink-...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, blink-rev...@chromium.org, loading-rev...@chromium.org
Attention needed from Kouhei Ueno
Alex N. Jose added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Alex N. Jose . resolved
kouhei@, could I get your +1 on this cherry-pick?
Related details
Attention is currently required from:
- Kouhei Ueno
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex N. Jose (Gerrit)
Sep 18, 2024, 10:31:12 PM9/18/24
to Chromium IPC Reviews, Rubber Stamper, Kouhei Ueno, Kyra Seevers, Luna Lu, Chromium Metrics Reviews, AyeAye, blink-...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, blink-rev...@chromium.org, loading-rev...@chromium.org
Attention needed from Chromium IPC Reviews and Kouhei Ueno
Alex N. Jose added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Alex N. Jose . resolved
Attention is currently required from:
- Chromium IPC Reviews
- Kouhei Ueno
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
Sep 18, 2024, 10:32:17 PM9/18/24
to Alex N. Jose, Chromium IPC Reviews, Kouhei Ueno, Kyra Seevers, Luna Lu, Chromium Metrics Reviews, AyeAye, blink-...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, blink-rev...@chromium.org, loading-rev...@chromium.org
Attention needed from Chromium IPC Reviews and Kouhei Ueno
Rubber Stamper voted Bot-Commit+1![]( "Open in Gerrit")
| Bot-Commit | +1 |
Related details
Attention is currently required from:
- Chromium IPC Reviews
- Kouhei Ueno
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex N. Jose (Gerrit)
Sep 18, 2024, 10:32:34 PM9/18/24
to Koji Ishii, Rubber Stamper, Chromium IPC Reviews, Kouhei Ueno, Kyra Seevers, Luna Lu, Chromium Metrics Reviews, AyeAye, blink-...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, blink-rev...@chromium.org, loading-rev...@chromium.org
Attention needed from Chromium IPC Reviews, Koji Ishii and Kouhei Ueno
Alex N. Jose added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Alex N. Jose . resolved
kojii@, could I get your review of the VirtualTestSuite change in this cherry-pick CL?
Related details
Attention is currently required from:
- Chromium IPC Reviews
- Koji Ishii
- Kouhei Ueno
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Sep 18, 2024, 10:34:39 PM9/18/24
to Alex N. Jose, Chromium IPC Reviews, Will Harris, Chromium LUCI CQ, Koji Ishii, Rubber Stamper, Kouhei Ueno, Kyra Seevers, Luna Lu, Chromium Metrics Reviews, AyeAye, blink-...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, blink-rev...@chromium.org, loading-rev...@chromium.org
Attention needed from Koji Ishii, Kouhei Ueno and Will Harris
Message from gwsq![]( "Open in Gerrit")
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: w...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): w...@chromium.org
Reviewer source(s):
w...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Related details
Attention is currently required from:
- Koji Ishii
- Kouhei Ueno
- Will Harris
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Will Harris (Gerrit)
Sep 18, 2024, 10:39:15 PM9/18/24
to Alex N. Jose, Will Harris, Chromium IPC Reviews, Chromium LUCI CQ, Koji Ishii, Rubber Stamper, Kouhei Ueno, Kyra Seevers, Luna Lu, Chromium Metrics Reviews, AyeAye, blink-...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, blink-rev...@chromium.org, loading-rev...@chromium.org
Attention needed from Alex N. Jose, Koji Ishii and Kouhei Ueno
Will Harris voted and added 1 comment![]( "Open in Gerrit")
Votes added by Will Harris
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Alex N. Jose
- Koji Ishii
- Kouhei Ueno
Koji Ishii (Gerrit)
Sep 18, 2024, 11:14:11 PM9/18/24
to Alex N. Jose, Will Harris, Chromium IPC Reviews, Chromium LUCI CQ, Rubber Stamper, Kouhei Ueno, Kyra Seevers, Luna Lu, Chromium Metrics Reviews, AyeAye, blink-...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, blink-rev...@chromium.org, loading-rev...@chromium.org
Attention needed from Alex N. Jose and Kouhei Ueno
Koji Ishii voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alex N. Jose
- Kouhei Ueno
Kouhei Ueno (Gerrit)
Sep 19, 2024, 12:09:22 AM9/19/24
to Alex N. Jose, Koji Ishii, Will Harris, Chromium IPC Reviews, Chromium LUCI CQ, Rubber Stamper, Kyra Seevers, Luna Lu, Chromium Metrics Reviews, AyeAye, blink-...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, blink-rev...@chromium.org, loading-rev...@chromium.org
Attention needed from Alex N. Jose
Kouhei Ueno voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Alex N. Jose
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex N. Jose (Gerrit)
Sep 19, 2024, 12:35:58 AM9/19/24
to Kouhei Ueno, Koji Ishii, Will Harris, Chromium IPC Reviews, Chromium LUCI CQ, Rubber Stamper, Kyra Seevers, Luna Lu, Chromium Metrics Reviews, AyeAye, blink-...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, blink-rev...@chromium.org, loading-rev...@chromium.org
Alex N. Jose voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 19, 2024, 12:42:37 AM9/19/24
to Alex N. Jose, Kouhei Ueno, Koji Ishii, Will Harris, Chromium IPC Reviews, Rubber Stamper, Kyra Seevers, Luna Lu, Chromium Metrics Reviews, AyeAye, blink-...@chromium.org, asvitkine...@chromium.org, jmedle...@chromium.org, blink-re...@chromium.org, kinuko...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, blink-rev...@chromium.org, loading-rev...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Rename expect-no-embedded-resources Document-Policy to the new name
The implementation of this policy lags behind the proposal name change.
This CL renames the Document-Policy: expect-no-embedded-resources
to expect-no-linked-resources to reflect the revised policy name.
https://chromestatus.com/feature/5202800863346688
(cherry picked from commit 19135e3a0428e22dcb1d480c96bdc3cb8c01e737)
Bug: 365632977
Change-Id: Ib47c8dfd6c9cd4a3c5770b91f0e69ac4679e542d
Reviewed-by: David Baron <dba...@chromium.org>
Commit-Queue: Alex N. Jose <ale...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Reviewed-by: Ian Clelland <icle...@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1356853}
Reviewed-by: Kouhei Ueno <kou...@chromium.org>
Reviewed-by: Will Harris <w...@chromium.org>
Reviewed-by: Koji Ishii <ko...@chromium.org>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6723@{#101}
Cr-Branched-From: 985f2961df230630f9cbd75bd6fe463009855a11-refs/heads/main@{#1356013}
Files:
- M third_party/blink/public/mojom/permissions_policy/document_policy_feature.mojom
- M third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
- M third_party/blink/renderer/core/html/parser/html_document_parser.cc
- M third_party/blink/renderer/core/permissions_policy/document_policy_features.json5
- M third_party/blink/renderer/platform/runtime_enabled_features.json5
- M third_party/blink/web_tests/VirtualTestSuites
- D third_party/blink/web_tests/http/tests/expect-no-embedded-resources/no-preloadscanning-when-no-resources.php
- A third_party/blink/web_tests/http/tests/expect-no-linked-resources/no-preloadscanning-when-no-resources.php
- D third_party/blink/web_tests/virtual/expect-no-embedded-resources/README.md
- A third_party/blink/web_tests/virtual/expect-no-linked-resources/README.md
- M tools/metrics/histograms/enums.xml
Change size: M
Delta: 11 files changed, 40 insertions(+), 39 deletions(-)
Branch: refs/branch-heads/6723
Submit Requirements:
Code-Review: +1 by Will Harris, +1 by Kouhei Ueno, +1 by Koji Ishii, Bot-Commit+1 by Rubber Stamper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages