Private State Token API Permissions Policy Default Allowlist Wildcard [chromium/src : main]
1 view
Skip to first unread message
Ari Chivukula (Gerrit)
Sep 9, 2024, 9:43:08 AM9/9/24
to Steven Valdez, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Luna Lu, blink-revie...@chromium.org, blink-...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org
Attention needed from Steven Valdez
Ari Chivukula voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ari Chivukula
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Ari Chivukula . resolved
Waiting on blink-dev LGTMs before commit, just putting this up for review now in case there's something I missed
Related details
Attention is currently required from:
- Steven Valdez
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Steven Valdez (Gerrit)
Sep 9, 2024, 10:02:31 AM9/9/24
to Ari Chivukula, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Luna Lu, blink-revie...@chromium.org, blink-...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org
Attention needed from Ari Chivukula
Steven Valdez voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Ari Chivukula
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Sep 9, 2024, 10:28:05 AM9/9/24
to Ari Chivukula, Steven Valdez, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Luna Lu, blink-revie...@chromium.org, blink-...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org
Attention needed from Ari Chivukula
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/48045.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention is currently required from:
- Ari Chivukula
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ari Chivukula (Gerrit)
Nov 7, 2024, 3:54:04 PM11/7/24
to Blink W3C Test Autoroller, Steven Valdez, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Luna Lu, blink-revie...@chromium.org, blink-...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org
Ari Chivukula voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 7, 2024, 6:12:38 PM11/7/24
to Ari Chivukula, Blink W3C Test Autoroller, Steven Valdez, AyeAye, chromium...@chromium.org, Luna Lu, blink-revie...@chromium.org, blink-...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Private State Token API Permissions Policy Default Allowlist Wildcard
Access to the Private State Token API is gated by Permissions Policy
features. We proposed to update the default allowlist for both
`private-state-token-issuance` and `private-state-token-redemption`
features from self to * (wildcard).
https://chromestatus.com/feature/5078049450098688
https://groups.google.com/a/chromium.org/g/blink-dev/c/5jI8kLLdIFw
Commit: false
Bug: 353738486
Change-Id: I20cba9232d3b6ac874c7c91b254a66573d60578b
Commit-Queue: Ari Chivukula <ari...@chromium.org>
Reviewed-by: Steven Valdez <sva...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1380010}
Files:
- M content/browser/network/trust_token_parameters_browsertest.cc
- M content/test/data/cross_site_iframe_factory.html
- M third_party/blink/renderer/core/permissions_policy/permissions_policy_features.json5
- M third_party/blink/web_tests/external/wpt/permissions-policy/experimental-features/private-state-token-redemption-default-permissions-policy.tentative.https.sub.html
- M third_party/blink/web_tests/external/wpt/permissions-policy/private-state-token-issue-enabled-by-permissions-policy.tentative.https.sub.html
Change size: L
Delta: 5 files changed, 168 insertions(+), 155 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Steven Valdez
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Nov 7, 2024, 6:52:05 PM11/7/24
to Ari Chivukula, Chromium LUCI CQ, Steven Valdez, AyeAye, chromium...@chromium.org, Luna Lu, blink-revie...@chromium.org, blink-...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/48045
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages