controlledframe: Add permissions policy [chromium/src : main]

4 views
Skip to first unread message

Chase Phillips (Gerrit)

unread,
Aug 26, 2024, 9:10:11 PM8/26/24
to Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, devtools-re...@chromium.org, extension...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Chase Phillips voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib83ac83fd466629623bec37c64c93c28656758e1
Gerrit-Change-Number: 5814831
Gerrit-PatchSet: 1
Gerrit-Owner: Chase Phillips <c...@chromium.org>
Gerrit-Reviewer: Chase Phillips <c...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Luna Lu <loon...@chromium.org>
Gerrit-Comment-Date: Tue, 27 Aug 2024 01:10:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Chase Phillips (Gerrit)

unread,
Aug 26, 2024, 11:59:11 PM8/26/24
to Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, devtools-re...@chromium.org, extension...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Chase Phillips voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib83ac83fd466629623bec37c64c93c28656758e1
Gerrit-Change-Number: 5814831
Gerrit-PatchSet: 2
Gerrit-Owner: Chase Phillips <c...@chromium.org>
Gerrit-Reviewer: Chase Phillips <c...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Luna Lu <loon...@chromium.org>
Gerrit-Comment-Date: Tue, 27 Aug 2024 03:59:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Chase Phillips (Gerrit)

unread,
Aug 27, 2024, 3:03:34 PM8/27/24
to Andrew Rayskiy, Simon Hangl, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, mgiuca...@chromium.org, alancutter...@chromium.org, rmcelra...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, zelin+watch-we...@chromium.org, dibyapal+wa...@chromium.org, ericwillige...@chromium.org, webap...@microsoft.com, dominickn+watch-...@chromium.org, loyso...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, devtools-re...@chromium.org, extension...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Chase Phillips voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib83ac83fd466629623bec37c64c93c28656758e1
Gerrit-Change-Number: 5814831
Gerrit-PatchSet: 3
Gerrit-Owner: Chase Phillips <c...@chromium.org>
Gerrit-Reviewer: Chase Phillips <c...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Luna Lu <loon...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Comment-Date: Tue, 27 Aug 2024 19:03:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Chase Phillips (Gerrit)

unread,
Aug 27, 2024, 6:28:16 PM8/27/24
to Andrew Rayskiy, Simon Hangl, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, blink-revi...@chromium.org, mgiuca...@chromium.org, alancutter...@chromium.org, rmcelra...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, zelin+watch-we...@chromium.org, dibyapal+wa...@chromium.org, ericwillige...@chromium.org, webap...@microsoft.com, dominickn+watch-...@chromium.org, loyso...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, devtools-re...@chromium.org, extension...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Chase Phillips voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib83ac83fd466629623bec37c64c93c28656758e1
Gerrit-Change-Number: 5814831
Gerrit-PatchSet: 4
Gerrit-Owner: Chase Phillips <c...@chromium.org>
Gerrit-Reviewer: Chase Phillips <c...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Luna Lu <loon...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Comment-Date: Tue, 27 Aug 2024 22:28:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Chase Phillips (Gerrit)

unread,
Aug 30, 2024, 3:03:46 AM8/30/24
to Andrew Rayskiy, Simon Hangl, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, blink-revi...@chromium.org, mgiuca...@chromium.org, alancutter...@chromium.org, rmcelra...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, zelin+watch-we...@chromium.org, dibyapal+wa...@chromium.org, ericwillige...@chromium.org, webap...@microsoft.com, dominickn+watch-...@chromium.org, loyso...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, devtools-re...@chromium.org, extension...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Chase Phillips voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib83ac83fd466629623bec37c64c93c28656758e1
Gerrit-Change-Number: 5814831
Gerrit-PatchSet: 7
Gerrit-Owner: Chase Phillips <c...@chromium.org>
Gerrit-Reviewer: Chase Phillips <c...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Luna Lu <loon...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Comment-Date: Fri, 30 Aug 2024 07:03:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Chase Phillips (Gerrit)

unread,
Aug 30, 2024, 4:26:52 PM8/30/24
to Andrew Rayskiy, Simon Hangl, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, blink-revie...@chromium.org, blink-revi...@chromium.org, mgiuca...@chromium.org, alancutter...@chromium.org, rmcelra...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, zelin+watch-we...@chromium.org, dibyapal+wa...@chromium.org, ericwillige...@chromium.org, webap...@microsoft.com, dominickn+watch-...@chromium.org, loyso...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, devtools-re...@chromium.org, extension...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Chase Phillips voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib83ac83fd466629623bec37c64c93c28656758e1
Gerrit-Change-Number: 5814831
Gerrit-PatchSet: 8
Gerrit-Owner: Chase Phillips <c...@chromium.org>
Gerrit-Reviewer: Chase Phillips <c...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Luna Lu <loon...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Comment-Date: Fri, 30 Aug 2024 20:26:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Chase Phillips (Gerrit)

unread,
Aug 30, 2024, 5:39:54 PM8/30/24
to Andrew Rayskiy, Simon Hangl, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, blink-revie...@chromium.org, blink-revi...@chromium.org, mgiuca...@chromium.org, alancutter...@chromium.org, rmcelra...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, zelin+watch-we...@chromium.org, dibyapal+wa...@chromium.org, ericwillige...@chromium.org, webap...@microsoft.com, dominickn+watch-...@chromium.org, loyso...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, devtools-re...@chromium.org, extension...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Chase Phillips voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib83ac83fd466629623bec37c64c93c28656758e1
Gerrit-Change-Number: 5814831
Gerrit-PatchSet: 10
Gerrit-Owner: Chase Phillips <c...@chromium.org>
Gerrit-Reviewer: Chase Phillips <c...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Luna Lu <loon...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Comment-Date: Fri, 30 Aug 2024 21:39:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Chase Phillips (Gerrit)

unread,
Aug 30, 2024, 6:02:07 PM8/30/24
to Philip Rogers, Tom Sepez, David Bertoni, Robbie McElrath, Zelin Liu, Andrew Rayskiy, Simon Hangl, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, blink-revie...@chromium.org, blink-revi...@chromium.org, mgiuca...@chromium.org, alancutter...@chromium.org, rmcelra...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, zelin+watch-we...@chromium.org, dibyapal+wa...@chromium.org, ericwillige...@chromium.org, webap...@microsoft.com, dominickn+watch-...@chromium.org, loyso...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, devtools-re...@chromium.org, extension...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from David Bertoni, Philip Rogers and Tom Sepez

Chase Phillips voted and added 1 comment

Votes added by Chase Phillips

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 12 (Latest):
Chase Phillips . resolved

Hi Philip, Tom, and Dave, can you please review the relevant parts of this CL to add a Controlled Frame permissions policy and the relevant checks for that policy? Thank you.

pdr:
  third_party/blink/public/devtools_protocol/browser_protocol.pdl
  third_party/blink/public/web/web_local_frame.h
  third_party/blink/renderer/core/frame/web_local_frame_impl.cc
  third_party/blink/renderer/core/frame/web_local_frame_impl.h
  third_party/blink/renderer/core/permissions_policy/permissions_policy_features.json5
  third_party/blink/renderer/core/permissions_policy/permissions_policy_test.cc
  third_party/blink/web_tests/VirtualTestSuites
tsepez:
  third_party/blink/public/mojom/permissions_policy/permissions_policy_feature.mojom
dbertoni:
  extensions/browser/browser_frame_context_data.cc
  extensions/browser/browser_frame_context_data.h
  extensions/browser/browser_process_context_data.cc
  extensions/browser/browser_process_context_data.h
  extensions/common/context_data.h
  extensions/renderer/DEPS
  extensions/renderer/renderer_context_data.cc
  extensions/renderer/renderer_context_data.h
  extensions/renderer/renderer_frame_context_data.cc
  extensions/renderer/renderer_frame_context_data.h
  extensions/renderer/script_context_set.cc
  extensions/test/test_context_data.cc
  extensions/test/test_context_data.h
Open in Gerrit

Related details

Attention is currently required from:
  • David Bertoni
  • Philip Rogers
  • Tom Sepez
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib83ac83fd466629623bec37c64c93c28656758e1
Gerrit-Change-Number: 5814831
Gerrit-PatchSet: 12
Gerrit-Owner: Chase Phillips <c...@chromium.org>
Gerrit-Reviewer: Chase Phillips <c...@chromium.org>
Gerrit-Reviewer: David Bertoni <dber...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Luna Lu <loon...@chromium.org>
Gerrit-CC: Robbie McElrath <rmce...@chromium.org>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Zelin Liu <ze...@chromium.org>
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Philip Rogers <p...@chromium.org>
Gerrit-Attention: David Bertoni <dber...@chromium.org>
Gerrit-Comment-Date: Fri, 30 Aug 2024 22:01:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Philip Rogers (Gerrit)

unread,
Aug 30, 2024, 7:01:21 PM8/30/24
to Chase Phillips, Tom Sepez, David Bertoni, Robbie McElrath, Zelin Liu, Andrew Rayskiy, Simon Hangl, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, blink-revie...@chromium.org, blink-revi...@chromium.org, mgiuca...@chromium.org, alancutter...@chromium.org, rmcelra...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, zelin+watch-we...@chromium.org, dibyapal+wa...@chromium.org, ericwillige...@chromium.org, webap...@microsoft.com, dominickn+watch-...@chromium.org, loyso...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, devtools-re...@chromium.org, extension...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Chase Phillips, David Bertoni and Tom Sepez

Philip Rogers added 1 comment

File third_party/blink/web_tests/external/wpt/resources/feature-policy-features-listing.js
Line 1, Patchset 12 (Latest):// * |platformSpecific| determines the platform-filtering of features. Only
Philip Rogers . unresolved

It seems wrong to have this in external/wpt if it is only used by wpt_internal tests. Should this be under wpt_internal/?

Open in Gerrit

Related details

Attention is currently required from:
  • Chase Phillips
  • David Bertoni
  • Tom Sepez
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib83ac83fd466629623bec37c64c93c28656758e1
    Gerrit-Change-Number: 5814831
    Gerrit-PatchSet: 12
    Gerrit-Owner: Chase Phillips <c...@chromium.org>
    Gerrit-Reviewer: Chase Phillips <c...@chromium.org>
    Gerrit-Reviewer: David Bertoni <dber...@chromium.org>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Luna Lu <loon...@chromium.org>
    Gerrit-CC: Robbie McElrath <rmce...@chromium.org>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: Zelin Liu <ze...@chromium.org>
    Gerrit-Attention: Tom Sepez <tse...@chromium.org>
    Gerrit-Attention: David Bertoni <dber...@chromium.org>
    Gerrit-Attention: Chase Phillips <c...@chromium.org>
    Gerrit-Comment-Date: Fri, 30 Aug 2024 23:01:09 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Chase Phillips (Gerrit)

    unread,
    Aug 30, 2024, 7:31:21 PM8/30/24
    to Philip Rogers, Tom Sepez, David Bertoni, Robbie McElrath, Zelin Liu, Andrew Rayskiy, Simon Hangl, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, blink-revie...@chromium.org, blink-revi...@chromium.org, mgiuca...@chromium.org, alancutter...@chromium.org, rmcelra...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, zelin+watch-we...@chromium.org, dibyapal+wa...@chromium.org, ericwillige...@chromium.org, webap...@microsoft.com, dominickn+watch-...@chromium.org, loyso...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, devtools-re...@chromium.org, extension...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
    Attention needed from David Bertoni, Philip Rogers and Tom Sepez

    Chase Phillips added 1 comment

    File third_party/blink/web_tests/external/wpt/resources/feature-policy-features-listing.js
    Line 1, Patchset 12:// * |platformSpecific| determines the platform-filtering of features. Only
    Philip Rogers . resolved

    It seems wrong to have this in external/wpt if it is only used by wpt_internal tests. Should this be under wpt_internal/?

    Chase Phillips

    I wasn't sure where to put this file. I've moved it into the same directory as the wpt_internal test.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • David Bertoni
    • Philip Rogers
    • Tom Sepez
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib83ac83fd466629623bec37c64c93c28656758e1
    Gerrit-Change-Number: 5814831
    Gerrit-PatchSet: 13
    Gerrit-Owner: Chase Phillips <c...@chromium.org>
    Gerrit-Reviewer: Chase Phillips <c...@chromium.org>
    Gerrit-Reviewer: David Bertoni <dber...@chromium.org>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Luna Lu <loon...@chromium.org>
    Gerrit-CC: Robbie McElrath <rmce...@chromium.org>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: Zelin Liu <ze...@chromium.org>
    Gerrit-Attention: Tom Sepez <tse...@chromium.org>
    Gerrit-Attention: Philip Rogers <p...@chromium.org>
    Gerrit-Attention: David Bertoni <dber...@chromium.org>
    Gerrit-Comment-Date: Fri, 30 Aug 2024 23:31:08 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Philip Rogers <p...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Chase Phillips (Gerrit)

    unread,
    Aug 30, 2024, 7:31:31 PM8/30/24
    to Philip Rogers, Tom Sepez, David Bertoni, Robbie McElrath, Zelin Liu, Andrew Rayskiy, Simon Hangl, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, blink-revie...@chromium.org, blink-revi...@chromium.org, mgiuca...@chromium.org, alancutter...@chromium.org, rmcelra...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, zelin+watch-we...@chromium.org, dibyapal+wa...@chromium.org, ericwillige...@chromium.org, webap...@microsoft.com, dominickn+watch-...@chromium.org, loyso...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, devtools-re...@chromium.org, extension...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
    Attention needed from David Bertoni, Philip Rogers and Tom Sepez

    Chase Phillips voted Commit-Queue+1

    Commit-Queue+1
    Gerrit-Comment-Date: Fri, 30 Aug 2024 23:31:12 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Philip Rogers (Gerrit)

    unread,
    Aug 30, 2024, 7:43:20 PM8/30/24
    to Chase Phillips, Tom Sepez, David Bertoni, Robbie McElrath, Zelin Liu, Andrew Rayskiy, Simon Hangl, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, blink-revie...@chromium.org, blink-revi...@chromium.org, mgiuca...@chromium.org, alancutter...@chromium.org, rmcelra...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, zelin+watch-we...@chromium.org, dibyapal+wa...@chromium.org, ericwillige...@chromium.org, webap...@microsoft.com, dominickn+watch-...@chromium.org, loyso...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, devtools-re...@chromium.org, extension...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
    Attention needed from Chase Phillips, David Bertoni and Tom Sepez

    Philip Rogers voted and added 1 comment

    Votes added by Philip Rogers

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 13 (Latest):
    Philip Rogers . resolved

    LGTM

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Chase Phillips
    • David Bertoni
    • Tom Sepez
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib83ac83fd466629623bec37c64c93c28656758e1
    Gerrit-Change-Number: 5814831
    Gerrit-PatchSet: 13
    Gerrit-Owner: Chase Phillips <c...@chromium.org>
    Gerrit-Reviewer: Chase Phillips <c...@chromium.org>
    Gerrit-Reviewer: David Bertoni <dber...@chromium.org>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Luna Lu <loon...@chromium.org>
    Gerrit-CC: Robbie McElrath <rmce...@chromium.org>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: Zelin Liu <ze...@chromium.org>
    Gerrit-Attention: Tom Sepez <tse...@chromium.org>
    Gerrit-Attention: David Bertoni <dber...@chromium.org>
    Gerrit-Attention: Chase Phillips <c...@chromium.org>
    Gerrit-Comment-Date: Fri, 30 Aug 2024 23:43:08 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Tom Sepez (Gerrit)

    unread,
    Aug 30, 2024, 7:48:16 PM8/30/24
    to Chase Phillips, Philip Rogers, David Bertoni, Robbie McElrath, Zelin Liu, Andrew Rayskiy, Simon Hangl, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, blink-revie...@chromium.org, blink-revi...@chromium.org, mgiuca...@chromium.org, alancutter...@chromium.org, rmcelra...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, zelin+watch-we...@chromium.org, dibyapal+wa...@chromium.org, ericwillige...@chromium.org, webap...@microsoft.com, dominickn+watch-...@chromium.org, loyso...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, devtools-re...@chromium.org, extension...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
    Attention needed from Chase Phillips and David Bertoni

    Tom Sepez voted and added 1 comment

    Votes added by Tom Sepez

    Code-Review+1

    1 comment

    Patchset-level comments
    Tom Sepez . resolved

    mojom LG

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Chase Phillips
    • David Bertoni
    Gerrit-Attention: David Bertoni <dber...@chromium.org>
    Gerrit-Attention: Chase Phillips <c...@chromium.org>
    Gerrit-Comment-Date: Fri, 30 Aug 2024 23:48:07 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Robbie McElrath (Gerrit)

    unread,
    Aug 31, 2024, 12:18:06 AM8/31/24
    to Chase Phillips, Tom Sepez, Philip Rogers, David Bertoni, Zelin Liu, Andrew Rayskiy, Simon Hangl, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, blink-revie...@chromium.org, blink-revi...@chromium.org, mgiuca...@chromium.org, alancutter...@chromium.org, rmcelra...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, zelin+watch-we...@chromium.org, dibyapal+wa...@chromium.org, ericwillige...@chromium.org, webap...@microsoft.com, dominickn+watch-...@chromium.org, loyso...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, devtools-re...@chromium.org, extension...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
    Attention needed from Chase Phillips and David Bertoni

    Robbie McElrath added 1 comment

    File chrome/browser/web_applications/isolated_web_apps/test/isolated_web_app_builder.cc
    Line 284, Patchset 13 (Latest): AddPermissionsPolicy(blink::mojom::PermissionsPolicyFeature::kControlledFrame,
    Robbie McElrath . unresolved

    Can you add this in the tests that need it instead of including it globally? cross-origin-isolated is only added because literally everything needs it.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Chase Phillips
    • David Bertoni
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      Gerrit-Comment-Date: Sat, 31 Aug 2024 04:17:56 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      David Bertoni (Gerrit)

      unread,
      Sep 3, 2024, 1:57:34 PM9/3/24
      to Chase Phillips, Tom Sepez, Philip Rogers, Robbie McElrath, Zelin Liu, Andrew Rayskiy, Simon Hangl, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, blink-revie...@chromium.org, blink-revi...@chromium.org, mgiuca...@chromium.org, alancutter...@chromium.org, rmcelra...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, zelin+watch-we...@chromium.org, dibyapal+wa...@chromium.org, ericwillige...@chromium.org, webap...@microsoft.com, dominickn+watch-...@chromium.org, loyso...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, devtools-re...@chromium.org, extension...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
      Attention needed from Chase Phillips

      David Bertoni voted and added 2 comments

      Votes added by David Bertoni

      Code-Review+1

      2 comments

      Patchset-level comments
      David Bertoni . resolved

      lgtm for extensions/*. Thanks!

      File extensions/renderer/renderer_frame_context_data.cc
      Line 29, Patchset 13 (Latest): CHECK(frame_);
      David Bertoni . unresolved

      Given the comment on line 22, can you verify this won't be tripped in tests?

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Chase Phillips
      Gerrit-Attention: Chase Phillips <c...@chromium.org>
      Gerrit-Comment-Date: Tue, 03 Sep 2024 17:57:21 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Chase Phillips (Gerrit)

      unread,
      Sep 3, 2024, 4:12:42 PM9/3/24
      to David Bertoni, Tom Sepez, Philip Rogers, Robbie McElrath, Zelin Liu, Andrew Rayskiy, Simon Hangl, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, blink-revie...@chromium.org, blink-revi...@chromium.org, mgiuca...@chromium.org, alancutter...@chromium.org, rmcelra...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, zelin+watch-we...@chromium.org, dibyapal+wa...@chromium.org, ericwillige...@chromium.org, webap...@microsoft.com, dominickn+watch-...@chromium.org, loyso...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, devtools-re...@chromium.org, extension...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
      Attention needed from David Bertoni, Philip Rogers, Robbie McElrath and Tom Sepez

      Chase Phillips voted and added 3 comments

      Votes added by Chase Phillips

      Commit-Queue+1

      3 comments

      Patchset-level comments
      File-level comment, Patchset 14 (Latest):
      Chase Phillips . resolved

      Thanks for reviews! I addressed the comment from Robbie in the latest patchset.

      I'm looking into why the latest WPT test failure happened. That shouldn't happen so I'll investigate that.

      File chrome/browser/web_applications/isolated_web_apps/test/isolated_web_app_builder.cc
      Line 284, Patchset 13: AddPermissionsPolicy(blink::mojom::PermissionsPolicyFeature::kControlledFrame,
      Robbie McElrath . resolved

      Can you add this in the tests that need it instead of including it globally? cross-origin-isolated is only added because literally everything needs it.

      Chase Phillips

      Okay, I moved this line to a more appropriate base class.

      File extensions/renderer/renderer_frame_context_data.cc
      Line 29, Patchset 13: CHECK(frame_);
      David Bertoni . resolved

      Given the comment on line 22, can you verify this won't be tripped in tests?

      Chase Phillips

      Yes, my analysis is that there are 2 production calls to HasControlledFrameCapability(): one in controlled_frame::AvailabilityCheck() and the other in ScriptContextSet::Register().

      For ScriptContextSet::Register(), the HasControlledFrameCapability() usage happens only when an explicit RendererFrameContextData(frame) is created, so we can ignore that case. What's left is AvailabilityCheck(). And since the mock circumstance we're talking about is only in tests, we're only concerned about when a test in the extensions system calls through there directly or indirectly. Specifically the test will have to have used the extensions test's CreateScriptContext().

      The AvailabilityCheck() call is tested dynamically in places like browser_tests. In those environments, the ScriptContext is real and uses a real WebLocalFrame. What's left to consider are unit tests where these are mocked out and tested and there aren't unit tests for AvailabilityCheck().

      I examined addressing the issue in the extensions code so a mocked WebLocalFrame was provided. If that was fixed, we could use CHECK(frame_) throughout here and in the ctor. However, that looks like a bigger project than just adding this lone CHECK(frame_) for now.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • David Bertoni
      • Philip Rogers
      • Robbie McElrath
      • Tom Sepez
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ib83ac83fd466629623bec37c64c93c28656758e1
      Gerrit-Change-Number: 5814831
      Gerrit-PatchSet: 14
      Gerrit-Owner: Chase Phillips <c...@chromium.org>
      Gerrit-Reviewer: Chase Phillips <c...@chromium.org>
      Gerrit-Reviewer: David Bertoni <dber...@chromium.org>
      Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
      Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
      Gerrit-CC: Andrew Rayskiy <green...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Luna Lu <loon...@chromium.org>
      Gerrit-CC: Robbie McElrath <rmce...@chromium.org>
      Gerrit-CC: Simon Hangl <sim...@google.com>
      Gerrit-CC: Zelin Liu <ze...@chromium.org>
      Gerrit-Attention: Tom Sepez <tse...@chromium.org>
      Gerrit-Attention: David Bertoni <dber...@chromium.org>
      Gerrit-Attention: Philip Rogers <p...@chromium.org>
      Gerrit-Attention: Robbie McElrath <rmce...@chromium.org>
      Gerrit-Comment-Date: Tue, 03 Sep 2024 20:12:26 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: David Bertoni <dber...@chromium.org>
      Comment-In-Reply-To: Robbie McElrath <rmce...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Robbie McElrath (Gerrit)

      unread,
      Sep 3, 2024, 4:44:13 PM9/3/24
      to Chase Phillips, David Bertoni, Tom Sepez, Philip Rogers, Zelin Liu, Andrew Rayskiy, Simon Hangl, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, blink-revie...@chromium.org, blink-revi...@chromium.org, mgiuca...@chromium.org, alancutter...@chromium.org, rmcelra...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, zelin+watch-we...@chromium.org, dibyapal+wa...@chromium.org, ericwillige...@chromium.org, webap...@microsoft.com, dominickn+watch-...@chromium.org, loyso...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, devtools-re...@chromium.org, extension...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
      Attention needed from Chase Phillips, David Bertoni, Philip Rogers and Tom Sepez

      Robbie McElrath voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Chase Phillips
      • David Bertoni
      • Philip Rogers
      • Tom Sepez
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ib83ac83fd466629623bec37c64c93c28656758e1
      Gerrit-Change-Number: 5814831
      Gerrit-PatchSet: 14
      Gerrit-Owner: Chase Phillips <c...@chromium.org>
      Gerrit-Reviewer: Chase Phillips <c...@chromium.org>
      Gerrit-Reviewer: David Bertoni <dber...@chromium.org>
      Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
      Gerrit-Reviewer: Robbie McElrath <rmce...@chromium.org>
      Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
      Gerrit-CC: Andrew Rayskiy <green...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Luna Lu <loon...@chromium.org>
      Gerrit-CC: Simon Hangl <sim...@google.com>
      Gerrit-CC: Zelin Liu <ze...@chromium.org>
      Gerrit-Attention: Tom Sepez <tse...@chromium.org>
      Gerrit-Attention: David Bertoni <dber...@chromium.org>
      Gerrit-Attention: Philip Rogers <p...@chromium.org>
      Gerrit-Attention: Chase Phillips <c...@chromium.org>
      Gerrit-Comment-Date: Tue, 03 Sep 2024 20:43:59 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chase Phillips (Gerrit)

      unread,
      Sep 3, 2024, 7:14:17 PM9/3/24
      to Robbie McElrath, David Bertoni, Tom Sepez, Philip Rogers, Zelin Liu, Andrew Rayskiy, Simon Hangl, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, blink-revie...@chromium.org, blink-revi...@chromium.org, mgiuca...@chromium.org, alancutter...@chromium.org, rmcelra...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, zelin+watch-we...@chromium.org, dibyapal+wa...@chromium.org, ericwillige...@chromium.org, webap...@microsoft.com, dominickn+watch-...@chromium.org, loyso...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, devtools-re...@chromium.org, extension...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
      Attention needed from Robbie McElrath

      Chase Phillips voted Commit-Queue+1

      Commit-Queue+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Robbie McElrath
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ib83ac83fd466629623bec37c64c93c28656758e1
      Gerrit-Change-Number: 5814831
      Gerrit-PatchSet: 15
      Gerrit-Owner: Chase Phillips <c...@chromium.org>
      Gerrit-Reviewer: Chase Phillips <c...@chromium.org>
      Gerrit-Reviewer: David Bertoni <dber...@chromium.org>
      Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
      Gerrit-Reviewer: Robbie McElrath <rmce...@chromium.org>
      Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
      Gerrit-CC: Andrew Rayskiy <green...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Luna Lu <loon...@chromium.org>
      Gerrit-CC: Simon Hangl <sim...@google.com>
      Gerrit-CC: Zelin Liu <ze...@chromium.org>
      Gerrit-Attention: Robbie McElrath <rmce...@chromium.org>
      Gerrit-Comment-Date: Tue, 03 Sep 2024 23:14:05 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Chase Phillips (Gerrit)

      unread,
      Sep 3, 2024, 7:25:52 PM9/3/24
      to Robbie McElrath, David Bertoni, Tom Sepez, Philip Rogers, Zelin Liu, Andrew Rayskiy, Simon Hangl, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, dullweb...@chromium.org, msrame...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, mgiuca...@chromium.org, alancutter...@chromium.org, rmcelra...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, zelin+watch-we...@chromium.org, dibyapal+wa...@chromium.org, ericwillige...@chromium.org, webap...@microsoft.com, dominickn+watch-...@chromium.org, loyso...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, devtools-re...@chromium.org, extension...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
      Attention needed from Robbie McElrath

      Chase Phillips voted Commit-Queue+1

      Commit-Queue+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Robbie McElrath
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ib83ac83fd466629623bec37c64c93c28656758e1
      Gerrit-Change-Number: 5814831
      Gerrit-PatchSet: 16
      Gerrit-Owner: Chase Phillips <c...@chromium.org>
      Gerrit-Reviewer: Chase Phillips <c...@chromium.org>
      Gerrit-Reviewer: David Bertoni <dber...@chromium.org>
      Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
      Gerrit-Reviewer: Robbie McElrath <rmce...@chromium.org>
      Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
      Gerrit-CC: Andrew Rayskiy <green...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Luna Lu <loon...@chromium.org>
      Gerrit-CC: Simon Hangl <sim...@google.com>
      Gerrit-CC: Zelin Liu <ze...@chromium.org>
      Gerrit-Attention: Robbie McElrath <rmce...@chromium.org>
      Gerrit-Comment-Date: Tue, 03 Sep 2024 23:25:40 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Robbie McElrath (Gerrit)

      unread,
      Sep 4, 2024, 1:21:00 AM9/4/24
      to Chase Phillips, Tricium, David Bertoni, Tom Sepez, Philip Rogers, Zelin Liu, Andrew Rayskiy, Simon Hangl, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, dullweb...@chromium.org, msrame...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, mgiuca...@chromium.org, alancutter...@chromium.org, rmcelra...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, zelin+watch-we...@chromium.org, dibyapal+wa...@chromium.org, ericwillige...@chromium.org, webap...@microsoft.com, dominickn+watch-...@chromium.org, loyso...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, devtools-re...@chromium.org, extension...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
      Attention needed from Chase Phillips

      Robbie McElrath voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Chase Phillips
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ib83ac83fd466629623bec37c64c93c28656758e1
      Gerrit-Change-Number: 5814831
      Gerrit-PatchSet: 16
      Gerrit-Owner: Chase Phillips <c...@chromium.org>
      Gerrit-Reviewer: Chase Phillips <c...@chromium.org>
      Gerrit-Reviewer: David Bertoni <dber...@chromium.org>
      Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
      Gerrit-Reviewer: Robbie McElrath <rmce...@chromium.org>
      Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
      Gerrit-CC: Andrew Rayskiy <green...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Luna Lu <loon...@chromium.org>
      Gerrit-CC: Simon Hangl <sim...@google.com>
      Gerrit-CC: Zelin Liu <ze...@chromium.org>
      Gerrit-Attention: Chase Phillips <c...@chromium.org>
      Gerrit-Comment-Date: Wed, 04 Sep 2024 05:20:24 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chase Phillips (Gerrit)

      unread,
      Sep 4, 2024, 11:01:19 AM9/4/24
      to Robbie McElrath, Tricium, David Bertoni, Tom Sepez, Philip Rogers, Zelin Liu, Andrew Rayskiy, Simon Hangl, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, dullweb...@chromium.org, msrame...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, mgiuca...@chromium.org, alancutter...@chromium.org, rmcelra...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, zelin+watch-we...@chromium.org, dibyapal+wa...@chromium.org, ericwillige...@chromium.org, webap...@microsoft.com, dominickn+watch-...@chromium.org, loyso...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, devtools-re...@chromium.org, extension...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

      Chase Phillips voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Gerrit-Comment-Date: Wed, 04 Sep 2024 15:01:06 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Ari Chivukula (Gerrit)

      unread,
      Sep 4, 2024, 2:29:18 PM9/4/24
      to Chase Phillips, Robbie McElrath, Tricium, David Bertoni, Tom Sepez, Philip Rogers, Zelin Liu, Andrew Rayskiy, Simon Hangl, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, dullweb...@chromium.org, msrame...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, mgiuca...@chromium.org, alancutter...@chromium.org, rmcelra...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, zelin+watch-we...@chromium.org, dibyapal+wa...@chromium.org, ericwillige...@chromium.org, webap...@microsoft.com, dominickn+watch-...@chromium.org, loyso...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, devtools-re...@chromium.org, extension...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
      Attention needed from Chase Phillips

      Ari Chivukula voted and added 1 comment

      Votes added by Ari Chivukula

      Code-Review+1

      1 comment

      Patchset-level comments
      File-level comment, Patchset 16 (Latest):
      Ari Chivukula . resolved

      Not sure why I'm an owner here, approving the test config change only

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Chase Phillips
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ib83ac83fd466629623bec37c64c93c28656758e1
      Gerrit-Change-Number: 5814831
      Gerrit-PatchSet: 16
      Gerrit-Owner: Chase Phillips <c...@chromium.org>
      Gerrit-Reviewer: Ari Chivukula <ari...@chromium.org>
      Gerrit-Reviewer: Chase Phillips <c...@chromium.org>
      Gerrit-Reviewer: David Bertoni <dber...@chromium.org>
      Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
      Gerrit-Reviewer: Robbie McElrath <rmce...@chromium.org>
      Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
      Gerrit-CC: Andrew Rayskiy <green...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Luna Lu <loon...@chromium.org>
      Gerrit-CC: Simon Hangl <sim...@google.com>
      Gerrit-CC: Zelin Liu <ze...@chromium.org>
      Gerrit-Attention: Chase Phillips <c...@chromium.org>
      Gerrit-Comment-Date: Wed, 04 Sep 2024 18:29:03 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chase Phillips (Gerrit)

      unread,
      Sep 4, 2024, 2:58:11 PM9/4/24
      to Ari Chivukula, Robbie McElrath, Tricium, David Bertoni, Tom Sepez, Philip Rogers, Zelin Liu, Andrew Rayskiy, Simon Hangl, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, dullweb...@chromium.org, msrame...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, mgiuca...@chromium.org, alancutter...@chromium.org, rmcelra...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, zelin+watch-we...@chromium.org, dibyapal+wa...@chromium.org, ericwillige...@chromium.org, webap...@microsoft.com, dominickn+watch-...@chromium.org, loyso...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, devtools-re...@chromium.org, extension...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

      Chase Phillips voted and added 1 comment

      Votes added by Chase Phillips

      Commit-Queue+2

      1 comment

      Patchset-level comments
      Chase Phillips . resolved

      Thanks Ari!

      Open in Gerrit

      Related details

      Attention set is empty
      Gerrit-Comment-Date: Wed, 04 Sep 2024 18:58:00 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Sep 4, 2024, 3:02:04 PM9/4/24
      to Chase Phillips, Ari Chivukula, Robbie McElrath, Tricium, David Bertoni, Tom Sepez, Philip Rogers, Zelin Liu, Andrew Rayskiy, Simon Hangl, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Luna Lu, dullweb...@chromium.org, msrame...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, mgiuca...@chromium.org, alancutter...@chromium.org, rmcelra...@chromium.org, dmurph+watc...@chromium.org, kuragin+web-ap...@chromium.org, philli...@chromium.org, zelin+watch-we...@chromium.org, dibyapal+wa...@chromium.org, ericwillige...@chromium.org, webap...@microsoft.com, dominickn+watch-...@chromium.org, loyso...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, devtools-re...@chromium.org, extension...@chromium.org, feature-co...@chromium.org, iclella...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      controlledframe: Add permissions policy

      Controlled Frame is only available to IWAs and per our explainer
      (https://github.com/WICG/controlled-frame) IWAs that intend to access
      the API should request to use it via a permissions policy. This CL
      adds that permissions policy, named "controlled-frame".

      The new permissions policy is defined as a normal Blink permissions
      policy and requires that the "ControlledFrame" runtime-enabled feature
      is enabled. Finally, the permissions policy is only visible in an
      isolated context, similar to other IWA APIs.

      Since Controlled Frame is implemented as a wrapper around WebView, the
      permissions policy check on both the renderer- and browser-sides is
      in //extensions. The //extensions/renderer code to do this uses a
      Blink public interface on WebLocalFrame. This CL modifies that class
      to support checking IsFeatureEnabled() on the ExecutionContext object
      it holds within Blink internal classes.
      Bug: b/40191772, b/329720352
      Change-Id: Ib83ac83fd466629623bec37c64c93c28656758e1
      Reviewed-by: Robbie McElrath <rmce...@chromium.org>
      Reviewed-by: Ari Chivukula <ari...@chromium.org>
      Commit-Queue: Chase Phillips <c...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1350968}
      Files:
      • M chrome/browser/controlled_frame/controlled_frame_apitest.cc
      • M chrome/browser/controlled_frame/controlled_frame_test_base.cc
      • M chrome/browser/web_applications/isolated_web_apps/get_isolated_web_app_browsing_data_command_browsertest.cc
      • M chrome/common/controlled_frame/controlled_frame.cc
      • M chrome/test/data/web_apps/simple_isolated_app/.well-known/manifest.webmanifest
      • M extensions/browser/browser_frame_context_data.cc
      • M extensions/browser/browser_frame_context_data.h
      • M extensions/browser/browser_process_context_data.cc
      • M extensions/browser/browser_process_context_data.h
      • M extensions/common/context_data.h
      • M extensions/renderer/DEPS
      • M extensions/renderer/renderer_context_data.cc
      • M extensions/renderer/renderer_context_data.h
      • M extensions/renderer/renderer_frame_context_data.cc
      • M extensions/renderer/renderer_frame_context_data.h
      • M extensions/renderer/script_context_set.cc
      • M extensions/test/test_context_data.cc
      • M extensions/test/test_context_data.h
      • M third_party/blink/public/devtools_protocol/browser_protocol.pdl
      • M third_party/blink/public/mojom/permissions_policy/permissions_policy_feature.mojom
      • M third_party/blink/public/web/web_local_frame.h
      • M third_party/blink/renderer/core/frame/web_local_frame_impl.cc
      • M third_party/blink/renderer/core/frame/web_local_frame_impl.h
      • M third_party/blink/renderer/core/permissions_policy/permissions_policy_features.json5
      • M third_party/blink/renderer/core/permissions_policy/permissions_policy_test.cc
      • M third_party/blink/web_tests/FlagExpectations/disable-site-isolation-trials
      • M third_party/blink/web_tests/VirtualTestSuites
      • M third_party/blink/web_tests/resources/feature-policy-features-listing.js
      • M third_party/blink/web_tests/virtual/isolated-context/README.md
      • D third_party/blink/web_tests/virtual/isolated-context/wpt_internal/permissions-policy/permissions-policy-expected.txt
      • R third_party/blink/web_tests/wpt_internal/isolated-permissions-policy/README.md
      • A third_party/blink/web_tests/wpt_internal/isolated-permissions-policy/feature-policy-features-listing.js
      • A third_party/blink/web_tests/wpt_internal/isolated-permissions-policy/permissions_policy.https.html
      • A third_party/blink/web_tests/wpt_internal/isolated-permissions-policy/permissions_policy.https.html.headers
      • D third_party/blink/web_tests/wpt_internal/permissions-policy/permissions-policy-expected.txt
      • D third_party/blink/web_tests/wpt_internal/permissions-policy/permissions-policy.html
      • M tools/metrics/histograms/enums.xml
      Change size: L
      Delta: 37 files changed, 249 insertions(+), 211 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Ari Chivukula, +1 by Robbie McElrath
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ib83ac83fd466629623bec37c64c93c28656758e1
      Gerrit-Change-Number: 5814831
      Gerrit-PatchSet: 17
      Gerrit-Owner: Chase Phillips <c...@chromium.org>
      Gerrit-Reviewer: Ari Chivukula <ari...@chromium.org>
      Gerrit-Reviewer: Chase Phillips <c...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: David Bertoni <dber...@chromium.org>
      Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
      Gerrit-Reviewer: Robbie McElrath <rmce...@chromium.org>
      Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
      Gerrit-CC: Andrew Rayskiy <green...@google.com>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages