Revert "[Extensions] V2 of Zero State Promo Chips IPH." [chromium/src : main]

0 views
Skip to first unread message

Rubber Stamper (Gerrit)

unread,
Oct 30, 2025, 7:46:18 PM (17 hours ago) Oct 30
to Emilia Paz, AyeAye, Chromium LUCI CQ, Dana Fried, Yiming Zhou, chromium...@chromium.org, estali...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, dfried...@chromium.org
Attention needed from Dana Fried and Yiming Zhou

Rubber Stamper voted Bot-Commit+1

Bot-Commit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dana Fried
  • Yiming Zhou
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7c199f156f241f46e7d965a92736492820d885be
Gerrit-Change-Number: 7101136
Gerrit-PatchSet: 1
Gerrit-Owner: Emilia Paz <emil...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Yiming Zhou <uwyi...@google.com>
Gerrit-Attention: Dana Fried <dfr...@chromium.org>
Gerrit-Attention: Yiming Zhou <uwyi...@google.com>
Gerrit-Comment-Date: Thu, 30 Oct 2025 23:46:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Emilia Paz (Gerrit)

unread,
Oct 30, 2025, 8:04:15 PM (17 hours ago) Oct 30
to Rubber Stamper, AyeAye, Chromium LUCI CQ, Dana Fried, Yiming Zhou, chromium...@chromium.org, estali...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, dfried...@chromium.org
Attention needed from Dana Fried and Yiming Zhou

Emilia Paz voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dana Fried
  • Yiming Zhou
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7c199f156f241f46e7d965a92736492820d885be
Gerrit-Change-Number: 7101136
Gerrit-PatchSet: 1
Gerrit-Owner: Emilia Paz <emil...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Dana Fried <dfr...@chromium.org>
Gerrit-Reviewer: Emilia Paz <emil...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Yiming Zhou <uwyi...@google.com>
Gerrit-Attention: Dana Fried <dfr...@chromium.org>
Gerrit-Attention: Yiming Zhou <uwyi...@google.com>
Gerrit-Comment-Date: Fri, 31 Oct 2025 00:04:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Emilia Paz (Gerrit)

unread,
Oct 30, 2025, 8:04:44 PM (17 hours ago) Oct 30
to Rubber Stamper, AyeAye, Chromium LUCI CQ, Dana Fried, Yiming Zhou, chromium...@chromium.org, estali...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, dfried...@chromium.org
Attention needed from Dana Fried and Yiming Zhou

Emilia Paz voted Commit-Queue+2

Commit-Queue+2
Gerrit-Comment-Date: Fri, 31 Oct 2025 00:04:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Oct 30, 2025, 8:05:06 PM (17 hours ago) Oct 30
to Emilia Paz, Rubber Stamper, AyeAye, Dana Fried, Yiming Zhou, chromium...@chromium.org, estali...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, dfried...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Revert "[Extensions] V2 of Zero State Promo Chips IPH."

This reverts commit 814bc7fbf21df5f8d0f2fb16e4211570b410f10e.

Reason for revert: 
Causes many builder failures. Likely cause, url used by browser test wasn't updated. 

First build failure: https://ci.chromium.org/ui/p/chromium/builders/ci/Win10%20Tests%20x64/104739/overview

Original change's description:
> [Extensions] V2 of Zero State Promo Chips IPH.
>
> This change introduces V2 of the Extensions Zero State Promo chips IPH, which highlights the chips in a light theme. Also shuffles the chips selection to place the more popular chips first.
>
> Our initial 4% stable rollout of the Extensions Zero State Promo IPH tells us that while users respond to the 'Chips' variant of the IPH the most, most of them do not realize that the chips in the IPH are clickable. This new variant attempts to address this problem by highlighting the chips with greater contrast.
>
> Comparisons of V1 vs V2: https://screenshot.googleplex.com/6Ko2mXcaZzVbdUv
>
> Screenshot of V2: https://screenshot.googleplex.com/5yafPEpiTy8JFaN
>
> Bug: 409573170
> Change-Id: I8ebc10f02021a326c438b1d772b844367f3908f1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7084950
> Reviewed-by: Dana Fried <dfr...@chromium.org>
> Reviewed-by: Emilia Paz <emil...@chromium.org>
> Commit-Queue: Yiming Zhou <uwyi...@google.com>
> Cr-Commit-Position: refs/heads/main@{#1538068}
Bug: 409573170
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I7c199f156f241f46e7d965a92736492820d885be
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Owners-Override: Emilia Paz <emil...@chromium.org>
Commit-Queue: Emilia Paz <emil...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1538296}
Files:
  • M chrome/app/extensions_strings.grdp
  • D chrome/app/extensions_strings_grdp/IDS_EXTENSIONS_ZERO_STATE_IPH_WEB_STORE_LINK.png.sha1
  • M chrome/browser/resources/extensions_zero_state_promo/icons.html
  • M chrome/browser/resources/extensions_zero_state_promo/zero_state_promo_app.css
  • M chrome/browser/resources/extensions_zero_state_promo/zero_state_promo_app.html.ts
  • M chrome/browser/resources/extensions_zero_state_promo/zero_state_promo_app.ts
  • M chrome/browser/ui/views/user_education/browser_user_education_service.cc
  • M chrome/browser/ui/webui/extensions_zero_state_promo/extensions_zero_state_promo_interactive_uitest.cc
  • M chrome/browser/ui/webui/extensions_zero_state_promo/zero_state_promo_page_handler.cc
  • M chrome/browser/ui/webui/extensions_zero_state_promo/zero_state_promo_ui.cc
  • M chrome/test/data/webui/extensions_zero_state/zero_state_promo_app_test.ts
  • M chrome/test/data/webui/extensions_zero_state/zero_state_promo_browsertest.cc
  • M components/feature_engagement/public/feature_constants.cc
  • M components/feature_engagement/public/feature_constants.h
  • M extensions/common/extension_urls.cc
  • M extensions/common/extension_urls.h
  • M extensions/common/switches.cc
  • M extensions/common/switches.h
Change size: L
Delta: 18 files changed, 67 insertions(+), 450 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: Bot-Commit+1 by Rubber Stamper
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7c199f156f241f46e7d965a92736492820d885be
Gerrit-Change-Number: 7101136
Gerrit-PatchSet: 2
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages