[Extensions] Add Promise type as return for runtime.onMessageExternal [chromium/src : main]
0 views
Skip to first unread message
Justin Lulejian (Gerrit)
Jan 8, 2026, 5:03:51 PM (18 hours ago) Jan 8
to Tim, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Tim
Justin Lulejian voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Tim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tim (Gerrit)
Jan 8, 2026, 6:16:01 PM (16 hours ago) Jan 8
to Justin Lulejian, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Justin Lulejian
Tim voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tim
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Tim . resolved
LGTM, thanks Justin! I had a bullet point to go back and update the description for onMessage, thanks for including that here too!
Related details
Attention is currently required from:
- Justin Lulejian
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 8, 2026, 6:29:52 PM (16 hours ago) Jan 8
to Justin Lulejian, Tim, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Extensions] Add Promise type as return for runtime.onMessageExternal
This is mostly a documentation update to reflect recent changes which
allow an onMessageExternal listener to return a promise instead of
returning true when they want to respond asynchronously.
It also makes a minor wording update to onMessage regarding promises.
Bug: 443136605
Fixed: 471017626
Change-Id: Ia81085ca54b7a2d3c77a68671f2303d22be9ac00
Reviewed-by: Tim <tjud...@chromium.org>
Commit-Queue: Justin Lulejian <jlul...@chromium.org>
Auto-Submit: Justin Lulejian <jlul...@chromium.org>
Commit-Queue: Tim <tjud...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1566592}
Files:
- M extensions/common/api/runtime.json
Change size: XS
Delta: 1 file changed, 6 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tim
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages