Better usage of conversion functions to/from Unix epoch: chrome [chromium/src : main]

Peter Kasting (Gerrit)

unread,

Oct 24, 2023, 10:42:06 PM10/24/23

to Scott Violet, ajayramamurt...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, arc-review...@google.com, browser-comp...@chromium.org, cclem+wat...@google.com, chromium-a...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, dclasson+w...@google.com, dewitt...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hidehik...@chromium.org, iwells...@chromium.org, jonmann+w...@chromium.org, kinuko+...@chromium.org, msrame...@chromium.org, petewi...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, sarakat...@chromium.org, suetfei+wa...@google.com, xlythe+wa...@google.com

Attention is currently required from: Scott Violet.

Peter Kasting would like Scott Violet to review this change.

View Change

Better usage of conversion functions to/from Unix epoch: chrome

Bug: none
Change-Id: I08964f9581f2de7865e6377cbab477591b8cdce7
---
M chrome/browser/ash/arc/fileapi/arc_documents_provider_root_unittest.cc
M chrome/browser/ash/eche_app/eche_app_manager_factory.cc
M chrome/browser/ash/fileapi/recent_disk_source_unittest.cc
M chrome/browser/ash/fileapi/recent_model_unittest.cc
M chrome/browser/autofill/captured_sites_test_utils.cc
M chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
M chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc
M chrome/browser/extensions/api/history/history_api.cc
M chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc
M chrome/browser/feed/android/feed_surface_renderer_bridge.cc
M chrome/browser/nearby_sharing/certificates/nearby_share_decrypted_public_certificate.cc
M chrome/browser/nearby_sharing/certificates/nearby_share_decrypted_public_certificate_unittest.cc
M chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
M chrome/browser/ui/webui/downloads/downloads_list_tracker.cc
M chrome/browser/ui/webui/print_preview/local_printer_handler_chromeos_unittest.cc
M chrome/renderer/loadtimes_extension_bindings.cc
M chrome/services/file_util/zip_file_creator.cc
M chrome/updater/persisted_data_unittest.cc
18 files changed, 192 insertions(+), 267 deletions(-)

To view, visit change 4975657. To unsubscribe, or for help writing mail filters, visit settings.

Peter Kasting (Gerrit)

unread,

Oct 24, 2023, 10:42:13 PM10/24/23

to ajayramamurt...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, arc-review...@google.com, browser-comp...@chromium.org, cclem+wat...@google.com, chromium-a...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, dclasson+w...@google.com, dewitt...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hidehik...@chromium.org, iwells...@chromium.org, jonmann+w...@chromium.org, kinuko+...@chromium.org, msrame...@chromium.org, petewi...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, sarakat...@chromium.org, suetfei+wa...@google.com, xlythe+wa...@google.com, Scott Violet, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo

Attention is currently required from: Scott Violet.

Patch set 1:Auto-Submit +1

View Change

To view, visit change 4975657. To unsubscribe, or for help writing mail filters, visit settings.

findit-for-me@appspot.gserviceaccount.com (Gerrit)

unread,

Oct 24, 2023, 11:22:44 PM10/24/23

to Peter Kasting, ajayramamurt...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, arc-review...@google.com, browser-comp...@chromium.org, cclem+wat...@google.com, chromium-a...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, dclasson+w...@google.com, dewitt...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hidehik...@chromium.org, iwells...@chromium.org, jonmann+w...@chromium.org, kinuko+...@chromium.org, msrame...@chromium.org, petewi...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, sarakat...@chromium.org, suetfei+wa...@google.com, xlythe+wa...@google.com, Scott Violet, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo

Attention is currently required from: Scott Violet.

This change meets the code coverage requirements.

Patch set 1:Code-Coverage +1

View Change

To view, visit change 4975657. To unsubscribe, or for help writing mail filters, visit settings.

Scott Violet (Gerrit)

unread,

Oct 25, 2023, 12:04:23 PM10/25/23

to Peter Kasting, ajayramamurt...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, arc-review...@google.com, browser-comp...@chromium.org, cclem+wat...@google.com, chromium-a...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, dclasson+w...@google.com, dewitt...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hidehik...@chromium.org, iwells...@chromium.org, jonmann+w...@chromium.org, kinuko+...@chromium.org, msrame...@chromium.org, petewi...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, sarakat...@chromium.org, suetfei+wa...@google.com, xlythe+wa...@google.com, Scott Violet, findit...@appspot.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo

Attention is currently required from: Peter Kasting.

Patch set 1:Code-Review +1Commit-Queue +2

View Change

To view, visit change 4975657. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Oct 25, 2023, 12:12:17 PM10/25/23

to Peter Kasting, ajayramamurt...@google.com, ajayramamurth...@google.com, alandin...@chromium.org, arc-review...@google.com, browser-comp...@chromium.org, cclem+wat...@google.com, chromium-a...@chromium.org, crisrael+...@google.com, crisrael+w...@google.com, dclasson+w...@google.com, dewitt...@chromium.org, dimich...@chromium.org, djacob...@chromium.org, druber...@chromium.org, dtraino...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansenmichael...@google.com, harringt...@chromium.org, hidehik...@chromium.org, iwells...@chromium.org, jonmann+w...@chromium.org, kinuko+...@chromium.org, msrame...@chromium.org, petewi...@chromium.org, print-revi...@chromium.org, pushi+wa...@google.com, pushi+wat...@google.com, sarakat...@chromium.org, suetfei+wa...@google.com, xlythe+wa...@google.com, Scott Violet, findit...@appspot.gserviceaccount.com, chromium...@chromium.org, Peter Beverloo

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  findit...@appspot.gserviceaccount.com: Ok
  Peter Kasting: Send CL to CQ automatically after approval
  Scott Violet: Looks good to me; Commit

Better usage of conversion functions to/from Unix epoch: chrome

Bug: none
Change-Id: I08964f9581f2de7865e6377cbab477591b8cdce7

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4975657
Reviewed-by: Scott Violet <s...@chromium.org>
Commit-Queue: Scott Violet <s...@chromium.org>
Code-Coverage: findit...@appspot.gserviceaccount.com <findit...@appspot.gserviceaccount.com>
Auto-Submit: Peter Kasting <pkas...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1214893}


---
M chrome/browser/ash/arc/fileapi/arc_documents_provider_root_unittest.cc
M chrome/browser/ash/eche_app/eche_app_manager_factory.cc
M chrome/browser/ash/fileapi/recent_disk_source_unittest.cc
M chrome/browser/ash/fileapi/recent_model_unittest.cc
M chrome/browser/autofill/captured_sites_test_utils.cc
M chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
M chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc
M chrome/browser/extensions/api/history/history_api.cc
M chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc
M chrome/browser/feed/android/feed_surface_renderer_bridge.cc
M chrome/browser/nearby_sharing/certificates/nearby_share_decrypted_public_certificate.cc
M chrome/browser/nearby_sharing/certificates/nearby_share_decrypted_public_certificate_unittest.cc
M chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
M chrome/browser/ui/webui/downloads/downloads_list_tracker.cc
M chrome/browser/ui/webui/print_preview/local_printer_handler_chromeos_unittest.cc
M chrome/renderer/loadtimes_extension_bindings.cc
M chrome/services/file_util/zip_file_creator.cc
M chrome/updater/persisted_data_unittest.cc
18 files changed, 192 insertions(+), 267 deletions(-)

To view, visit change 4975657. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward