[Extensions WebIDL] Convert networkingPrivate to WebIDL [chromium/src : main]
0 views
Skip to first unread message
Tim (Gerrit)
Jan 27, 2026, 8:07:52 PM (3 days ago) Jan 27
to Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Devlin Cronin
Tim added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Tim . resolved
One more chunky one here, which also has an update to a comment referencing the filename and a regeneration of the associated typescript file.
I realize I'll need to do a pass over the ts files. I had it in my head that since the effective content wasn't changing they didn't need to be regenerated, but since they contain a comment which includes the command to regenerate them that uses the actual filename, that filename needs updating to the .webidl version. I'll make a note to do a pass over them to get any I've missed so far.
File tools/typescript/definitions/networking_private.d.ts
Line 7, Patchset 2:
* Generated from: extensions/common/api/networking_private.webidlTim . unresolved
Note: I'll make a note to double check for any other of these files I might have missed which will need an update.
Related details
Attention is currently required from:
- Devlin Cronin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devlin Cronin (Gerrit)
Jan 28, 2026, 2:08:16 PM (2 days ago) Jan 28
to Tim, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Tim
Devlin Cronin voted and added 1 comment![]( "Open in Gerrit")
Votes added by Devlin Cronin
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Tim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tim (Gerrit)
Jan 30, 2026, 5:50:44 PM (7 hours ago) Jan 30
to Demetrios Papadopoulos, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Demetrios Papadopoulos
Tim added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Tim . resolved
Adding dpapad@ for t/t/d/networking_private.d.ts
Could you take a look? Thanks!
File tools/typescript/definitions/networking_private.d.ts
Line 7, Patchset 2:
* Generated from: extensions/common/api/networking_private.webidlTim . resolved
Note: I'll make a note to double check for any other of these files I might have missed which will need an update.
Tim
Interestingly a lot of these don't have the "Generated from" annotation and most of those that do are for JSON schemas, so I've not missed any of them so far.
Related details
Attention is currently required from:
- Demetrios Papadopoulos
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Demetrios Papadopoulos (Gerrit)
Jan 30, 2026, 6:47:57 PM (6 hours ago) Jan 30
to Tim, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Tim
Demetrios Papadopoulos voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Tim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tim (Gerrit)
Jan 30, 2026, 7:42:16 PM (5 hours ago) Jan 30
to Demetrios Papadopoulos, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Tim voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 30, 2026, 8:43:37 PM (4 hours ago) Jan 30
to Tim, Demetrios Papadopoulos, Devlin Cronin, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Extensions WebIDL] Convert networkingPrivate to WebIDL
This conversion was largely done using a detailed description of the
conversion process passed to Gemini CLI. To double check this work, the
file has also been copied into the converted schemas test to verify no
functional difference in output.
Also updates a few comments with the new filename and regenerates the
associated typescript file (which was also a little out of date).
Fixed: 452427903
Change-Id: I89df1c005d42a94c05c42dcf14f15cd26a4049d2
Reviewed-by: Devlin Cronin <rdevlin...@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpa...@chromium.org>
Commit-Queue: Tim <tjud...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1577641}
Files:
- M extensions/browser/api/networking_private/networking_private_delegate.h
- M extensions/common/api/generated_externs_list.txt
- A extensions/common/api/networking_private.webidl
- M extensions/common/api/schema.gni
- R tools/json_schema_compiler/test/converted_schemas/networking_private.idl
- A tools/json_schema_compiler/test/converted_schemas/networking_private.webidl
- M tools/json_schema_compiler/web_idl_diff_tool_test.py
- M tools/typescript/definitions/networking_private.d.ts
Change size: XL
Delta: 8 files changed, 2307 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Devlin Cronin, +1 by Demetrios Papadopoulos
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages