Fix RTL UI for extensions being flipped [chromium/src : main]

0 views
Skip to first unread message

David Yeung (Gerrit)

unread,
4:33 PM (5 hours ago) 4:33 PM
to Jason Jiang, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Jason Jiang

David Yeung voted and added 1 comment

Votes added by David Yeung

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
David Yeung . resolved

lgtm!

Open in Gerrit

Related details

Attention is currently required from:
  • Jason Jiang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia5a674e2c2ec9656d2ea6c78ba8abe2e71957040
Gerrit-Change-Number: 8007106
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Jiang <jason...@google.com>
Gerrit-Reviewer: David Yeung <day...@chromium.org>
Gerrit-Reviewer: Jason Jiang <jason...@google.com>
Gerrit-Attention: Jason Jiang <jason...@google.com>
Gerrit-Comment-Date: Thu, 25 Jun 2026 20:33:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Emily Shack (Gerrit)

unread,
5:14 PM (4 hours ago) 5:14 PM
to Jason Jiang, David Yeung, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Jason Jiang

Emily Shack voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jason Jiang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia5a674e2c2ec9656d2ea6c78ba8abe2e71957040
Gerrit-Change-Number: 8007106
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Jiang <jason...@google.com>
Gerrit-Reviewer: David Yeung <day...@chromium.org>
Gerrit-Reviewer: Emily Shack <ems...@chromium.org>
Gerrit-Reviewer: Jason Jiang <jason...@google.com>
Gerrit-Attention: Jason Jiang <jason...@google.com>
Gerrit-Comment-Date: Thu, 25 Jun 2026 21:14:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Jason Jiang (Gerrit)

unread,
5:43 PM (4 hours ago) 5:43 PM
to Emily Shack, David Yeung, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Jason Jiang voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia5a674e2c2ec9656d2ea6c78ba8abe2e71957040
Gerrit-Change-Number: 8007106
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Jiang <jason...@google.com>
Gerrit-Reviewer: David Yeung <day...@chromium.org>
Gerrit-Reviewer: Emily Shack <ems...@chromium.org>
Gerrit-Reviewer: Jason Jiang <jason...@google.com>
Gerrit-Comment-Date: Thu, 25 Jun 2026 21:43:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
5:47 PM (4 hours ago) 5:47 PM
to Jason Jiang, Emily Shack, David Yeung, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Fix RTL UI for extensions being flipped

RTL UI for extensions menu was flipped and was the same as the LTR
Bug: 527542288
Change-Id: Ia5a674e2c2ec9656d2ea6c78ba8abe2e71957040
Reviewed-by: David Yeung <day...@chromium.org>
Commit-Queue: Jason Jiang <jason...@google.com>
Reviewed-by: Emily Shack <ems...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1652739}
Files:
  • M chrome/browser/ui/views/extensions/extensions_toolbar_desktop.cc
Change size: XS
Delta: 1 file changed, 3 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by David Yeung, +1 by Emily Shack
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia5a674e2c2ec9656d2ea6c78ba8abe2e71957040
Gerrit-Change-Number: 8007106
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Jiang <jason...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: David Yeung <day...@chromium.org>
Gerrit-Reviewer: Emily Shack <ems...@chromium.org>
Gerrit-Reviewer: Jason Jiang <jason...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages