Reland "Force the update of corrupted extensions." [chromium/src : main]

0 views
Skip to first unread message

Rubber Stamper (Gerrit)

unread,
Jan 8, 2026, 9:32:21 AM (yesterday) Jan 8
to Giovanni Pezzino, Devlin Cronin, David Yeung, Oleg Davydov, Chromium LUCI CQ, Simon Hangl, AyeAye, Justin Lulejian, Code Review Nudger, chromeos-commercial-readability-c-reviewers+reviews, chromium...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org
Attention needed from David Yeung, David Yeung, Devlin Cronin, Oleg Davydov and Simon Hangl

Rubber Stamper voted Bot-Commit+1

Bot-Commit+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Yeung
  • David Yeung
  • Devlin Cronin
  • Oleg Davydov
  • Simon Hangl
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9ce00a04a5d32ed233512ee2cabfb6f241cea5d8
Gerrit-Change-Number: 7415381
Gerrit-PatchSet: 1
Gerrit-Owner: Giovanni Pezzino <gio...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: David Yeung <day...@chromium.org>
Gerrit-Reviewer: David Yeung <day...@google.com>
Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Reviewer: Oleg Davydov <buru...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Simon Hangl <sim...@google.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: Justin Lulejian <jlul...@chromium.org>
Gerrit-CC: chromeos-commercial-readability-c-reviewers+reviews <chromeos-commercial-reada...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Attention: Oleg Davydov <buru...@chromium.org>
Gerrit-Attention: David Yeung <day...@chromium.org>
Gerrit-Attention: Simon Hangl <sim...@google.com>
Gerrit-Attention: David Yeung <day...@google.com>
Gerrit-Comment-Date: Thu, 08 Jan 2026 14:32:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Jan 8, 2026, 10:02:06 AM (yesterday) Jan 8
to extension...@chromium.org
Attention needed from David Yeung, David Yeung, Devlin Cronin, Oleg Davydov and Simon Hangl

Message from Rubber Stamper

Gerrit GetPureRevert API does not mark this CL as a pure revert. Learn more: go/rubber-stamper-user-guide.

Open in Gerrit

Related details

Attention is currently required from:
  • David Yeung
  • David Yeung
  • Devlin Cronin
  • Oleg Davydov
  • Simon Hangl
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9ce00a04a5d32ed233512ee2cabfb6f241cea5d8
    Gerrit-Change-Number: 7415381
    Gerrit-PatchSet: 2
    Gerrit-Owner: Giovanni Pezzino <gio...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: David Yeung <day...@chromium.org>
    Gerrit-Reviewer: David Yeung <day...@google.com>
    Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
    Gerrit-Reviewer: Oleg Davydov <buru...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: Simon Hangl <sim...@google.com>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-CC: Justin Lulejian <jlul...@chromium.org>
    Gerrit-CC: chromeos-commercial-readability-c-reviewers+reviews <chromeos-commercial-reada...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Devlin Cronin <rdevlin...@chromium.org>
    Gerrit-Attention: Oleg Davydov <buru...@chromium.org>
    Gerrit-Attention: David Yeung <day...@chromium.org>
    Gerrit-Attention: Simon Hangl <sim...@google.com>
    Gerrit-Attention: David Yeung <day...@google.com>
    Gerrit-Comment-Date: Thu, 08 Jan 2026 15:01:34 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Giovanni Pezzino (Gerrit)

    unread,
    Jan 8, 2026, 10:06:04 AM (yesterday) Jan 8
    to Devlin Cronin, David Yeung, Oleg Davydov, Chromium LUCI CQ, Simon Hangl, AyeAye, Justin Lulejian, Code Review Nudger, chromeos-commercial-readability-c-reviewers+reviews, chromium...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org
    Attention needed from David Yeung, David Yeung, Devlin Cronin, Oleg Davydov and Simon Hangl

    Giovanni Pezzino added 1 comment

    Patchset-level comments
    File-level comment, Patchset 2 (Latest):
    Giovanni Pezzino . resolved

    Devlin, PTAL.

    Patchset 2 includes the new check in extension_protocols.cc to make the broken test pass. I could not use the IsShuttingDown() method as we discussed, as it returned false.

    Gerrit-Reviewer: Giovanni Pezzino <gio...@google.com>
    Gerrit-Reviewer: Oleg Davydov <buru...@chromium.org>
    Gerrit-Reviewer: Simon Hangl <sim...@google.com>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-CC: Justin Lulejian <jlul...@chromium.org>
    Gerrit-CC: chromeos-commercial-readability-c-reviewers+reviews <chromeos-commercial-reada...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Devlin Cronin <rdevlin...@chromium.org>
    Gerrit-Attention: Oleg Davydov <buru...@chromium.org>
    Gerrit-Attention: David Yeung <day...@chromium.org>
    Gerrit-Attention: Simon Hangl <sim...@google.com>
    Gerrit-Attention: David Yeung <day...@google.com>
    Gerrit-Comment-Date: Thu, 08 Jan 2026 15:05:47 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Devlin Cronin (Gerrit)

    unread,
    Jan 8, 2026, 2:01:35 PM (21 hours ago) Jan 8
    to Giovanni Pezzino, Devlin Cronin, Oleg Davydov, Chromium LUCI CQ, Simon Hangl, AyeAye, Justin Lulejian, Code Review Nudger, chromeos-commercial-readability-c-reviewers+reviews, chromium...@chromium.org, extension...@chromium.org, chromium-a...@chromium.org
    Attention needed from David Yeung, Giovanni Pezzino, Oleg Davydov and Simon Hangl

    Devlin Cronin added 1 comment

    Patchset-level comments
    Devlin Cronin . resolved

    Thanks, Gio! The new check seems conceptually correct, but it looks like there are failing tests?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • David Yeung
    • Giovanni Pezzino
    • Oleg Davydov
    • Simon Hangl
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9ce00a04a5d32ed233512ee2cabfb6f241cea5d8
    Gerrit-Change-Number: 7415381
    Gerrit-PatchSet: 2
    Gerrit-Owner: Giovanni Pezzino <gio...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: David Yeung <day...@google.com>
    Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
    Gerrit-Reviewer: Giovanni Pezzino <gio...@google.com>
    Gerrit-Reviewer: Oleg Davydov <buru...@chromium.org>
    Gerrit-Reviewer: Simon Hangl <sim...@google.com>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-CC: Justin Lulejian <jlul...@chromium.org>
    Gerrit-CC: chromeos-commercial-readability-c-reviewers+reviews <chromeos-commercial-reada...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Oleg Davydov <buru...@chromium.org>
    Gerrit-Attention: Simon Hangl <sim...@google.com>
    Gerrit-Attention: David Yeung <day...@google.com>
    Gerrit-Attention: Giovanni Pezzino <gio...@google.com>
    Gerrit-Comment-Date: Thu, 08 Jan 2026 19:01:26 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages