[APC Sunset] Remove consent [chromium/src : main]

Bruno Braga (Gerrit)

unread,

Nov 24, 2022, 11:30:40 AM11/24/22

to Jan Keitel, chromium-a...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, michaelpg+wa...@chromium.org, vasilii+watchlis...@chromium.org

Attention is currently required from: Jan Keitel.

Bruno Braga would like Jan Keitel to review this change.

View Change

[APC Sunset] Remove consent

Change-Id: Ife18c4c0f722729036c2adabe39061cf93d63a12
---
M chrome/browser/autofill_assistant/password_change/apc_onboarding_coordinator_impl.cc
M chrome/browser/autofill_assistant/password_change/apc_onboarding_coordinator_impl_unittest.cc
M chrome/browser/ui/BUILD.gn
D chrome/browser/ui/webui/settings/autofill_assistant_handler.cc
D chrome/browser/ui/webui/settings/autofill_assistant_handler.h
M chrome/browser/ui/webui/settings/settings_ui.cc
M components/consent_auditor/consent_auditor.h
M components/consent_auditor/consent_auditor_impl.cc
M components/consent_auditor/consent_auditor_impl.h
M components/consent_auditor/consent_auditor_impl_unittest.cc
M components/consent_auditor/fake_consent_auditor.cc
M components/consent_auditor/fake_consent_auditor.h
12 files changed, 10 insertions(+), 305 deletions(-)

To view, visit change 4055568. To unsubscribe, or for help writing mail filters, visit settings.

Bruno Braga (Gerrit)

unread,

Nov 24, 2022, 11:33:35 AM11/24/22

to chromium-a...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, michaelpg+wa...@chromium.org, vasilii+watchlis...@chromium.org, Jan Keitel, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Jan Keitel.

View Change

To view, visit change 4055568. To unsubscribe, or for help writing mail filters, visit settings.

Jan Keitel (Gerrit)

unread,

Nov 25, 2022, 2:17:17 AM11/25/22

to Bruno Braga, chromium-a...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, michaelpg+wa...@chromium.org, vasilii+watchlis...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Bruno Braga.

View Change

1 comment:

File chrome/browser/ui/webui/settings/settings_ui.cc:
- Patch Set #4, Line 418:
```
web_ui->AddMessageHandler(std::make_unique<AutofillAssistantHandler>(
      std::vector<int>{IDS_SETTINGS_AUTOFILL_ASSISTANT_PREF,
                       IDS_SETTINGS_AUTOFILL_ASSISTANT_PREF_DESC}));
```
  If you remove this handler, than you should also remove the parts that use it, i.e. [this proxy](https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/resources/settings/privacy_page/autofill_assistant_browser_proxy.ts) and its users.

To view, visit change 4055568. To unsubscribe, or for help writing mail filters, visit settings.

Bruno Braga (Gerrit)

unread,

Nov 25, 2022, 7:07:30 AM11/25/22

to chromium-a...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, michaelpg+wa...@chromium.org, vasilii+watchlis...@chromium.org, Jan Keitel, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Jan Keitel.

View Change

1 comment:

File chrome/browser/ui/webui/settings/settings_ui.cc:

Patch Set #4, Line 418:

web_ui->AddMessageHandler(std::make_unique<AutofillAssistantHandler>(
      std::vector<int>{IDS_SETTINGS_AUTOFILL_ASSISTANT_PREF,
                       IDS_SETTINGS_AUTOFILL_ASSISTANT_PREF_DESC}));

- If you remove this handler, than you should also remove the parts that use it, i.e. […]
  Done

To view, visit change 4055568. To unsubscribe, or for help writing mail filters, visit settings.

Jan Keitel (Gerrit)

unread,

Nov 25, 2022, 7:17:55 AM11/25/22

to Bruno Braga, chromium-a...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, michaelpg+wa...@chromium.org, vasilii+watchlis...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Bruno Braga.

Patch set 5:Code-Review +1

View Change

1 comment:

File chrome/browser/autofill_assistant/password_change/apc_onboarding_coordinator_impl_unittest.cc:
- Patch Set #5, Line 44: using consent_auditor::FakeConsentAuditor;
  Remove.

To view, visit change 4055568. To unsubscribe, or for help writing mail filters, visit settings.

Bruno Braga (Gerrit)

unread,

Nov 25, 2022, 7:21:58 AM11/25/22

to Ryan Hansberry, Demetrios Papadopoulos, Markus Heintz, chromium-a...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, michaelpg+wa...@chromium.org, vasilii+watchlis...@chromium.org, Jan Keitel

Attention is currently required from: Demetrios Papadopoulos, Markus Heintz, Ryan Hansberry.

Bruno Braga would like Ryan Hansberry, Demetrios Papadopoulos and Markus Heintz to review this change.

View Change

[APC Sunset] Remove consent

Change-Id: Ife18c4c0f722729036c2adabe39061cf93d63a12
---
M chrome/browser/autofill_assistant/password_change/apc_onboarding_coordinator_impl.cc
M chrome/browser/autofill_assistant/password_change/apc_onboarding_coordinator_impl_unittest.cc

M chrome/browser/resources/settings/BUILD.gn
M chrome/browser/resources/settings/chromeos/os_settings.gni
M chrome/browser/resources/settings/lazy_load.ts
D chrome/browser/resources/settings/privacy_page/autofill_assistant_browser_proxy.ts
M chrome/browser/resources/settings/privacy_page/personalization_options.ts


M chrome/browser/ui/BUILD.gn
D chrome/browser/ui/webui/settings/autofill_assistant_handler.cc
D chrome/browser/ui/webui/settings/autofill_assistant_handler.h
M chrome/browser/ui/webui/settings/settings_ui.cc

M chrome/test/data/webui/settings/BUILD.gn
M chrome/test/data/webui/settings/personalization_options_test.ts
D chrome/test/data/webui/settings/test_autofill_assistant_browser_proxy.ts


M components/consent_auditor/consent_auditor.h
M components/consent_auditor/consent_auditor_impl.cc
M components/consent_auditor/consent_auditor_impl.h
M components/consent_auditor/consent_auditor_impl_unittest.cc
M components/consent_auditor/fake_consent_auditor.cc
M components/consent_auditor/fake_consent_auditor.h

20 files changed, 13 insertions(+), 462 deletions(-)

To view, visit change 4055568. To unsubscribe, or for help writing mail filters, visit settings.

Bruno Braga (Gerrit)

unread,

Nov 25, 2022, 7:25:43 AM11/25/22

to chromium-a...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, michaelpg+wa...@chromium.org, vasilii+watchlis...@chromium.org, Demetrios Papadopoulos, Markus Heintz, Ryan Hansberry, Jan Keitel, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Demetrios Papadopoulos, Markus Heintz, Ryan Hansberry.

View Change

2 comments:

Patchset:
- Patch Set #5:
  dpapad: settings/privacy_page/, lazy_load.ts, chrome/browser/ui/webui/settings/
  Markus: consent_auditor.h
  hansberry: os_settings.gni
File chrome/browser/autofill_assistant/password_change/apc_onboarding_coordinator_impl_unittest.cc:

- Patch Set #5, Line 44: using consent_auditor::FakeConsentAuditor;
  Remove.

- Done

To view, visit change 4055568. To unsubscribe, or for help writing mail filters, visit settings.

Markus Heintz (Gerrit)

unread,

Nov 25, 2022, 7:44:40 AM11/25/22

to Bruno Braga, chromium-a...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, michaelpg+wa...@chromium.org, vasilii+watchlis...@chromium.org, Demetrios Papadopoulos, Ryan Hansberry, Jan Keitel, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Bruno Braga, Demetrios Papadopoulos, Ryan Hansberry.

Patch set 6:Code-Review +1

View Change

1 comment:

Patchset:
- Patch Set #6:
  consent_auditor changes LGTM

To view, visit change 4055568. To unsubscribe, or for help writing mail filters, visit settings.

Ryan Hansberry (Gerrit)

unread,

Nov 28, 2022, 1:39:07 PM11/28/22

to Bruno Braga, chromium-a...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, michaelpg+wa...@chromium.org, vasilii+watchlis...@chromium.org, Markus Heintz, Demetrios Papadopoulos, Jan Keitel, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Bruno Braga, Demetrios Papadopoulos, Jan Keitel, Markus Heintz.

View Change

1 comment:

Patchset:
- Patch Set #10:
  I'm not needed as reviewer here and don't have context -- dpapad@ can review os_settings.gni.

To view, visit change 4055568. To unsubscribe, or for help writing mail filters, visit settings.

Demetrios Papadopoulos (Gerrit)

unread,

Nov 28, 2022, 3:03:23 PM11/28/22

to Bruno Braga, chromium-a...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, michaelpg+wa...@chromium.org, vasilii+watchlis...@chromium.org, Markus Heintz, Jan Keitel, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Bruno Braga, Jan Keitel, Markus Heintz.

View Change

4 comments:

Commit Message:
- Patch Set #10, Line 8:
  Could this CL be linked to a bug? Is it related to https://crbug.com/1386065 ?
File chrome/browser/resources/settings/privacy_page/personalization_options.ts:
- Patch Set #10, Line 133: private shouldShowAutofillAssistant_: boolean;
  This is still needed, as the Polymer proprety with the same name is not removed. Or should the Polymer property be removed as well?
- Patch Set #10, Line 356:
```
  const toggle = this.shadowRoot!.querySelector<SettingsToggleButtonElement>(
        '#enableAutofillAssistantToggle');
```
  Should the code at [1] also be removed?
  [1] https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/resources/settings/privacy_page/personalization_options.html;l=112-121;drc=be185dad359a88029a5f0343186a8e0e4f580af4
File chrome/test/data/webui/settings/personalization_options_test.ts:
- Patch Set #10, Line 14:
```
import {isVisible} from 'chrome://webui-test/test_util.js';
import {eventToPromise} from 'chrome://webui-test/test_util.js';
```
  Should be merged to a single import statement.

To view, visit change 4055568. To unsubscribe, or for help writing mail filters, visit settings.

Bruno Braga (Gerrit)

unread,

Nov 29, 2022, 3:57:12 AM11/29/22

to chromium-a...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, michaelpg+wa...@chromium.org, vasilii+watchlis...@chromium.org

Attention is currently required from: Bruno Braga, Jan Keitel, Markus Heintz.

Bruno Braga uploaded patch set #11 to this change.

View Change

[APC Sunset] Remove consent

Bug: 1386065


Change-Id: Ife18c4c0f722729036c2adabe39061cf93d63a12
---
M chrome/browser/autofill_assistant/password_change/apc_onboarding_coordinator_impl.cc
M chrome/browser/autofill_assistant/password_change/apc_onboarding_coordinator_impl_unittest.cc
M chrome/browser/resources/settings/BUILD.gn
M chrome/browser/resources/settings/chromeos/os_settings.gni
M chrome/browser/resources/settings/lazy_load.ts
D chrome/browser/resources/settings/privacy_page/autofill_assistant_browser_proxy.ts
M chrome/browser/resources/settings/privacy_page/personalization_options.ts
M chrome/browser/ui/BUILD.gn
D chrome/browser/ui/webui/settings/autofill_assistant_handler.cc
D chrome/browser/ui/webui/settings/autofill_assistant_handler.h
M chrome/browser/ui/webui/settings/settings_ui.cc
M chrome/test/data/webui/settings/BUILD.gn
M chrome/test/data/webui/settings/personalization_options_test.ts
D chrome/test/data/webui/settings/test_autofill_assistant_browser_proxy.ts
M components/consent_auditor/consent_auditor.h
M components/consent_auditor/consent_auditor_impl.cc
M components/consent_auditor/consent_auditor_impl.h
M components/consent_auditor/consent_auditor_impl_unittest.cc
M components/consent_auditor/fake_consent_auditor.cc
M components/consent_auditor/fake_consent_auditor.h

20 files changed, 15 insertions(+), 483 deletions(-)

To view, visit change 4055568. To unsubscribe, or for help writing mail filters, visit settings.

Bruno Braga (Gerrit)

unread,

Nov 29, 2022, 4:55:26 AM11/29/22

to chromium-a...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, michaelpg+wa...@chromium.org, vasilii+watchlis...@chromium.org, Markus Heintz, Demetrios Papadopoulos, Jan Keitel, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Demetrios Papadopoulos, Jan Keitel, Markus Heintz.

View Change

5 comments:

Commit Message:

- Patch Set #10, Line 8:

- Could this CL be linked to a bug? Is it related to https://crbug. […]
  Done
Patchset:
- Patch Set #13:
  Hi @jke...@google.com and @markus...@chromium.org could you folks take another look, your review got outdated =)
File chrome/browser/resources/settings/privacy_page/personalization_options.ts:

- Patch Set #10, Line 133: private shouldShowAutofillAssistant_: boolean;

- This is still needed, as the Polymer proprety with the same name is not removed. […]
  nothing is needed anymore, thanks =)

Patch Set #10, Line 356:

  const toggle = this.shadowRoot!.querySelector<SettingsToggleButtonElement>(
        '#enableAutofillAssistantToggle');

- Should the code at [1] also be removed? […]
  Done
File chrome/test/data/webui/settings/personalization_options_test.ts:

Patch Set #10, Line 14:

import {isVisible} from 'chrome://webui-test/test_util.js';
import {eventToPromise} from 'chrome://webui-test/test_util.js';

Should be merged to a single import statement.

- Done

To view, visit change 4055568. To unsubscribe, or for help writing mail filters, visit settings.

Jan Keitel (Gerrit)

unread,

Nov 29, 2022, 5:05:29 AM11/29/22

to Bruno Braga, chromium-a...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, michaelpg+wa...@chromium.org, vasilii+watchlis...@chromium.org, Markus Heintz, Demetrios Papadopoulos, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Bruno Braga, Demetrios Papadopoulos, Markus Heintz.

Patch set 13:Code-Review +1

View Change

To view, visit change 4055568. To unsubscribe, or for help writing mail filters, visit settings.

Demetrios Papadopoulos (Gerrit)

unread,

Nov 29, 2022, 5:27:32 PM11/29/22

to Bruno Braga, chromium-a...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, michaelpg+wa...@chromium.org, vasilii+watchlis...@chromium.org, Jan Keitel, Markus Heintz, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Bruno Braga, Markus Heintz.

Patch set 13:Code-Review +1

View Change

2 comments:

Patchset:
- Patch Set #13:
  LGTM with a question.
File chrome/browser/resources/settings/privacy_page/personalization_options.html:
- Patch Set #13, Line 115:
```
  label="$i18n{autofillAssistantPref}"
          sub-label="$i18n{autofillAssistantPrefDesc}"
```
  Can these string be removed now from [1]?
  [1] https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/ui/webui/settings/shared_settings_localized_strings_provider.cc;l=207;drc=36cce70fc4f11ab5e34826eb8cc8fdba8931f109

To view, visit change 4055568. To unsubscribe, or for help writing mail filters, visit settings.

Bruno Braga (Gerrit)

unread,

Nov 30, 2022, 7:39:29 AM11/30/22

to chromium-a...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, michaelpg+wa...@chromium.org, vasilii+watchlis...@chromium.org, Demetrios Papadopoulos, Jan Keitel, Markus Heintz, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Demetrios Papadopoulos, Jan Keitel, Markus Heintz.

View Change

1 comment:

File chrome/browser/resources/settings/privacy_page/personalization_options.html:

Patch Set #13, Line 115:

  label="$i18n{autofillAssistantPref}"
          sub-label="$i18n{autofillAssistantPrefDesc}"

- Can these string be removed now from [1]? […]
  Done

To view, visit change 4055568. To unsubscribe, or for help writing mail filters, visit settings.

Bruno Braga (Gerrit)

unread,

Nov 30, 2022, 7:40:39 AM11/30/22

to chromium-a...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, michaelpg+wa...@chromium.org, vasilii+watchlis...@chromium.org, Demetrios Papadopoulos, Jan Keitel, Markus Heintz, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Demetrios Papadopoulos, Jan Keitel, Markus Heintz.

View Change

1 comment:

Patchset:
- Patch Set #14:
  Hi Folks, I have once again lost your lgtm after rebase. Can you please take a look again? =)

To view, visit change 4055568. To unsubscribe, or for help writing mail filters, visit settings.

Jan Keitel (Gerrit)

unread,

Nov 30, 2022, 8:36:42 AM11/30/22

to Bruno Braga, chromium-a...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, michaelpg+wa...@chromium.org, vasilii+watchlis...@chromium.org, Demetrios Papadopoulos, Markus Heintz, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Bruno Braga, Demetrios Papadopoulos, Markus Heintz.

Patch set 14:Code-Review +1

View Change

To view, visit change 4055568. To unsubscribe, or for help writing mail filters, visit settings.

Demetrios Papadopoulos (Gerrit)

unread,

Nov 30, 2022, 3:05:03 PM11/30/22

to Bruno Braga, chromium-a...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, michaelpg+wa...@chromium.org, vasilii+watchlis...@chromium.org, Jan Keitel, Markus Heintz, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Bruno Braga, Markus Heintz.

Patch set 14:Code-Review +1

View Change

To view, visit change 4055568. To unsubscribe, or for help writing mail filters, visit settings.

Markus Heintz (Gerrit)

unread,

Dec 1, 2022, 5:21:06 AM12/1/22

to Bruno Braga, chromium-a...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, michaelpg+wa...@chromium.org, vasilii+watchlis...@chromium.org, Demetrios Papadopoulos, Jan Keitel, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Bruno Braga.

Patch set 14:Code-Review +1

View Change

To view, visit change 4055568. To unsubscribe, or for help writing mail filters, visit settings.

Bruno Braga (Gerrit)

unread,

Dec 1, 2022, 5:23:52 AM12/1/22

to chromium-a...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, michaelpg+wa...@chromium.org, vasilii+watchlis...@chromium.org, Markus Heintz, Demetrios Papadopoulos, Jan Keitel, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Bruno Braga.

Patch set 14:Commit-Queue +2

View Change

To view, visit change 4055568. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Dec 1, 2022, 6:53:42 AM12/1/22

to Bruno Braga, chromium-a...@chromium.org, extension...@chromium.org, gcasto+w...@chromium.org, michaelpg+wa...@chromium.org, vasilii+watchlis...@chromium.org, Markus Heintz, Demetrios Papadopoulos, Jan Keitel, chromium...@chromium.org

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Markus Heintz: Looks good to me
  Jan Keitel: Looks good to me
  Demetrios Papadopoulos: Looks good to me
  Bruno Braga: Commit

[APC Sunset] Remove consent

Bug: 1386065
Change-Id: Ife18c4c0f722729036c2adabe39061cf93d63a12

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4055568
Reviewed-by: Jan Keitel <jke...@google.com>
Commit-Queue: Bruno Braga <bruno...@google.com>
Reviewed-by: Demetrios Papadopoulos <dpa...@chromium.org>
Reviewed-by: Markus Heintz <markus...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1077984}
---
M chrome/app/settings_chromium_strings.grdp
D chrome/app/settings_chromium_strings_grdp/IDS_SETTINGS_AUTOFILL_ASSISTANT_PREF.png.sha1
D chrome/app/settings_chromium_strings_grdp/IDS_SETTINGS_AUTOFILL_ASSISTANT_PREF_DESC.png.sha1
M chrome/app/settings_google_chrome_strings.grdp
D chrome/app/settings_google_chrome_strings_grdp/IDS_SETTINGS_AUTOFILL_ASSISTANT_PREF.png.sha1
D chrome/app/settings_google_chrome_strings_grdp/IDS_SETTINGS_AUTOFILL_ASSISTANT_PREF_DESC.png.sha1


M chrome/browser/autofill_assistant/password_change/apc_onboarding_coordinator_impl.cc
M chrome/browser/autofill_assistant/password_change/apc_onboarding_coordinator_impl_unittest.cc
M chrome/browser/resources/settings/BUILD.gn
M chrome/browser/resources/settings/chromeos/os_settings.gni
M chrome/browser/resources/settings/lazy_load.ts
D chrome/browser/resources/settings/privacy_page/autofill_assistant_browser_proxy.ts

M chrome/browser/resources/settings/privacy_page/personalization_options.html


M chrome/browser/resources/settings/privacy_page/personalization_options.ts
M chrome/browser/ui/BUILD.gn
D chrome/browser/ui/webui/settings/autofill_assistant_handler.cc
D chrome/browser/ui/webui/settings/autofill_assistant_handler.h
M chrome/browser/ui/webui/settings/settings_ui.cc

M chrome/browser/ui/webui/settings/shared_settings_localized_strings_provider.cc


M chrome/test/data/webui/settings/BUILD.gn
M chrome/test/data/webui/settings/personalization_options_test.ts
D chrome/test/data/webui/settings/test_autofill_assistant_browser_proxy.ts
M components/consent_auditor/consent_auditor.h
M components/consent_auditor/consent_auditor_impl.cc
M components/consent_auditor/consent_auditor_impl.h
M components/consent_auditor/consent_auditor_impl_unittest.cc
M components/consent_auditor/fake_consent_auditor.cc
M components/consent_auditor/fake_consent_auditor.h

28 files changed, 21 insertions(+), 529 deletions(-)

To view, visit change 4055568. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward