extensions: Move CloseOverflowMenuIfOpen to platform delegate [chromium/src : main]
0 views
Skip to first unread message
Shuhei Takahashi (Gerrit)
Oct 20, 2025, 8:40:30 PMOct 20
to Shuhei Takahashi, Emilia Paz, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Emilia Paz
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Emilia Paz
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Emilia Paz (Gerrit)
Oct 24, 2025, 1:53:44 PM (11 days ago) Oct 24
to Shuhei Takahashi, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Shuhei Takahashi
Emilia Paz voted and added 1 comment![]( "Open in Gerrit")
Votes added by Emilia Paz
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Emilia Paz . resolved
Thanks! Sorry for the delay on the parent CL
Related details
Attention is currently required from:
- Shuhei Takahashi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Shuhei Takahashi (Gerrit)
Oct 27, 2025, 8:50:53 PM (8 days ago) Oct 27
to Shuhei Takahashi, Emilia Paz, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Shuhei Takahashi voted and added 1 comment![]( "Open in Gerrit")
Votes added by Shuhei Takahashi
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 27, 2025, 9:37:31 PM (8 days ago) Oct 27
to Shuhei Takahashi, Emilia Paz, Code Review Nudger, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
extensions: Move CloseOverflowMenuIfOpen to platform delegate
This is a part of the patch series to move stateful UI logic from
ExtensionActionViewController to ExtensionActionPlatformDelegate.
This is a pure refactor. No functional changes are expected.
Bug: 448199168
Change-Id: I45786bb252773b7c4d6878fc17160c296169e4db
Reviewed-by: Emilia Paz <emil...@chromium.org>
Commit-Queue: Shuhei Takahashi <n...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1536387}
Files:
- M chrome/browser/ui/extensions/extension_action_platform_delegate.h
- M chrome/browser/ui/extensions/extension_action_view_controller.cc
- M chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.cc
- M chrome/browser/ui/views/extensions/extension_action_platform_delegate_views.h
Change size: S
Delta: 4 files changed, 10 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Emilia Paz
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages