Add content setting to bluefin [chromium/src : main]

0 views
Skip to first unread message

Frank Liberato (Gerrit)

unread,
Jun 23, 2026, 9:05:48 PM (2 days ago) Jun 23
to Muyao Xu, Dan H, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, dewitt...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, msrame...@chromium.org
Attention needed from Dan H and Muyao Xu

Frank Liberato added 1 comment

Patchset-level comments
File-level comment, Patchset 13 (Latest):
Frank Liberato . resolved

muyaoxu@ PTAL @ /c/b/g/media
harringtond@ PTAL @ /c/b/glic and /.../glic_page/

thanks
-fl

Open in Gerrit

Related details

Attention is currently required from:
  • Dan H
  • Muyao Xu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic88478a8d5e39aae1348b98b77701beda2d0c8a2
Gerrit-Change-Number: 7828296
Gerrit-PatchSet: 13
Gerrit-Owner: Frank Liberato <libe...@chromium.org>
Gerrit-Reviewer: Dan H <harri...@chromium.org>
Gerrit-Reviewer: Frank Liberato <libe...@chromium.org>
Gerrit-Reviewer: Muyao Xu <muy...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Muyao Xu <muy...@google.com>
Gerrit-Attention: Dan H <harri...@chromium.org>
Gerrit-Comment-Date: Wed, 24 Jun 2026 01:05:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Muyao Xu (Gerrit)

unread,
Jun 24, 2026, 1:39:55 PM (yesterday) Jun 24
to Dan H, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, dewitt...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, msrame...@chromium.org
Attention needed from Dan H and Frank Liberato

Muyao Xu voted and added 1 comment

Votes added by Muyao Xu

Code-Review+1

1 comment

Patchset-level comments
Muyao Xu . resolved

c/b/g/media LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Dan H
  • Frank Liberato
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic88478a8d5e39aae1348b98b77701beda2d0c8a2
    Gerrit-Change-Number: 7828296
    Gerrit-PatchSet: 13
    Gerrit-Owner: Frank Liberato <libe...@chromium.org>
    Gerrit-Reviewer: Dan H <harri...@chromium.org>
    Gerrit-Reviewer: Frank Liberato <libe...@chromium.org>
    Gerrit-Reviewer: Muyao Xu <muy...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Frank Liberato <libe...@chromium.org>
    Gerrit-Attention: Dan H <harri...@chromium.org>
    Gerrit-Comment-Date: Wed, 24 Jun 2026 17:39:43 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Frank Liberato (Gerrit)

    unread,
    6:56 PM (3 hours ago) 6:56 PM
    to Demetrios Papadopoulos, Jan Keitel, Muyao Xu, Dan H, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, dewitt...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, msrame...@chromium.org
    Attention needed from Dan H, Demetrios Papadopoulos and Jan Keitel

    Frank Liberato added 1 comment

    Patchset-level comments
    File-level comment, Patchset 17 (Latest):
    Frank Liberato . resolved

    dpapad@: PTAL @ c/b/e/a/s/prefs_util.cc
    jkeitel@ PTAL @ c/b/u/w/s/settings_localized_strings_provider

    thanks
    -fl

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dan H
    • Demetrios Papadopoulos
    • Jan Keitel
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ic88478a8d5e39aae1348b98b77701beda2d0c8a2
      Gerrit-Change-Number: 7828296
      Gerrit-PatchSet: 17
      Gerrit-Owner: Frank Liberato <libe...@chromium.org>
      Gerrit-Reviewer: Dan H <harri...@chromium.org>
      Gerrit-Reviewer: Demetrios Papadopoulos <dpa...@chromium.org>
      Gerrit-Reviewer: Frank Liberato <libe...@chromium.org>
      Gerrit-Reviewer: Jan Keitel <jke...@google.com>
      Gerrit-Reviewer: Muyao Xu <muy...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-Attention: Demetrios Papadopoulos <dpa...@chromium.org>
      Gerrit-Attention: Jan Keitel <jke...@google.com>
      Gerrit-Attention: Dan H <harri...@chromium.org>
      Gerrit-Comment-Date: Thu, 25 Jun 2026 22:55:51 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Frank Liberato (Gerrit)

      unread,
      6:58 PM (2 hours ago) 6:58 PM
      to Dan H, Demetrios Papadopoulos, Jan Keitel, Muyao Xu, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, dewitt...@chromium.org, dullweb...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, msrame...@chromium.org
      Attention needed from Demetrios Papadopoulos and Jan Keitel

      Frank Liberato added 1 comment

      Patchset-level comments
      Frank Liberato . resolved

      danh => cc sinc jkeitel@ owns a superset of files.

      @jkeitel, PTAL @ everything you own. sorry about the churn.

      thanks
      -fl

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Demetrios Papadopoulos
      • Jan Keitel
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ic88478a8d5e39aae1348b98b77701beda2d0c8a2
      Gerrit-Change-Number: 7828296
      Gerrit-PatchSet: 17
      Gerrit-Owner: Frank Liberato <libe...@chromium.org>
      Gerrit-Reviewer: Demetrios Papadopoulos <dpa...@chromium.org>
      Gerrit-Reviewer: Frank Liberato <libe...@chromium.org>
      Gerrit-Reviewer: Jan Keitel <jke...@google.com>
      Gerrit-Reviewer: Muyao Xu <muy...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Dan H <harri...@chromium.org>
      Gerrit-Attention: Demetrios Papadopoulos <dpa...@chromium.org>
      Gerrit-Attention: Jan Keitel <jke...@google.com>
      Gerrit-Comment-Date: Thu, 25 Jun 2026 22:58:08 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages