[Extensions] Create a separate GN target for commands API [chromium/src : main]
0 views
Skip to first unread message
Devlin Cronin (Gerrit)
Jan 7, 2026, 7:58:33 PM (2 days ago) Jan 7
to Devlin Cronin, Tim, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Tim
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Tim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tim (Gerrit)
Jan 8, 2026, 1:57:58 PM (21 hours ago) Jan 8
to Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Devlin Cronin
Tim voted and added 1 comment![]( "Open in Gerrit")
Votes added by Tim
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Tim . resolved
LGTM, thanks for continuing down this one!
Taking a step back for the broader goal here, would it be possible to describe on the bug the process for pulling one of these out, so we can more easily shard out the work? e.g. how to work out the sources, configs and deps required for one of these?
Related details
Attention is currently required from:
- Devlin Cronin
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devlin Cronin (Gerrit)
Jan 8, 2026, 2:00:15 PM (21 hours ago) Jan 8
to Devlin Cronin, Tim, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Devlin Cronin voted and added 2 comments![]( "Open in Gerrit")
Votes added by Devlin Cronin
| Commit-Queue | +2 |
2 comments
Patchset-level comments
Tim . resolved
LGTM, thanks for continuing down this one!
Taking a step back for the broader goal here, would it be possible to describe on the bug the process for pulling one of these out, so we can more easily shard out the work? e.g. how to work out the sources, configs and deps required for one of these?
Devlin Cronin
I should do that! I'll add it to my list for tomorrow.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 8, 2026, 2:03:38 PM (21 hours ago) Jan 8
to Devlin Cronin, Tim, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[Extensions] Create a separate GN target for commands API
The commands API is currently compiled as part of the larger
//chrome/browser/extensions target, but no longer needs to be.
Instead, have a separate GN target for it in
//chrome/browser/extensions/api/commands.
Bug: 40245282
Change-Id: I7d0cdc1bef15e8f0f61a9291cf6bb8350b5f0f15
Reviewed-by: Tim <tjud...@chromium.org>
Commit-Queue: Devlin Cronin <rdevlin...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1566436}
Files:
- M chrome/browser/extensions/BUILD.gn
- M chrome/browser/extensions/api/BUILD.gn
- A chrome/browser/extensions/api/commands/BUILD.gn
Change size: S
Delta: 3 files changed, 25 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Tim
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages