[ThinWebView] Allow attach contextMenuPopulatorFactory to thinWebView [chromium/src : main]

0 views
Skip to first unread message

Hitarth Kothari (Gerrit)

unread,
Feb 12, 2026, 11:38:10 AM (8 days ago) Feb 12
to Shakti Sahu, AyeAye, chromium...@chromium.org, jeffreycohen+...@chromium.org, wry+watc...@chromium.org, extension...@chromium.org, sophey+wat...@chromium.org, hanxi...@chromium.org, chromium-a...@chromium.org, peilinwa...@google.com, wiss+watc...@chromium.org, ayman...@chromium.org, feature-me...@chromium.org, mdjone...@chromium.org, sloboda...@chromium.org, yuezhang...@chromium.org
Attention needed from Shakti Sahu

Hitarth Kothari voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Shakti Sahu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2517d782e89f74e5019708961de3126e5e647d0a
Gerrit-Change-Number: 7567975
Gerrit-PatchSet: 4
Gerrit-Owner: Hitarth Kothari <hitarth...@google.com>
Gerrit-Reviewer: Hitarth Kothari <hitarth...@google.com>
Gerrit-Reviewer: Shakti Sahu <shakt...@chromium.org>
Gerrit-Attention: Shakti Sahu <shakt...@chromium.org>
Gerrit-Comment-Date: Thu, 12 Feb 2026 16:38:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Hitarth Kothari (Gerrit)

unread,
Feb 19, 2026, 11:21:53 AM (16 hours ago) Feb 19
to Chromium LUCI CQ, Shakti Sahu, AyeAye, chromium...@chromium.org, jeffreycohen+...@chromium.org, wry+watc...@chromium.org, extension...@chromium.org, sophey+wat...@chromium.org, hanxi...@chromium.org, chromium-a...@chromium.org, peilinwa...@google.com, wiss+watc...@chromium.org, ayman...@chromium.org, feature-me...@chromium.org, mdjone...@chromium.org, sloboda...@chromium.org, yuezhang...@chromium.org
Attention needed from Shakti Sahu

Hitarth Kothari voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Shakti Sahu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2517d782e89f74e5019708961de3126e5e647d0a
Gerrit-Change-Number: 7567975
Gerrit-PatchSet: 8
Gerrit-Owner: Hitarth Kothari <hitarth...@google.com>
Gerrit-Reviewer: Hitarth Kothari <hitarth...@google.com>
Gerrit-Reviewer: Shakti Sahu <shakt...@chromium.org>
Gerrit-Attention: Shakti Sahu <shakt...@chromium.org>
Gerrit-Comment-Date: Thu, 19 Feb 2026 16:21:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Shakti Sahu (Gerrit)

unread,
Feb 19, 2026, 9:48:50 PM (5 hours ago) Feb 19
to Hitarth Kothari, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, wychen...@chromium.org, gogeral...@chromium.org, yusufo...@chromium.org, davidj...@chromium.org, meilian...@chromium.org, mattsimm...@chromium.org, jeffreycohen+...@chromium.org, wry+watc...@chromium.org, extension...@chromium.org, sophey+wat...@chromium.org, hanxi...@chromium.org, chromium-a...@chromium.org, peilinwa...@google.com, wiss+watc...@chromium.org, ayman...@chromium.org, feature-me...@chromium.org, mdjone...@chromium.org, sloboda...@chromium.org, yuezhang...@chromium.org
Attention needed from Hitarth Kothari

Shakti Sahu added 1 comment

File components/thin_webview/java/src/org/chromium/components/thinwebview/ThinWebView.java
Line 37, Patchset 10 (Latest): void attachWebContents(
WebContents webContents,
@Nullable View contentView,
@Nullable WebContentsDelegateAndroid delegate,
@Nullable ContextMenuPopulatorFactory contextMenuPopulatorFactory);
Shakti Sahu . unresolved

Alternatively, we can also provide a overloaded method that comes with `contextMenuPopulatorFactory` so that we dont have to touch all the clients of TWV.
Otherwise, I suspect we will have to revisit the param list multiple times in next few weeks.

Open in Gerrit

Related details

Attention is currently required from:
  • Hitarth Kothari
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2517d782e89f74e5019708961de3126e5e647d0a
    Gerrit-Change-Number: 7567975
    Gerrit-PatchSet: 10
    Gerrit-Owner: Hitarth Kothari <hitarth...@google.com>
    Gerrit-Reviewer: Hitarth Kothari <hitarth...@google.com>
    Gerrit-Reviewer: Shakti Sahu <shakt...@chromium.org>
    Gerrit-Attention: Hitarth Kothari <hitarth...@google.com>
    Gerrit-Comment-Date: Fri, 20 Feb 2026 02:48:44 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages