Justin Lulejian (Gerrit)

unread,

Jan 22, 2026, 1:50:19 PM (8 days ago) Jan 22

to Andrea Orru, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Andrea Orru

Justin Lulejian added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Justin Lulejian . resolved

Hi Andrea! Had a simple feature combine commit when you have a moment. The trybots passed on the first patchset, but I realized there was a redundant "public:" I could remove too while I was in messaging_apitest.cc. So the trybots are running again, but I think we can treat this as if the trybots have passed for review purposes. Thanks!

Open in Gerrit

Related details

Attention is currently required from:

Andrea Orru

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Andrea Orru (Gerrit)

unread,

Jan 22, 2026, 1:59:38 PM (8 days ago) Jan 22

to Justin Lulejian, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Attention needed from Justin Lulejian

Andrea Orru voted and added 2 comments

Votes added by Andrea Orru

Code-Review

+1

2 comments

File chrome/browser/extensions/api/messaging/messaging_apitest.cc

Line 1067, Patchset 3 (Latest):

Andrea Orru . unresolved

nit: rm \n

File extensions/common/extension_features.h

Line 258, Patchset 3 (Latest):// `loadTimes` , `csi`, etc. or deprecated APIs (e.g. `app`).

Andrea Orru . unresolved

nit: extra space

Open in Gerrit

Related details

Attention is currently required from:

Justin Lulejian

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Justin Lulejian (Gerrit)

unread,

Jan 22, 2026, 6:45:06 PM (8 days ago) Jan 22

to Andrea Orru, Devlin Cronin, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Justin Lulejian added 2 comments

File chrome/browser/extensions/api/messaging/messaging_apitest.cc

Line 1067, Patchset 3:

Andrea Orru . resolved

nit: rm \n

Justin Lulejian

Done

File extensions/common/extension_features.h

Line 258, Patchset 3:// `loadTimes` , `csi`, etc. or deprecated APIs (e.g. `app`).

Andrea Orru . resolved

nit: extra space

Justin Lulejian

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jan 30, 2026, 6:23:57 PM (6 hours ago) Jan 30

to Justin Lulejian, Devlin Cronin, Andrea Orru, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: chrome/browser/extensions/api/messaging/messaging_apitest.cc
Insertions: 0, Deletions: 1.

The diff is too large to show. Please review the diff.
```
```
The name of the file: extensions/common/extension_features.h
Insertions: 1, Deletions: 1.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:

[Extensions] Combine polyfill and browser namespace features.

Merges kRuntimeOnMessageWebExtensionPolyfillSupport and
kExtensionBrowserNamespaceAlternative into a single feature
kExtensionBrowserNamespaceAndPolyfillSupport. Updates references in the
renderer, common definitions, and tests to use the new feature flag.

This change, other than combining the features so now that one controls
both behaviors, should not change any existing behavior when the flag is
enabled or disabled.

Bug: 401226626,439644930,40753031

Change-Id: Ic2998e3c703c0f1c18183ec73556486ddc33a3c6

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7508354

Commit-Queue: Justin Lulejian <jlul...@chromium.org>

Reviewed-by: Andrea Orru <andre...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1577590}

Files:

M chrome/browser/extensions/api/messaging/messaging_apitest.cc
M chrome/browser/extensions/native_bindings_apitest.cc
M extensions/common/extension_features.cc
M extensions/common/extension_features.h
M extensions/renderer/api/messaging/one_time_message_handler.cc
M extensions/renderer/api/messaging/one_time_message_handler.h
M extensions/renderer/api/messaging/one_time_message_handler_unittest.cc
M extensions/renderer/native_extension_bindings_system.cc
M extensions/renderer/native_extension_bindings_system_unittest.cc

Change size: M

Delta: 9 files changed, 32 insertions(+), 39 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Andrea Orru

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[Extensions] Combine polyfill and browser namespace features. [chromium/src : main]

Justin Lulejian (Gerrit)

Justin Lulejian added 1 comment

Related details

Andrea Orru (Gerrit)

Andrea Orru voted and added 2 comments

Votes added by Andrea Orru

2 comments

Related details

Justin Lulejian (Gerrit)

Justin Lulejian added 2 comments

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information