Handle ASR stream disconnection in OnDeviceModel service [chromium/src : main]
0 views
Skip to first unread message
Evan Liu (Gerrit)
Aug 14, 2026, 4:14:45 PM (2 days ago) Aug 14
to Steven Holte, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, feature-me...@chromium.org
Attention needed from Steven Holte
Evan Liu voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Steven Holte
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Steven Holte (Gerrit)
Aug 14, 2026, 7:13:33 PM (2 days ago) Aug 14
to Evan Liu, Steven Holte, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, feature-me...@chromium.org
Attention needed from Evan Liu
Steven Holte voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Evan Liu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Evan Liu (Gerrit)
Aug 14, 2026, 7:21:31 PM (2 days ago) Aug 14
to Steven Holte, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, feature-me...@chromium.org
Evan Liu voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Aug 14, 2026, 7:26:13 PM (2 days ago) Aug 14
to Evan Liu, Steven Holte, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, feature-me...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Handle ASR stream disconnection in OnDeviceModel service
This CL makes several improvements to ASR streaming in OnDeviceModelMojomImpl:
1. Adds a disconnect handler to AsrStreamWrapper so that when an AsrStreamInput pipe disconnects, the SessionWrapper is notified to clean up backend model sessions and reclaim resources.
2. Removes the DCHECK
asserting asr_session_ is null in AsrStreamInternal to allow an existing SessionWrapper to be safely reused across subsequent or restarted ASR audio streams.
Bug: 545294347
Change-Id: I58cadcade7b03589f6ed03338cf942b2657f8891
Reviewed-by: Steven Holte <ho...@chromium.org>
Commit-Queue: Evan Liu <ev...@google.com>
Cr-Commit-Position: refs/heads/main@{#1680010}
Files:
- M services/on_device_model/ml/on_device_model_executor.cc
- M services/on_device_model/ml/session_accessor.cc
- M services/on_device_model/on_device_model_mojom_impl.cc
- M services/on_device_model/on_device_model_mojom_impl.h
- M services/on_device_model/on_device_model_service_unittest.cc
Change size: M
Delta: 5 files changed, 141 insertions(+), 11 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Steven Holte
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages