EIPS: implement UserMayLoad(), MustRemainDisabled() [chromium/src : main]
0 views
Skip to first unread message
Nicolas Ouellet-Payeur (Gerrit)
Jan 29, 2026, 2:04:02 PM (2 days ago) Jan 29
to Yann Dago, Chromium LUCI CQ, Enterprise Policy Reviews, AyeAye, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Yann Dago
Nicolas Ouellet-Payeur added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Yann Dago
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yann Dago (Gerrit)
Jan 29, 2026, 2:55:25 PM (2 days ago) Jan 29
to Nicolas Ouellet-Payeur, Chromium LUCI CQ, Enterprise Policy Reviews, AyeAye, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Nicolas Ouellet-Payeur
Yann Dago added 1 comment![]( "Open in Gerrit")
File components/policy/core/common/cloud/cloud_policy_client_types.cc
Line 81, Patchset 10 (Parent):
auto extension_ids_and_version =
std::get<ExtensionsProviderRef>(extra_param_)->GetExtensions();
if (extension_ids_and_version.size() == 1) {
return extension_ids_and_version.begin()->ToString();
}Yann Dago . unresolved
this will break some tests, I think that comes from how the test server was implememented when we needed t he settings entity I'd in the request before deciding we did not need it
Related details
Attention is currently required from:
- Nicolas Ouellet-Payeur
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicolas Ouellet-Payeur (Gerrit)
Jan 30, 2026, 11:54:43 AM (13 hours ago) Jan 30
to Yann Dago, Chromium LUCI CQ, Enterprise Policy Reviews, AyeAye, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Yann Dago
Nicolas Ouellet-Payeur added 1 comment![]( "Open in Gerrit")
File components/policy/core/common/cloud/cloud_policy_client_types.cc
Line 81, Patchset 10 (Parent):
auto extension_ids_and_version =
std::get<ExtensionsProviderRef>(extra_param_)->GetExtensions();
if (extension_ids_and_version.size() == 1) {
return extension_ids_and_version.begin()->ToString();
}Yann Dago . resolved
this will break some tests, I think that comes from how the test server was implememented when we needed t he settings entity I'd in the request before deciding we did not need it
Attention is currently required from:
- Yann Dago
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yann Dago (Gerrit)
Jan 30, 2026, 1:45:12 PM (11 hours ago) Jan 30
to Nicolas Ouellet-Payeur, Chromium LUCI CQ, Enterprise Policy Reviews, AyeAye, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Nicolas Ouellet-Payeur
Yann Dago voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Nicolas Ouellet-Payeur
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 30, 2026, 3:36:16 PM (9 hours ago) Jan 30
to Nicolas Ouellet-Payeur, Yann Dago, Enterprise Policy Reviews, AyeAye, chromium-a...@chromium.org, extension...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
12 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
EIPS: implement UserMayLoad(), MustRemainDisabled()
Also don't send `settings_entity_id` if there's exactly one extension
installed.
Bug: 477545526
Change-Id: I3dc10df411de2d189ffcaad2d783a7244b868518
Reviewed-by: Yann Dago <yd...@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nico...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1577478}
Files:
- M chrome/browser/policy/cloud/extension_install_policy_service.cc
- M components/policy/core/common/cloud/cloud_policy_client_types.cc
- M components/policy/core/common/cloud/cloud_policy_client_unittest.cc
- M components/policy/core/common/cloud/cloud_policy_service.cc
Change size: S
Delta: 4 files changed, 6 insertions(+), 12 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yann Dago
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages