Extensions: WAR: GUID: Ignore use_dynamic_url if extension feature off [chromium/src : main]
4 views
Skip to first unread message
Solomon Kinard (Gerrit)
Jul 26, 2024, 6:41:19 PM7/26/24
to chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Solomon Kinard has uploaded the change for review![]( "Open in Gerrit")
Commit message
Extensions: WAR: GUID: Ignore use_dynamic_url if extension feature off
The extension feature was not being checked during manifest parsing.
This aims to resolve that. It was already being checked when
chrome.runtime.getURL() was called and then making subsequent navigation
decisions. This CL also aims to be merged into the branch cut that
occurred about three days ago.
Doc:
https://docs.google.com/document/d/1ycwgcpdeIQYH-xH1iDjvIaEm32La4baFbDGYgtPjkFo
Bug: chromium:354748637, chromium:355668502
Change-Id: I33d1914674f548a44ed8c5e38f8ada8c00988cd4
Change diff
Change information
Files:
- M chrome/browser/extensions/web_accessible_resources_browsertest.cc
- M extensions/common/manifest_handlers/web_accessible_resources_info.cc
Change size: M
Delta: 2 files changed, 80 insertions(+), 1 deletion(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Solomon Kinard (Gerrit)
Jul 26, 2024, 6:57:14 PM7/26/24
to Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Solomon Kinard voted and added 1 comment![]( "Open in Gerrit")
Votes added by Solomon Kinard
| Commit-Queue | +0 |
1 comment
File chrome/browser/extensions/web_accessible_resources_browsertest.cc
Line 197, Patchset 1 (Latest):
// If `use_dynamic_url` is set to true in manifest.json, then the associated web
// accessible resource(s) can only be loaded using the dynamic url. Loading with
// the static url containing the extension id won't work.Solomon Kinard . unresolved
fsfdgsdf
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Solomon Kinard (Gerrit)
Jul 26, 2024, 8:50:26 PM7/26/24
to Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Solomon Kinard abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages