[bedrock] FindTabbedBrowser() function call point refactoring [chromium/src : main]

0 views
Skip to first unread message

Yu He (Gerrit)

unread,
Mar 10, 2026, 3:35:38 AM (2 days ago) Mar 10
to AyeAye, Qikai Zhong, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, mdjone...@chromium.org, zelin+watch-we...@chromium.org, dmurph+watc...@chromium.org, philli...@chromium.org, loyso...@chromium.org, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, kuragin+web-ap...@chromium.org, ayman...@chromium.org, japhet+...@chromium.org, webap...@microsoft.com, mek+w...@chromium.org, dewitt...@chromium.org, yuezhang...@chromium.org, mgiuca...@chromium.org, extension...@chromium.org, dmurph+wat...@chromium.org
Attention needed from Qikai Zhong

Yu He added 2 comments

Commit Message
Line 7, Patchset 1:FindTabbedBrowser() function call point refactoring
Qikai Zhong . resolved

nit: Please briefly explain why and what was done.

Yu He

fixed

File chrome/browser/ui/scoped_tabbed_browser_displayer.h
Line 9, Patchset 1:#include "chrome/browser/ui/browser_window/public/browser_window_interface.h"
Qikai Zhong . resolved

nit: Please use forward declarations whenever possible.

Yu He

fixed

Open in Gerrit

Related details

Attention is currently required from:
  • Qikai Zhong
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iffb72e0da8c71ca3fe6021242dcb068b6d5eeb01
Gerrit-Change-Number: 7645602
Gerrit-PatchSet: 5
Gerrit-Owner: Yu He <y...@microsoft.com>
Gerrit-Reviewer: Yu He <y...@microsoft.com>
Gerrit-CC: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
Gerrit-Comment-Date: Tue, 10 Mar 2026 07:35:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Qikai Zhong <qikai...@microsoft.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Qikai Zhong (Gerrit)

unread,
Mar 11, 2026, 4:24:56 AM (yesterday) Mar 11
to Yu He, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, mdjone...@chromium.org, zelin+watch-we...@chromium.org, dmurph+watc...@chromium.org, philli...@chromium.org, loyso...@chromium.org, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, kuragin+web-ap...@chromium.org, ayman...@chromium.org, japhet+...@chromium.org, webap...@microsoft.com, mek+w...@chromium.org, dewitt...@chromium.org, yuezhang...@chromium.org, mgiuca...@chromium.org, extension...@chromium.org, dmurph+wat...@chromium.org
Attention needed from Yu He

Qikai Zhong added 5 comments

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Qikai Zhong . resolved

Hi, leave some comment.

File chrome/browser/ssl/chrome_security_blocking_page_factory.cc
Line 442, Patchset 7 (Latest): return browser->GetBrowserForMigrationOnly();
Qikai Zhong . unresolved

nit: We can try to avoid use GetBrowserForMigrationOnly() by change return type of this lambda. Thanks~

File chrome/browser/ui/browser_commands.cc
Line 2519, Patchset 7 (Latest): target_browser->GetBrowserForMigrationOnly());
Qikai Zhong . unresolved
```
void ReparentWebContentsIntoBrowserImpl(Browser* source_browser,
                                        content::WebContents* web_contents,
                                        BrowserWindowInterface* target_browser,
                                        bool insert_as_pinned_home_tab) {
```
nit: Seems do not need to use the first target_browser->GetBrowserForMigrationOnly() here.
File chrome/browser/ui/scoped_tabbed_browser_displayer.cc
Line 24, Patchset 7 (Latest): if (!browser_) {
return nullptr;
}
Qikai Zhong . unresolved

nit: Is this necessary?

File chrome/browser/ui/web_applications/navigation_capturing_process.cc
Line 211, Patchset 7 (Latest): : existing_browser_window->GetBrowserForMigrationOnly();
Qikai Zhong . unresolved

nit: target_browser_window can simply migrate to BrowserWindowInterface* here.

Open in Gerrit

Related details

Attention is currently required from:
  • Yu He
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iffb72e0da8c71ca3fe6021242dcb068b6d5eeb01
    Gerrit-Change-Number: 7645602
    Gerrit-PatchSet: 7
    Gerrit-Owner: Yu He <y...@microsoft.com>
    Gerrit-Reviewer: Yu He <y...@microsoft.com>
    Gerrit-CC: Qikai Zhong <qikai...@microsoft.com>
    Gerrit-Attention: Yu He <y...@microsoft.com>
    Gerrit-Comment-Date: Wed, 11 Mar 2026 08:24:26 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Yu He (Gerrit)

    unread,
    Mar 11, 2026, 5:16:09 AM (yesterday) Mar 11
    to AyeAye, Qikai Zhong, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, mdjone...@chromium.org, zelin+watch-we...@chromium.org, dmurph+watc...@chromium.org, philli...@chromium.org, loyso...@chromium.org, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, kuragin+web-ap...@chromium.org, ayman...@chromium.org, japhet+...@chromium.org, webap...@microsoft.com, mek+w...@chromium.org, dewitt...@chromium.org, yuezhang...@chromium.org, mgiuca...@chromium.org, extension...@chromium.org, dmurph+wat...@chromium.org
    Attention needed from Qikai Zhong

    Yu He added 4 comments

    File chrome/browser/ssl/chrome_security_blocking_page_factory.cc
    Line 442, Patchset 7: return browser->GetBrowserForMigrationOnly();
    Qikai Zhong . unresolved

    nit: We can try to avoid use GetBrowserForMigrationOnly() by change return type of this lambda. Thanks~

    Yu He

    fixed

    File chrome/browser/ui/browser_commands.cc
    Line 2519, Patchset 7: target_browser->GetBrowserForMigrationOnly());
    Qikai Zhong . unresolved
    ```
    void ReparentWebContentsIntoBrowserImpl(Browser* source_browser,
                                            content::WebContents* web_contents,
                                            BrowserWindowInterface* target_browser,
                                            bool insert_as_pinned_home_tab) {
    ```
    nit: Seems do not need to use the first target_browser->GetBrowserForMigrationOnly() here.
    Yu He

    agree

    File chrome/browser/ui/scoped_tabbed_browser_displayer.cc
    Line 24, Patchset 7: if (!browser_) {
    return nullptr;
    }
    Qikai Zhong . unresolved

    nit: Is this necessary?

    Yu He

    Yes, previously, this function return 'browser_' and the called function it will check browser pointer, but now return type became 'browser_->GetBrowserForMigrationOnly()', we should check 'browser_' pointer, here `browser_` is dereferenced.

    File chrome/browser/ui/web_applications/navigation_capturing_process.cc
    Line 211, Patchset 7: : existing_browser_window->GetBrowserForMigrationOnly();
    Qikai Zhong . unresolved

    nit: target_browser_window can simply migrate to BrowserWindowInterface* here.

    Yu He

    fixed.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Qikai Zhong
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iffb72e0da8c71ca3fe6021242dcb068b6d5eeb01
    Gerrit-Change-Number: 7645602
    Gerrit-PatchSet: 8
    Gerrit-Owner: Yu He <y...@microsoft.com>
    Gerrit-Reviewer: Yu He <y...@microsoft.com>
    Gerrit-CC: Qikai Zhong <qikai...@microsoft.com>
    Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
    Gerrit-Comment-Date: Wed, 11 Mar 2026 09:15:41 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Qikai Zhong <qikai...@microsoft.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Yu He (Gerrit)

    unread,
    Mar 11, 2026, 6:01:46 AM (yesterday) Mar 11
    to AyeAye, Qikai Zhong, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, mdjone...@chromium.org, zelin+watch-we...@chromium.org, dmurph+watc...@chromium.org, philli...@chromium.org, loyso...@chromium.org, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, kuragin+web-ap...@chromium.org, ayman...@chromium.org, japhet+...@chromium.org, webap...@microsoft.com, mek+w...@chromium.org, dewitt...@chromium.org, yuezhang...@chromium.org, mgiuca...@chromium.org, extension...@chromium.org, dmurph+wat...@chromium.org
    Attention needed from Qikai Zhong

    Yu He added 1 comment

    File chrome/browser/ssl/chrome_security_blocking_page_factory.cc
    Line 442, Patchset 7: return browser->GetBrowserForMigrationOnly();
    Qikai Zhong . unresolved

    nit: We can try to avoid use GetBrowserForMigrationOnly() by change return type of this lambda. Thanks~

    Yu He

    fixed

    Yu He

    I think we can't avoid GetBrowserForMigrationOnly().
    A lambda expression returns a BrowserWindowInterface*, while a FunctionRef requires a Browser*. A BrowserWindowInterface* (the parent class) cannot be implicitly cast to a Browser* (the subclass).

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Qikai Zhong
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iffb72e0da8c71ca3fe6021242dcb068b6d5eeb01
    Gerrit-Change-Number: 7645602
    Gerrit-PatchSet: 10
    Gerrit-Owner: Yu He <y...@microsoft.com>
    Gerrit-Reviewer: Yu He <y...@microsoft.com>
    Gerrit-CC: Qikai Zhong <qikai...@microsoft.com>
    Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
    Gerrit-Comment-Date: Wed, 11 Mar 2026 10:01:25 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Yu He <y...@microsoft.com>
    Comment-In-Reply-To: Qikai Zhong <qikai...@microsoft.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Qikai Zhong (Gerrit)

    unread,
    Mar 11, 2026, 8:21:35 AM (yesterday) Mar 11
    to Yu He, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, mdjone...@chromium.org, zelin+watch-we...@chromium.org, dmurph+watc...@chromium.org, philli...@chromium.org, loyso...@chromium.org, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, kuragin+web-ap...@chromium.org, ayman...@chromium.org, japhet+...@chromium.org, webap...@microsoft.com, mek+w...@chromium.org, dewitt...@chromium.org, yuezhang...@chromium.org, mgiuca...@chromium.org, extension...@chromium.org, dmurph+wat...@chromium.org
    Attention needed from Yu He

    Qikai Zhong added 1 comment

    File chrome/browser/ui/webui/app_settings/web_app_settings_ui.cc
    Line 112, Patchset 10 (Latest): gfx::NativeWindow GetUninstallAnchorWindow() const override {
    return chrome::FindTabbedBrowser(profile_, false)
    ->GetWindow()
    ->GetNativeWindow();
    }
    Qikai Zhong . unresolved
    nit: FindTabbedBrowser may return nullptr, while we’re here, we can add an extra layer of protection.
    ```
    gfx::NativeWindow GetUninstallAnchorWindow() const override {
      BrowserWindowInterface* browser =
          chrome::FindTabbedBrowser(profile_, false);
      return browser ? browser->GetWindow()->GetNativeWindow() : nullptr;
    }
    ```
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Yu He
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iffb72e0da8c71ca3fe6021242dcb068b6d5eeb01
    Gerrit-Change-Number: 7645602
    Gerrit-PatchSet: 10
    Gerrit-Owner: Yu He <y...@microsoft.com>
    Gerrit-Reviewer: Yu He <y...@microsoft.com>
    Gerrit-CC: Qikai Zhong <qikai...@microsoft.com>
    Gerrit-Attention: Yu He <y...@microsoft.com>
    Gerrit-Comment-Date: Wed, 11 Mar 2026 12:21:03 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Yu He (Gerrit)

    unread,
    Mar 11, 2026, 10:36:35 PM (14 hours ago) Mar 11
    to AyeAye, Qikai Zhong, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, mdjone...@chromium.org, zelin+watch-we...@chromium.org, dmurph+watc...@chromium.org, philli...@chromium.org, loyso...@chromium.org, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, kuragin+web-ap...@chromium.org, ayman...@chromium.org, japhet+...@chromium.org, webap...@microsoft.com, mek+w...@chromium.org, dewitt...@chromium.org, yuezhang...@chromium.org, mgiuca...@chromium.org, extension...@chromium.org, dmurph+wat...@chromium.org
    Attention needed from Qikai Zhong

    Yu He added 1 comment

    File chrome/browser/ui/webui/app_settings/web_app_settings_ui.cc
    Line 112, Patchset 10 (Latest): gfx::NativeWindow GetUninstallAnchorWindow() const override {
    return chrome::FindTabbedBrowser(profile_, false)
    ->GetWindow()
    ->GetNativeWindow();
    }
    Qikai Zhong . unresolved
    nit: FindTabbedBrowser may return nullptr, while we’re here, we can add an extra layer of protection.
    ```
    gfx::NativeWindow GetUninstallAnchorWindow() const override {
      BrowserWindowInterface* browser =
          chrome::FindTabbedBrowser(profile_, false);
      return browser ? browser->GetWindow()->GetNativeWindow() : nullptr;
    }
    ```
    Yu He

    fixed

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Qikai Zhong
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iffb72e0da8c71ca3fe6021242dcb068b6d5eeb01
    Gerrit-Change-Number: 7645602
    Gerrit-PatchSet: 10
    Gerrit-Owner: Yu He <y...@microsoft.com>
    Gerrit-Reviewer: Yu He <y...@microsoft.com>
    Gerrit-CC: Qikai Zhong <qikai...@microsoft.com>
    Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
    Gerrit-Comment-Date: Thu, 12 Mar 2026 02:36:07 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Qikai Zhong <qikai...@microsoft.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Yu He (Gerrit)

    unread,
    Mar 11, 2026, 11:51:34 PM (12 hours ago) Mar 11
    to AyeAye, Qikai Zhong, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, mdjone...@chromium.org, zelin+watch-we...@chromium.org, dmurph+watc...@chromium.org, philli...@chromium.org, loyso...@chromium.org, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, kuragin+web-ap...@chromium.org, ayman...@chromium.org, japhet+...@chromium.org, webap...@microsoft.com, mek+w...@chromium.org, dewitt...@chromium.org, yuezhang...@chromium.org, mgiuca...@chromium.org, extension...@chromium.org, dmurph+wat...@chromium.org
    Attention needed from Qikai Zhong

    Yu He added 4 comments

    File chrome/browser/ui/browser_commands.cc
    Line 2519, Patchset 7: target_browser->GetBrowserForMigrationOnly());
    Qikai Zhong . resolved
    ```
    void ReparentWebContentsIntoBrowserImpl(Browser* source_browser,
                                            content::WebContents* web_contents,
                                            BrowserWindowInterface* target_browser,
                                            bool insert_as_pinned_home_tab) {
    ```
    nit: Seems do not need to use the first target_browser->GetBrowserForMigrationOnly() here.
    Yu He

    agree

    Yu He

    Done

    File chrome/browser/ui/scoped_tabbed_browser_displayer.cc
    Line 24, Patchset 7: if (!browser_) {
    return nullptr;
    }
    Qikai Zhong . resolved

    nit: Is this necessary?

    Yu He

    Yes, previously, this function return 'browser_' and the called function it will check browser pointer, but now return type became 'browser_->GetBrowserForMigrationOnly()', we should check 'browser_' pointer, here `browser_` is dereferenced.

    Yu He

    Done

    File chrome/browser/ui/web_applications/navigation_capturing_process.cc
    Line 211, Patchset 7: : existing_browser_window->GetBrowserForMigrationOnly();
    Qikai Zhong . resolved

    nit: target_browser_window can simply migrate to BrowserWindowInterface* here.

    Yu He

    fixed.

    Yu He

    Done

    File chrome/browser/ui/webui/app_settings/web_app_settings_ui.cc
    Line 112, Patchset 10: gfx::NativeWindow GetUninstallAnchorWindow() const override {

    return chrome::FindTabbedBrowser(profile_, false)
    ->GetWindow()
    ->GetNativeWindow();
    }
    Qikai Zhong . resolved
    nit: FindTabbedBrowser may return nullptr, while we’re here, we can add an extra layer of protection.
    ```
    gfx::NativeWindow GetUninstallAnchorWindow() const override {
      BrowserWindowInterface* browser =
          chrome::FindTabbedBrowser(profile_, false);
      return browser ? browser->GetWindow()->GetNativeWindow() : nullptr;
    }
    ```
    Yu He

    fixed

    Yu He

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Qikai Zhong
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iffb72e0da8c71ca3fe6021242dcb068b6d5eeb01
    Gerrit-Change-Number: 7645602
    Gerrit-PatchSet: 11
    Gerrit-Owner: Yu He <y...@microsoft.com>
    Gerrit-Reviewer: Yu He <y...@microsoft.com>
    Gerrit-CC: Qikai Zhong <qikai...@microsoft.com>
    Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
    Gerrit-Comment-Date: Thu, 12 Mar 2026 03:51:04 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Yu He (Gerrit)

    unread,
    4:20 AM (8 hours ago) 4:20 AM
    to AyeAye, Qikai Zhong, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, mdjone...@chromium.org, zelin+watch-we...@chromium.org, dmurph+watc...@chromium.org, philli...@chromium.org, loyso...@chromium.org, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, kuragin+web-ap...@chromium.org, ayman...@chromium.org, japhet+...@chromium.org, webap...@microsoft.com, mek+w...@chromium.org, dewitt...@chromium.org, yuezhang...@chromium.org, mgiuca...@chromium.org, extension...@chromium.org, dmurph+wat...@chromium.org
    Attention needed from Qikai Zhong

    Yu He voted and added 1 comment

    Votes added by Yu He

    Commit-Queue+1

    1 comment

    File chrome/browser/ssl/chrome_security_blocking_page_factory.cc
    Line 442, Patchset 7: return browser->GetBrowserForMigrationOnly();
    Qikai Zhong . resolved

    nit: We can try to avoid use GetBrowserForMigrationOnly() by change return type of this lambda. Thanks~

    Yu He

    fixed

    Yu He

    I think we can't avoid GetBrowserForMigrationOnly().


    A lambda expression returns a BrowserWindowInterface*, while a FunctionRef requires a Browser*. A BrowserWindowInterface* (the parent class) cannot be implicitly cast to a Browser* (the subclass).

    Related details

    Attention is currently required from:
    • Qikai Zhong
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iffb72e0da8c71ca3fe6021242dcb068b6d5eeb01
      Gerrit-Change-Number: 7645602
      Gerrit-PatchSet: 12
      Gerrit-Owner: Yu He <y...@microsoft.com>
      Gerrit-Reviewer: Yu He <y...@microsoft.com>
      Gerrit-CC: Qikai Zhong <qikai...@microsoft.com>
      Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
      Gerrit-Comment-Date: Thu, 12 Mar 2026 08:20:13 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Yu He (Gerrit)

      unread,
      4:27 AM (8 hours ago) 4:27 AM
      to Qikai Zhong, Tom Lukaszewicz, Kevin DiClemente, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, chromium-a...@chromium.org, mdjone...@chromium.org, zelin+watch-we...@chromium.org, dmurph+watc...@chromium.org, philli...@chromium.org, loyso...@chromium.org, aixba+wat...@chromium.org, dibyapal+wa...@chromium.org, kuragin+web-ap...@chromium.org, ayman...@chromium.org, japhet+...@chromium.org, webap...@microsoft.com, mek+w...@chromium.org, dewitt...@chromium.org, yuezhang...@chromium.org, mgiuca...@chromium.org, extension...@chromium.org, dmurph+wat...@chromium.org
      Attention needed from Qikai Zhong and Tom Lukaszewicz

      Yu He voted and added 1 comment

      Votes added by Yu He

      Auto-Submit+1
      Commit-Queue+1

      1 comment

      Patchset-level comments
      File-level comment, Patchset 12 (Latest):
      Yu He . resolved

      This CL is ready, please help to review, thanks.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Qikai Zhong
      • Tom Lukaszewicz
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iffb72e0da8c71ca3fe6021242dcb068b6d5eeb01
      Gerrit-Change-Number: 7645602
      Gerrit-PatchSet: 12
      Gerrit-Owner: Yu He <y...@microsoft.com>
      Gerrit-Reviewer: Qikai Zhong <qikai...@microsoft.com>
      Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
      Gerrit-Reviewer: Yu He <y...@microsoft.com>
      Gerrit-CC: Kevin DiClemente <ked...@microsoft.com>
      Gerrit-Attention: Qikai Zhong <qikai...@microsoft.com>
      Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
      Gerrit-Comment-Date: Thu, 12 Mar 2026 08:26:50 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages