Return by const ref in AXEvent mojom traits [chromium/src : main]

0 views
Skip to first unread message

Daniel Cheng (Gerrit)

unread,
Aug 14, 2026, 7:57:48 PM (2 days ago) Aug 14
to Daniel Cheng, Benjamin Beaudry, chromium...@chromium.org, chromotin...@chromium.org, (Julie)Jeongeun Kim, Zhe Su, abigailbk...@google.com, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, cfredri...@chromium.org, chromeos-gfx-...@google.com, chromium-a...@chromium.org, csharris...@chromium.org, dmurph+wa...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, ipc-securi...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, marinacio...@chromium.org, media-cro...@chromium.org, nektar...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, olka+...@chromium.org, oshima...@chromium.org, shuche...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, wfh+...@chromium.org, yhanad...@chromium.org, yuzo+...@chromium.org
Attention needed from Benjamin Beaudry

Daniel Cheng voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Benjamin Beaudry
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ideae937985c7ca51ee46c87961e5248b5ef9a59b
Gerrit-Change-Number: 8260085
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Benjamin Beaudry <benjamin...@microsoft.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Zhe Su <su...@chromium.org>
Gerrit-Attention: Benjamin Beaudry <benjamin...@microsoft.com>
Gerrit-Comment-Date: Fri, 14 Aug 2026 23:57:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Benjamin Beaudry (Gerrit)

unread,
Aug 14, 2026, 8:58:51 PM (2 days ago) Aug 14
to Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, chromotin...@chromium.org, (Julie)Jeongeun Kim, Zhe Su, abigailbk...@google.com, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, cfredri...@chromium.org, chromeos-gfx-...@google.com, chromium-a...@chromium.org, csharris...@chromium.org, dmurph+wa...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, ipc-securi...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, marinacio...@chromium.org, media-cro...@chromium.org, nektar...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, olka+...@chromium.org, oshima...@chromium.org, shuche...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, wfh+...@chromium.org, yhanad...@chromium.org, yuzo+...@chromium.org
Attention needed from Daniel Cheng

Benjamin Beaudry voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ideae937985c7ca51ee46c87961e5248b5ef9a59b
    Gerrit-Change-Number: 8260085
    Gerrit-PatchSet: 3
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Benjamin Beaudry <benjamin...@microsoft.com>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Zhe Su <su...@chromium.org>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Sat, 15 Aug 2026 00:58:36 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Aug 14, 2026, 9:03:26 PM (2 days ago) Aug 14
    to Daniel Cheng, Benjamin Beaudry, Akihiro Ota, chromium...@chromium.org, chromotin...@chromium.org, (Julie)Jeongeun Kim, Zhe Su, abigailbk...@google.com, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, cfredri...@chromium.org, chromeos-gfx-...@google.com, chromium-a...@chromium.org, csharris...@chromium.org, dmurph+wa...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, gcasto+w...@chromium.org, ipc-securi...@chromium.org, josiah...@chromium.org, keithle...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, marinacio...@chromium.org, media-cro...@chromium.org, nektar...@chromium.org, network-ser...@chromium.org, nona+...@chromium.org, olka+...@chromium.org, oshima...@chromium.org, shuche...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, wfh+...@chromium.org, yhanad...@chromium.org, yuzo+...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Return by const ref in AXEvent mojom traits

    Returning by value creates a temporary that is immediately discarded
    after the bytes are written to the wire; this is wasteful since the
    type in question is not consumed during serialization.
    Bug: 546207269
    Change-Id: Ideae937985c7ca51ee46c87961e5248b5ef9a59b
    Auto-Submit: Daniel Cheng <dch...@chromium.org>
    Reviewed-by: Benjamin Beaudry <benjamin...@microsoft.com>
    Commit-Queue: Daniel Cheng <dch...@chromium.org>
    Commit-Queue: Benjamin Beaudry <benjamin...@microsoft.com>
    Cr-Commit-Position: refs/heads/main@{#1680069}
    Files:
    • M ui/accessibility/mojom/ax_event_mojom_traits.h
    Change size: XS
    Delta: 1 file changed, 2 insertions(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Benjamin Beaudry
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ideae937985c7ca51ee46c87961e5248b5ef9a59b
    Gerrit-Change-Number: 8260085
    Gerrit-PatchSet: 4
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Benjamin Beaudry <benjamin...@microsoft.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages