FakeDMServer: set settings_entity_id for extension installs [chromium/src : main]
0 views
Skip to first unread message
Nicolas Ouellet-Payeur (Gerrit)
Jan 8, 2026, 10:48:32 AM (24 hours ago) Jan 8
to AyeAye, Enterprise Policy Reviews, chromium-a...@chromium.org, extension...@chromium.org
Nicolas Ouellet-Payeur has uploaded the change for review![]( "Open in Gerrit")
Commit message
FakeDMServer: set settings_entity_id for extension installs
CloudPolicyService checks for the presence of this field when
fetching for an extension install.
Change-Id: Ibb4f2dffc5779effd06a16807cdb0d3bfc04c87a
Change diff
diff --git a/components/policy/test_support/request_handler_for_policy.cc b/components/policy/test_support/request_handler_for_policy.cc
index 769e355..939d36b 100644
--- a/components/policy/test_support/request_handler_for_policy.cc
+++ b/components/policy/test_support/request_handler_for_policy.cc
@@ -388,6 +388,10 @@
em::PolicyData policy_data;
policy_data.set_policy_type(fetch_request.policy_type());
policy_data.set_policy_value(result.SerializeAsString());
+ if (fetch_request.extension_ids_and_version_size() == 1) {
+ policy_data.set_settings_entity_id(
+ fetch_request.extension_ids_and_version(0).extension_id());
+ }
policy_data.SerializeToString(
response->add_responses()->mutable_policy_data());
return true;
Change information
Files:
- M components/policy/test_support/request_handler_for_policy.cc
Change size: XS
Delta: 1 file changed, 4 insertions(+), 0 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicolas Ouellet-Payeur (Gerrit)
Jan 8, 2026, 10:52:14 AM (24 hours ago) Jan 8
to Yann Dago, Enterprise Policy Reviews, AyeAye, extension...@chromium.org, chromium-a...@chromium.org
Attention needed from Yann Dago
Nicolas Ouellet-Payeur added 1 comment![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yann Dago (Gerrit)
Jan 8, 2026, 11:10:09 AM (23 hours ago) Jan 8
to Nicolas Ouellet-Payeur, Chromium LUCI CQ, Enterprise Policy Reviews, AyeAye, extension...@chromium.org, chromium-a...@chromium.org
Attention needed from Nicolas Ouellet-Payeur
Yann Dago voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Nicolas Ouellet-Payeur
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicolas Ouellet-Payeur (Gerrit)
Jan 8, 2026, 1:09:24 PM (22 hours ago) Jan 8
to Yann Dago, Chromium LUCI CQ, Enterprise Policy Reviews, AyeAye, extension...@chromium.org, chromium-a...@chromium.org
Nicolas Ouellet-Payeur voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 8, 2026, 1:12:23 PM (21 hours ago) Jan 8
to Nicolas Ouellet-Payeur, Yann Dago, Enterprise Policy Reviews, AyeAye, extension...@chromium.org, chromium-a...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
FakeDMServer: set settings_entity_id for extension installs
CloudPolicyService checks for the presence of this field when
fetching for an extension install.
Bug: 468017367
Change-Id: Ibb4f2dffc5779effd06a16807cdb0d3bfc04c87a
Reviewed-by: Yann Dago <yd...@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nico...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1566396}
Files:
- M components/policy/test_support/request_handler_for_policy.cc
Change size: XS
Delta: 1 file changed, 4 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yann Dago
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages