Workaround solution for <webview> allowtransparency="on" being ignored [chromium/src : main]

0 views
Skip to first unread message

Reilly Grant (Gerrit)

unread,
Jan 29, 2026, 9:01:09 PM (2 days ago) Jan 29
to Duncan Mercer, Chromium UI Views Reviews, Chromium LUCI CQ, Reilly Grant, James Maclean, Kevin McNee, AyeAye, extension...@chromium.org, chromium-a...@chromium.org
Attention needed from Chromium UI Views Reviews and Duncan Mercer

Reilly Grant added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Reilly Grant . resolved

I don't have much experience with the Views code here so I'd appreciate an expert take a look and then I can approve from a //extensions perspective.

Open in Gerrit

Related details

Attention is currently required from:
  • Chromium UI Views Reviews
  • Duncan Mercer
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8848bab1cd8255e5e24c9972417beaa02bb90a5b
Gerrit-Change-Number: 7534081
Gerrit-PatchSet: 3
Gerrit-Owner: Duncan Mercer <mer...@google.com>
Gerrit-Reviewer: Chromium UI Views Reviews <chromium-ui-...@google.com>
Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-Attention: Duncan Mercer <mer...@google.com>
Gerrit-Attention: Chromium UI Views Reviews <chromium-ui-...@google.com>
Gerrit-Comment-Date: Fri, 30 Jan 2026 02:00:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Jan 29, 2026, 9:05:39 PM (2 days ago) Jan 29
to Duncan Mercer, Chromium UI Views Reviews, Allen Bauer, Chromium LUCI CQ, Reilly Grant, James Maclean, Kevin McNee, AyeAye, extension...@chromium.org, chromium-a...@chromium.org
Attention needed from Allen Bauer and Duncan Mercer

Message from gwsq

Reviewer source(s):
kyl...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ui/views/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Allen Bauer
  • Duncan Mercer
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8848bab1cd8255e5e24c9972417beaa02bb90a5b
Gerrit-Change-Number: 7534081
Gerrit-PatchSet: 3
Gerrit-Owner: Duncan Mercer <mer...@google.com>
Gerrit-Reviewer: Allen Bauer <kyl...@chromium.org>
Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
Gerrit-CC: Chromium UI Views Reviews <chromium-ui-...@google.com>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: gwsq
Gerrit-Attention: Duncan Mercer <mer...@google.com>
Gerrit-Attention: Allen Bauer <kyl...@chromium.org>
Gerrit-Comment-Date: Fri, 30 Jan 2026 02:05:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Allen Bauer (Gerrit)

unread,
Jan 30, 2026, 1:53:36 PM (12 hours ago) Jan 30
to Duncan Mercer, Chromium UI Views Reviews, Chromium LUCI CQ, Reilly Grant, James Maclean, Kevin McNee, AyeAye, extension...@chromium.org, chromium-a...@chromium.org
Attention needed from Duncan Mercer and Reilly Grant

Allen Bauer added 1 comment

Patchset-level comments
Reilly Grant . resolved

I don't have much experience with the Views code here so I'd appreciate an expert take a look and then I can approve from a //extensions perspective.

Allen Bauer

I checked the hierarchy, and I don't find any reference to Views up the chain. I may not be the best to review this either 😞

Open in Gerrit

Related details

Attention is currently required from:
  • Duncan Mercer
  • Reilly Grant
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8848bab1cd8255e5e24c9972417beaa02bb90a5b
Gerrit-Change-Number: 7534081
Gerrit-PatchSet: 3
Gerrit-Owner: Duncan Mercer <mer...@google.com>
Gerrit-Reviewer: Allen Bauer <kyl...@chromium.org>
Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
Gerrit-CC: Chromium UI Views Reviews <chromium-ui-...@google.com>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: gwsq
Gerrit-Attention: Duncan Mercer <mer...@google.com>
Gerrit-Attention: Reilly Grant <rei...@chromium.org>
Gerrit-Comment-Date: Fri, 30 Jan 2026 18:53:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reilly Grant <rei...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Allen Bauer (Gerrit)

unread,
Jan 30, 2026, 3:44:35 PM (10 hours ago) Jan 30
to Duncan Mercer, Chromium UI Views Reviews, Chromium LUCI CQ, Reilly Grant, James Maclean, Kevin McNee, AyeAye, extension...@chromium.org, chromium-a...@chromium.org
Attention needed from Duncan Mercer and Reilly Grant

Allen Bauer voted and added 2 comments

Votes added by Allen Bauer

Code-Review+1

2 comments

Patchset-level comments
Reilly Grant . resolved

I don't have much experience with the Views code here so I'd appreciate an expert take a look and then I can approve from a //extensions perspective.

Allen Bauer

I checked the hierarchy, and I don't find any reference to Views up the chain. I may not be the best to review this either 😞

Allen Bauer

Ok, I see what the deal is. It's still not specifically Views, but it is setting the background color for the RenderWidgetHostView.

Either way, this is a reasonable workaround.

Allen Bauer . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Duncan Mercer
  • Reilly Grant
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8848bab1cd8255e5e24c9972417beaa02bb90a5b
    Gerrit-Change-Number: 7534081
    Gerrit-PatchSet: 3
    Gerrit-Owner: Duncan Mercer <mer...@google.com>
    Gerrit-Reviewer: Allen Bauer <kyl...@chromium.org>
    Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-CC: Chromium UI Views Reviews <chromium-ui-...@google.com>
    Gerrit-CC: James Maclean <wjma...@chromium.org>
    Gerrit-CC: Kevin McNee <mc...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-Attention: Duncan Mercer <mer...@google.com>
    Gerrit-Attention: Reilly Grant <rei...@chromium.org>
    Gerrit-Comment-Date: Fri, 30 Jan 2026 20:44:25 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Reilly Grant <rei...@chromium.org>
    Comment-In-Reply-To: Allen Bauer <kyl...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Reilly Grant (Gerrit)

    unread,
    Jan 30, 2026, 3:46:39 PM (10 hours ago) Jan 30
    to Duncan Mercer, Reilly Grant, Allen Bauer, Chromium UI Views Reviews, Chromium LUCI CQ, James Maclean, Kevin McNee, AyeAye, extension...@chromium.org, chromium-a...@chromium.org
    Attention needed from Duncan Mercer

    Reilly Grant voted and added 2 comments

    Votes added by Reilly Grant

    Code-Review+1

    2 comments

    Patchset-level comments
    Reilly Grant . resolved

    LGTM

    Reilly Grant . resolved

    I don't have much experience with the Views code here so I'd appreciate an expert take a look and then I can approve from a //extensions perspective.

    Allen Bauer

    I checked the hierarchy, and I don't find any reference to Views up the chain. I may not be the best to review this either 😞

    Allen Bauer

    Ok, I see what the deal is. It's still not specifically Views, but it is setting the background color for the RenderWidgetHostView.

    Either way, this is a reasonable workaround.

    Reilly Grant

    Thanks for giving this a second look. Adding my OWNERS LGTM. Hopefully we can figure out the root cause soon.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Duncan Mercer
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8848bab1cd8255e5e24c9972417beaa02bb90a5b
    Gerrit-Change-Number: 7534081
    Gerrit-PatchSet: 3
    Gerrit-Owner: Duncan Mercer <mer...@google.com>
    Gerrit-Reviewer: Allen Bauer <kyl...@chromium.org>
    Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
    Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
    Gerrit-CC: Chromium UI Views Reviews <chromium-ui-...@google.com>
    Gerrit-CC: James Maclean <wjma...@chromium.org>
    Gerrit-CC: Kevin McNee <mc...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-Attention: Duncan Mercer <mer...@google.com>
    Gerrit-Comment-Date: Fri, 30 Jan 2026 20:46:24 +0000
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages