Mitsuru Oshima (Gerrit)

unread,

Mar 11, 2026, 8:27:38 PM (16 hours ago) Mar 11

to Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, ajayramamurth...@google.com, ajayramamurthy...@google.com, akingsb+wat...@google.com, chromium-a...@chromium.org, crisrael+w...@google.com, crisrael+wa...@google.com, croissant-...@chromium.org, cros-essential...@chromium.org, cros-setti...@google.com, crost...@chromium.org, dclasson+w...@google.com, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansenmichael...@google.com, hashimo...@chromium.org, jackshira+w...@google.com, jackshira+wa...@google.com, julietlevesque...@google.com, oshima...@chromium.org, pushi+wat...@google.com, rginda...@chromium.org, rrsilva+wat...@google.com, suetfei+wa...@google.com, tbarzi...@chromium.org, xlythe+wa...@google.com

Attention needed from Hidehiko Abe

Mitsuru Oshima added 1 comment

File chrome/browser/nearby_sharing/common/nearby_share_switches.h

Line 15, Patchset 5 (Latest):extern const char kNearbyShareNumPrivateCertificates[];

Mitsuru Oshima . unresolved

These are not moved (yet) because they're used in non ash/ chromeos/ directories (under c/b/nearby_sharing/...).
I'll move them in a separate CL.

Open in Gerrit

Related details

Attention is currently required from:

Hidehiko Abe

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Hidehiko Abe (Gerrit)

unread,

1:29 AM (11 hours ago) 1:29 AM

to Mitsuru Oshima, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, ajayramamurth...@google.com, ajayramamurthy...@google.com, akingsb+wat...@google.com, chromium-a...@chromium.org, crisrael+w...@google.com, crisrael+wa...@google.com, croissant-...@chromium.org, cros-essential...@chromium.org, cros-setti...@google.com, crost...@chromium.org, dclasson+w...@google.com, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansenmichael...@google.com, hashimo...@chromium.org, jackshira+w...@google.com, jackshira+wa...@google.com, julietlevesque...@google.com, oshima...@chromium.org, pushi+wat...@google.com, rginda...@chromium.org, rrsilva+wat...@google.com, suetfei+wa...@google.com, tbarzi...@chromium.org, xlythe+wa...@google.com

Attention needed from Mitsuru Oshima

Hidehiko Abe voted and added 1 comment

Votes added by Hidehiko Abe

Code-Review

+1

1 comment

File ash/constants/ash_switches.h

Line 383, Patchset 7 (Latest):// When specified with a url string as parameter, the given url overrides the

Hidehiko Abe . unresolved

no dup comment looks needed?

Open in Gerrit

Related details

Attention is currently required from:

Mitsuru Oshima

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Mitsuru Oshima (Gerrit)

unread,

2:19 AM (10 hours ago) 2:19 AM

to Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, ajayramamurth...@google.com, ajayramamurthy...@google.com, akingsb+wat...@google.com, chromium-a...@chromium.org, crisrael+w...@google.com, crisrael+wa...@google.com, croissant-...@chromium.org, cros-essential...@chromium.org, cros-setti...@google.com, crost...@chromium.org, dclasson+w...@google.com, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansenmichael...@google.com, hashimo...@chromium.org, jackshira+w...@google.com, jackshira+wa...@google.com, julietlevesque...@google.com, oshima...@chromium.org, pushi+wat...@google.com, rginda...@chromium.org, rrsilva+wat...@google.com, suetfei+wa...@google.com, tbarzi...@chromium.org, xlythe+wa...@google.com

Mitsuru Oshima voted and added 1 comment

Votes added by Mitsuru Oshima

Commit-Queue

+2

1 comment

File ash/constants/ash_switches.h

Line 383, Patchset 7:// When specified with a url string as parameter, the given url overrides the

Hidehiko Abe . resolved

no dup comment looks needed?

Mitsuru Oshima

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Mitsuru Oshima (Gerrit)

unread,

2:20 AM (10 hours ago) 2:20 AM

to Hidehiko Abe, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, ajayramamurth...@google.com, ajayramamurthy...@google.com, akingsb+wat...@google.com, chromium-a...@chromium.org, crisrael+w...@google.com, crisrael+wa...@google.com, croissant-...@chromium.org, cros-essential...@chromium.org, cros-setti...@google.com, crost...@chromium.org, dclasson+w...@google.com, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansenmichael...@google.com, hashimo...@chromium.org, jackshira+w...@google.com, jackshira+wa...@google.com, julietlevesque...@google.com, oshima...@chromium.org, pushi+wat...@google.com, rginda...@chromium.org, rrsilva+wat...@google.com, suetfei+wa...@google.com, tbarzi...@chromium.org, xlythe+wa...@google.com

Attention needed from Mitsuru Oshima

Mitsuru Oshima voted and added 1 comment

Votes added by Mitsuru Oshima

Commit-Queue

+2

1 comment

File chrome/browser/nearby_sharing/common/nearby_share_switches.h

Line 15, Patchset 5:extern const char kNearbyShareNumPrivateCertificates[];

Mitsuru Oshima . resolved

These are not moved (yet) because they're used in non ash/ chromeos/ directories (under c/b/nearby_sharing/...).
I'll move them in a separate CL.

Mitsuru Oshima

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:

Mitsuru Oshima

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

3:04 AM (9 hours ago) 3:04 AM

to Mitsuru Oshima, Hidehiko Abe, chromium...@chromium.org, Enterprise Policy Reviews, ajayramamurth...@google.com, ajayramamurthy...@google.com, akingsb+wat...@google.com, chromium-a...@chromium.org, crisrael+w...@google.com, crisrael+wa...@google.com, croissant-...@chromium.org, cros-essential...@chromium.org, cros-setti...@google.com, crost...@chromium.org, dclasson+w...@google.com, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansenmichael...@google.com, hashimo...@chromium.org, jackshira+w...@google.com, jackshira+wa...@google.com, julietlevesque...@google.com, oshima...@chromium.org, pushi+wat...@google.com, rginda...@chromium.org, rrsilva+wat...@google.com, suetfei+wa...@google.com, tbarzi...@chromium.org, xlythe+wa...@google.com

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

7 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: ash/constants/ash_switches.h
Insertions: 0, Deletions: 6.

@@ -379,14 +379,8 @@
 COMPONENT_EXPORT(ASH_CONSTANTS) extern const char kAppModeOAuth2Token[];
 COMPONENT_EXPORT(ASH_CONSTANTS) extern const char kMonitoringDestinationID[];
 COMPONENT_EXPORT(ASH_CONSTANTS) extern const char kSystemLogUploadFrequency[];
-
-// When specified with a url string as parameter, the given url overrides the
-// Android Messages for Web PWA installation and app urls using a base of the
-// given domain with approrpiate suffixes.
 COMPONENT_EXPORT(ASH_CONSTANTS)
 extern const char kCustomAndroidMessagesDomain[];
-
-// Enables verbose logging level for Nearby Share.
 COMPONENT_EXPORT(ASH_CONSTANTS) extern const char kNearbyShareVerboseLogging[];
 
 ////////////////////////////////////////////////////////////////////////////////
```

Change information

Commit message:

Migrate ChromeOS-exclusive switches from chrome/browser to ash/constants

This stage migrates the following locally-defined ChromeOS-exclusive
    switches scattered under chrome/browser:
    - kCustomAndroidMessagesDomain
    - kNearbyShareVerboseLogging

Bug: b:491803262

Change-Id: I465641b18261a686b1646fce36efa59dee02d92b

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7655886

Commit-Queue: Mitsuru Oshima <osh...@chromium.org>

Reviewed-by: Hidehiko Abe <hide...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1598247}

Files:

M ash/constants/ash_switches.cc
M ash/constants/ash_switches.h
M chrome/browser/ash/android_sms/BUILD.gn
D chrome/browser/ash/android_sms/android_sms_switches.cc
D chrome/browser/ash/android_sms/android_sms_switches.h
M chrome/browser/ash/android_sms/android_sms_urls.cc
M chrome/browser/ash/nearby/nearby_dependencies_provider.cc
M chrome/browser/nearby_sharing/common/nearby_share_switches.cc
M chrome/browser/nearby_sharing/common/nearby_share_switches.h

Change size: M

Delta: 9 files changed, 15 insertions(+), 37 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Hidehiko Abe

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Migrate ChromeOS-exclusive switches from chrome/browser to ash/constants [chromium/src : main]

Mitsuru Oshima (Gerrit)

Mitsuru Oshima added 1 comment

Related details

Hidehiko Abe (Gerrit)

Hidehiko Abe voted and added 1 comment

Votes added by Hidehiko Abe

1 comment

Related details

Mitsuru Oshima (Gerrit)

Mitsuru Oshima voted and added 1 comment

Votes added by Mitsuru Oshima

1 comment

Related details

Mitsuru Oshima (Gerrit)

Mitsuru Oshima voted and added 1 comment

Votes added by Mitsuru Oshima

1 comment

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information