[m145] Update logic for showing pdf summarize button [chromium/src : refs/branch-heads/7632]
0 views
Skip to first unread message
Erik Chen (Gerrit)
Feb 19, 2026, 9:23:49 PM (4 hours ago) Feb 19
to Sophie Chang, AyeAye, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, pdf-r...@chromium.org
Attention needed from Sophie Chang
Erik Chen voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Sophie Chang
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sophie Chang (Gerrit)
Feb 19, 2026, 9:24:43 PM (4 hours ago) Feb 19
to Erik Chen, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, pdf-r...@chromium.org
Attention needed from Erik Chen
Sophie Chang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Sophie Chang
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Sophie Chang . resolved
looks clean - though looks like no merge approval
Related details
Attention is currently required from:
- Erik Chen
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Erik Chen (Gerrit)
Feb 19, 2026, 10:38:11 PM (3 hours ago) Feb 19
to Sophie Chang, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, pdf-r...@chromium.org
Erik Chen voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Erik Chen (Gerrit)
Feb 19, 2026, 11:03:16 PM (2 hours ago) Feb 19
to Sophie Chang, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, pdf-r...@chromium.org
Erik Chen voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Erik Chen (Gerrit)
Feb 19, 2026, 11:18:48 PM (2 hours ago) Feb 19
to Sophie Chang, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, pdf-r...@chromium.org
Erik Chen submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[m145] Update logic for showing pdf summarize button
> Update logic for showing pdf summarize button
>
> Change-Id: I546411644da25b4ad2df43f2ffc938a1db4ae646
> Bug: 483727155
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7586673
> Commit-Queue: Erik Chen <erik...@chromium.org>
> Reviewed-by: Erik Chen <erik...@chromium.org>
> Reviewed-by: Lei Zhang <the...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1586168}
Bug: 483727155, 485981692
Fixed: 485981692
Change-Id: I2f5e7a716dfdb0dd3b790fa114fd6593a2e9b237
Reviewed-by: Sophie Chang <sophi...@chromium.org>
Commit-Queue: Erik Chen <erik...@chromium.org>
Cr-Commit-Position: refs/branch-heads/7632@{#3051}
Cr-Branched-From: 0bbdf2913883391365383b0a5dfe7bf9fd1a5213-refs/heads/main@{#1568190}
Files:
- M chrome/browser/pdf/BUILD.gn
- M chrome/browser/pdf/pdf_extension_util.cc
- M chrome/browser/pdf/pdf_extension_util.h
- M chrome/common/chrome_features.cc
- M chrome/common/chrome_features.h
Change size: S
Delta: 5 files changed, 28 insertions(+), 2 deletions(-)
Branch: refs/branch-heads/7632
Submit Requirements:
Code-Review: +1 by Sophie Chang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages