[Extensions WebIDL] Convert networking.onc to WebIDL [chromium/src : main]
Tim (Gerrit)
Tim added 2 comments![]( "Open in Gerrit")
We've already talked about the strangeness of this schema, but I put two specific call-outs into the commit message touching on them. I've also left a comment on the update I'm doing to the old IDL file along with this change to explain why in more detail. Take a look and tell me what you think.
// <p>The <code>chrome.networking.onc</code> API is used for configuring network
// connections (Cellular, Ethernet, VPN or WiFi). This API is available in
// auto-launched Chrome OS kiosk sessions.</p><p>Network connection
// configurations are specified following <a
// href="https://chromium.googlesource.com/chromium/src/+/main/components/onc/docs/onc_spec.md">
// Open Network Configuration (ONC)</a> specification.</p><p><b>NOTE</b>: Most
// dictionary properties and enum values use UpperCamelCase to match the ONC
// specification instead of the JavaScript lowerCamelCase convention.</p>This is a little strange and I don't really like modifying the old file in order to make it match the output from the new, but the output from the old file (with the manual indentation it tries to add) resulted it the actual output having extra spaces throughout on linebreaks. This is because the comment processing just removed character returns and the "//" at the start of the line, so it retained the extra spaces used to indent.
The full old description string after processing was previously:
`"description": "<p> The <code>chrome.networking.onc</code> API is used for configuring network connections (Cellular, Ethernet, VPN or WiFi). This API is available in auto-launched Chrome OS kiosk sessions. </p> <p> Network connection configurations are specified following <a href=\"https://chromium.googlesource.com/chromium/src/+/main/components/onc/docs/onc_spec.md\"> Open Network Configuration (ONC)</a> specification. </p> <p> <b>NOTE</b>: Most dictionary properties and enum values use UpperCamelCase to match the ONC specification instead of the JavaScript lowerCamelCase convention. </p>",`
(note the extra spaces).
And the new string is now:
`"description": "<p>The <code>chrome.networking.onc</code> API is used for configuring network connections (Cellular, Ethernet, VPN or WiFi). This API is available in auto-launched Chrome OS kiosk sessions.</p><p>Network connection configurations are specified following <a href=\"https://chromium.googlesource.com/chromium/src/+/main/components/onc/docs/onc_spec.md\"> Open Network Configuration (ONC)</a> specification.</p><p><b>NOTE</b>: Most dictionary properties and enum values use UpperCamelCase to match the ONC specification instead of the JavaScript lowerCamelCase convention.</p>",`
Although this looks kind of messy here in the old IDL format, in the new WebIDL file I've used the auto-<p> tag formatting to make it nicer.
Related details
- Devlin Cronin
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Devlin Cronin (Gerrit)
Devlin Cronin voted and added 2 comments![]( "Open in Gerrit")
Votes added by Devlin Cronin
| Code-Review | +1 |
2 comments
LGTM
// <p>The <code>chrome.networking.onc</code> API is used for configuring network
// connections (Cellular, Ethernet, VPN or WiFi). This API is available in
// auto-launched Chrome OS kiosk sessions.</p><p>Network connection
// configurations are specified following <a
// href="https://chromium.googlesource.com/chromium/src/+/main/components/onc/docs/onc_spec.md">
// Open Network Configuration (ONC)</a> specification.</p><p><b>NOTE</b>: Most
// dictionary properties and enum values use UpperCamelCase to match the ONC
// specification instead of the JavaScript lowerCamelCase convention.</p>This is a little strange and I don't really like modifying the old file in order to make it match the output from the new, but the output from the old file (with the manual indentation it tries to add) resulted it the actual output having extra spaces throughout on linebreaks. This is because the comment processing just removed character returns and the "//" at the start of the line, so it retained the extra spaces used to indent.
The full old description string after processing was previously:
`"description": "<p> The <code>chrome.networking.onc</code> API is used for configuring network connections (Cellular, Ethernet, VPN or WiFi). This API is available in auto-launched Chrome OS kiosk sessions. </p> <p> Network connection configurations are specified following <a href=\"https://chromium.googlesource.com/chromium/src/+/main/components/onc/docs/onc_spec.md\"> Open Network Configuration (ONC)</a> specification. </p> <p> <b>NOTE</b>: Most dictionary properties and enum values use UpperCamelCase to match the ONC specification instead of the JavaScript lowerCamelCase convention. </p>",`
(note the extra spaces).And the new string is now:
`"description": "<p>The <code>chrome.networking.onc</code> API is used for configuring network connections (Cellular, Ethernet, VPN or WiFi). This API is available in auto-launched Chrome OS kiosk sessions.</p><p>Network connection configurations are specified following <a href=\"https://chromium.googlesource.com/chromium/src/+/main/components/onc/docs/onc_spec.md\"> Open Network Configuration (ONC)</a> specification.</p><p><b>NOTE</b>: Most dictionary properties and enum values use UpperCamelCase to match the ONC specification instead of the JavaScript lowerCamelCase convention.</p>",`Although this looks kind of messy here in the old IDL format, in the new WebIDL file I've used the auto-<p> tag formatting to make it nicer.
- Tim
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tim (Gerrit)
Tim voted Commit-Queue+2![]( "Open in Gerrit")
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
7 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
[Extensions WebIDL] Convert networking.onc to WebIDL
This conversion was largely done using a detailed description of the
conversion process passed to Gemini CLI. To double check this work, the
file has also been copied into the converted schemas test to verify no
functional difference in output.
Note 1: networking.onc is a bit of a strange one, as it is purely used
for documentation purposes and is essentially a clone of
networkingPrivate, which gets aliased to networking.onc. This means it's
not referenced in any .gni files, so there's no .gni update in this CL.
Note 2: The top level API comment was slightly updated on the old IDL
file, which fixes some whitespace issues with how it was previously
formatted. The new WebIDL version also takes advantage of the automatic
<p> tag additions the processor can do for comments.
- A extensions/common/api/networking_onc.webidl
- R tools/json_schema_compiler/test/converted_schemas/networking_onc.idl
- A tools/json_schema_compiler/test/converted_schemas/networking_onc.webidl
- M tools/json_schema_compiler/web_idl_diff_tool_test.py
Code-Review: +1 by Devlin Cronin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |