[Extensions] Add toggle for default pinning in chrome://extensions [chromium/src : main]

0 views
Skip to first unread message

gwsq (Gerrit)

unread,
Jun 22, 2026, 7:26:59 PM (3 days ago) Jun 22
to Eva Su, Chromium Sync Reviews, Jesse McKenna, Rushan Suleymanov, Devlin Cronin, Chromium LUCI CQ, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Devlin Cronin, Jesse McKenna and Rushan Suleymanov

Message from gwsq

Reviewer source(s):
rus...@google.com is from context(googleclient/chrome/chromium_gwsq/components/sync/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Devlin Cronin
  • Jesse McKenna
  • Rushan Suleymanov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iedbae1500b1b8fd24187bc454c369288e6855f8b
Gerrit-Change-Number: 7958486
Gerrit-PatchSet: 5
Gerrit-Owner: Eva Su <ev...@chromium.org>
Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Reviewer: Eva Su <ev...@chromium.org>
Gerrit-Reviewer: Jesse McKenna <jessem...@google.com>
Gerrit-Reviewer: Rushan Suleymanov <rus...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Chromium Sync Reviews <chromium-s...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Devlin Cronin <rdevlin...@chromium.org>
Gerrit-Attention: Rushan Suleymanov <rus...@google.com>
Gerrit-Attention: Jesse McKenna <jessem...@google.com>
Gerrit-Comment-Date: Mon, 22 Jun 2026 23:26:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Eva Su (Gerrit)

unread,
Jun 22, 2026, 7:27:51 PM (3 days ago) Jun 22
to Chromium Sync Reviews, Jesse McKenna, Rushan Suleymanov, Devlin Cronin, Chromium LUCI CQ, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Devlin Cronin, Jesse McKenna and Rushan Suleymanov

Eva Su added 1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Eva Su . resolved

Rushan, can I get your review on tools/metrics/histograms/metadata/sync/enums.xml and chrome/browser/sync/prefs/chrome_syncable_prefs_database.cc?

And Jesse, can I get your review on tools/typescript/definitions/developer_private.d.ts?

Gerrit-Comment-Date: Mon, 22 Jun 2026 23:27:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Rushan Suleymanov (Gerrit)

unread,
Jun 23, 2026, 4:06:21 AM (3 days ago) Jun 23
to Eva Su, Chromium Sync Reviews, Jesse McKenna, Devlin Cronin, Chromium LUCI CQ, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
Attention needed from Devlin Cronin, Eva Su and Jesse McKenna

Rushan Suleymanov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Devlin Cronin
  • Eva Su
  • Jesse McKenna
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iedbae1500b1b8fd24187bc454c369288e6855f8b
    Gerrit-Change-Number: 7958486
    Gerrit-PatchSet: 5
    Gerrit-Owner: Eva Su <ev...@chromium.org>
    Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
    Gerrit-Reviewer: Eva Su <ev...@chromium.org>
    Gerrit-Reviewer: Jesse McKenna <jessem...@google.com>
    Gerrit-Reviewer: Rushan Suleymanov <rus...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Chromium Sync Reviews <chromium-s...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Devlin Cronin <rdevlin...@chromium.org>
    Gerrit-Attention: Eva Su <ev...@chromium.org>
    Gerrit-Attention: Jesse McKenna <jessem...@google.com>
    Gerrit-Comment-Date: Tue, 23 Jun 2026 08:06:00 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Devlin Cronin (Gerrit)

    unread,
    Jun 25, 2026, 6:17:07 PM (6 hours ago) Jun 25
    to Eva Su, Kelvin Jiang, Rushan Suleymanov, Chromium Sync Reviews, Jesse McKenna, Devlin Cronin, Chromium LUCI CQ, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
    Attention needed from Eva Su, Jesse McKenna and Kelvin Jiang

    Devlin Cronin added 2 comments

    Patchset-level comments
    File-level comment, Patchset 8 (Latest):
    Devlin Cronin . resolved

    Thanks, Eva! This looks pretty good!

    One comment, and I'm going to punt the review of //chrome/browser/resources/extensions -> kelvinjiang@.

    File chrome/browser/ui/webui/extensions/extensions_ui.cc
    Line 472, Patchset 8 (Latest): source->AddBoolean(
    "extensionsPinnedByDefault",
    profile->GetPrefs()->GetBoolean(prefs::kExtensionsPinnedByDefault));
    Devlin Cronin . unresolved

    Given this is exposed in the ProfileInfo in developerPrivate, I don't think we also need it exposed this way. Can we just use the one from the profile info instead of having two?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Eva Su
    • Jesse McKenna
    • Kelvin Jiang
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iedbae1500b1b8fd24187bc454c369288e6855f8b
      Gerrit-Change-Number: 7958486
      Gerrit-PatchSet: 8
      Gerrit-Owner: Eva Su <ev...@chromium.org>
      Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
      Gerrit-Reviewer: Eva Su <ev...@chromium.org>
      Gerrit-Reviewer: Jesse McKenna <jessem...@google.com>
      Gerrit-Reviewer: Kelvin Jiang <kelvi...@chromium.org>
      Gerrit-Reviewer: Rushan Suleymanov <rus...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Chromium Sync Reviews <chromium-s...@google.com>
      Gerrit-CC: gwsq
      Gerrit-Attention: Eva Su <ev...@chromium.org>
      Gerrit-Attention: Kelvin Jiang <kelvi...@chromium.org>
      Gerrit-Attention: Jesse McKenna <jessem...@google.com>
      Gerrit-Comment-Date: Thu, 25 Jun 2026 22:16:54 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Eva Su (Gerrit)

      unread,
      Jun 25, 2026, 7:10:47 PM (5 hours ago) Jun 25
      to Code Review Nudger, Kelvin Jiang, Rushan Suleymanov, Chromium Sync Reviews, Jesse McKenna, Devlin Cronin, Chromium LUCI CQ, Chromium Metrics Reviews, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, asvitkine...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org
      Attention needed from Devlin Cronin, Jesse McKenna, Kelvin Jiang and Rushan Suleymanov

      Eva Su added 1 comment

      File chrome/browser/ui/webui/extensions/extensions_ui.cc
      Line 472, Patchset 8: source->AddBoolean(

      "extensionsPinnedByDefault",
      profile->GetPrefs()->GetBoolean(prefs::kExtensionsPinnedByDefault));
      Devlin Cronin . resolved

      Given this is exposed in the ProfileInfo in developerPrivate, I don't think we also need it exposed this way. Can we just use the one from the profile info instead of having two?

      Eva Su

      Good catch! I've removed this configuration from ExtensionsUI and verified via demo that the behavior is still WAI

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Devlin Cronin
      • Jesse McKenna
      • Kelvin Jiang
      • Rushan Suleymanov
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Iedbae1500b1b8fd24187bc454c369288e6855f8b
        Gerrit-Change-Number: 7958486
        Gerrit-PatchSet: 9
        Gerrit-Owner: Eva Su <ev...@chromium.org>
        Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
        Gerrit-Reviewer: Eva Su <ev...@chromium.org>
        Gerrit-Reviewer: Jesse McKenna <jessem...@google.com>
        Gerrit-Reviewer: Kelvin Jiang <kelvi...@chromium.org>
        Gerrit-Reviewer: Rushan Suleymanov <rus...@google.com>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-CC: Chromium Sync Reviews <chromium-s...@google.com>
        Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
        Gerrit-Attention: Devlin Cronin <rdevlin...@chromium.org>
        Gerrit-Attention: Kelvin Jiang <kelvi...@chromium.org>
        Gerrit-Attention: Rushan Suleymanov <rus...@google.com>
        Gerrit-Attention: Jesse McKenna <jessem...@google.com>
        Gerrit-Comment-Date: Thu, 25 Jun 2026 23:10:33 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Devlin Cronin <rdevlin...@chromium.org>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages